From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 16 May 2018 08:26:23 +0200 From: Greg Kroah-Hartman To: Masahiro Yamada Cc: Andrew Morton , Geert Uytterhoeven , Alexey Dobriyan , Lihao Liang , Linux Kernel Mailing List , Philippe Ombredanne , Pekka Enberg Subject: Re: [PATCH 3/3] types: use fixed width types without double-underscore prefix Message-ID: <20180516062623.GA32694@kroah.com> References: <1526350925-14922-1-git-send-email-yamada.masahiro@socionext.com> <1526350925-14922-3-git-send-email-yamada.masahiro@socionext.com> <20180515155925.9c16962e2b416e5f507c07b1@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.5 (2018-04-13) X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Wed, May 16, 2018 at 10:07:50AM +0900, Masahiro Yamada wrote: > Hi Andrew, > > 2018-05-16 7:59 GMT+09:00 Andrew Morton : > > On Tue, 15 May 2018 11:22:05 +0900 Masahiro Yamada wrote: > > > >> This header file is not exported. It is safe to reference types > >> without double-underscore prefix. > >> > > > > It may be safe to do this, but why is it desirable? > > > It is shorter. That's all. > If it is a noise commit, please feel free to drop it. > > > BTW, a large amount of kernel-space code > uses underscore-prefixed types. Sometimes it can/should do that. > I wonder if we could check it by checkpatch.pl or something... You do understand the difference between the two types and why/when they are needed, right? I don't think checkpatch.pl can determine if data is coming from userspace or not very easily to make this a simple perl script check :( thanks, greg k-h