From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH 3/3] arm64: dts: renesas: r8a7795: add ccree binding Date: Wed, 16 May 2018 09:43:34 +0200 Message-ID: <20180516074333.i2672u435ymwffk3@verge.net.au> References: <1526387370-17142-1-git-send-email-gilad@benyossef.com> <1526387370-17142-4-git-send-email-gilad@benyossef.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Gilad Ben-Yossef , Magnus Damm , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Michael Turquette , Stephen Boyd , Herbert Xu , "David S. Miller" , Ofir Drang , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , Linux Kernel Mailing List , linux-clk , To: Geert Uytterhoeven Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On Tue, May 15, 2018 at 04:50:44PM +0200, Geert Uytterhoeven wrote: > Hi Gilad, > > On Tue, May 15, 2018 at 2:29 PM, Gilad Ben-Yossef wrote: > > Add bindings for CryptoCell instance in the SoC. > > > > Signed-off-by: Gilad Ben-Yossef > > Thanks for your patch! > > > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > > @@ -528,6 +528,14 @@ > > status = "disabled"; > > }; > > > > + arm_cc630p: crypto@e6601000 { > > + compatible = "arm,cryptocell-630p-ree"; > > + interrupts = ; > > + #interrupt-cells = <2>; > > I believe the #interrupt-cells property is not needed. > > > + reg = <0x0 0xe6601000 0 0x1000>; > > + clocks = <&cpg CPG_MOD 229>; > > + }; > > The rest looks good, but I cannot verify the register block. > > > + > > i2c3: i2c@e66d0000 { > > #address-cells = <1>; > > #size-cells = <0>; Thanks, I have applied this after dropping the #interrupt-cells property. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752715AbeEPHno (ORCPT ); Wed, 16 May 2018 03:43:44 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:51053 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752686AbeEPHnj (ORCPT ); Wed, 16 May 2018 03:43:39 -0400 Date: Wed, 16 May 2018 09:43:34 +0200 From: Simon Horman To: Geert Uytterhoeven Cc: Gilad Ben-Yossef , Magnus Damm , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Michael Turquette , Stephen Boyd , Herbert Xu , "David S. Miller" , Ofir Drang , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , Linux Kernel Mailing List , linux-clk , Linux Crypto Mailing List Subject: Re: [PATCH 3/3] arm64: dts: renesas: r8a7795: add ccree binding Message-ID: <20180516074333.i2672u435ymwffk3@verge.net.au> References: <1526387370-17142-1-git-send-email-gilad@benyossef.com> <1526387370-17142-4-git-send-email-gilad@benyossef.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organisation: Horms Solutions BV User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 15, 2018 at 04:50:44PM +0200, Geert Uytterhoeven wrote: > Hi Gilad, > > On Tue, May 15, 2018 at 2:29 PM, Gilad Ben-Yossef wrote: > > Add bindings for CryptoCell instance in the SoC. > > > > Signed-off-by: Gilad Ben-Yossef > > Thanks for your patch! > > > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > > @@ -528,6 +528,14 @@ > > status = "disabled"; > > }; > > > > + arm_cc630p: crypto@e6601000 { > > + compatible = "arm,cryptocell-630p-ree"; > > + interrupts = ; > > + #interrupt-cells = <2>; > > I believe the #interrupt-cells property is not needed. > > > + reg = <0x0 0xe6601000 0 0x1000>; > > + clocks = <&cpg CPG_MOD 229>; > > + }; > > The rest looks good, but I cannot verify the register block. > > > + > > i2c3: i2c@e66d0000 { > > #address-cells = <1>; > > #size-cells = <0>; Thanks, I have applied this after dropping the #interrupt-cells property. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH 3/3] arm64: dts: renesas: r8a7795: add ccree binding Date: Wed, 16 May 2018 09:43:34 +0200 Message-ID: <20180516074333.i2672u435ymwffk3@verge.net.au> References: <1526387370-17142-1-git-send-email-gilad@benyossef.com> <1526387370-17142-4-git-send-email-gilad@benyossef.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Gilad Ben-Yossef , Magnus Damm , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Michael Turquette , Stephen Boyd , Herbert Xu , "David S. Miller" , Ofir Drang , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , Linux Kernel Mailing List , linux-clk List-Id: devicetree@vger.kernel.org On Tue, May 15, 2018 at 04:50:44PM +0200, Geert Uytterhoeven wrote: > Hi Gilad, > > On Tue, May 15, 2018 at 2:29 PM, Gilad Ben-Yossef wrote: > > Add bindings for CryptoCell instance in the SoC. > > > > Signed-off-by: Gilad Ben-Yossef > > Thanks for your patch! > > > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > > @@ -528,6 +528,14 @@ > > status = "disabled"; > > }; > > > > + arm_cc630p: crypto@e6601000 { > > + compatible = "arm,cryptocell-630p-ree"; > > + interrupts = ; > > + #interrupt-cells = <2>; > > I believe the #interrupt-cells property is not needed. > > > + reg = <0x0 0xe6601000 0 0x1000>; > > + clocks = <&cpg CPG_MOD 229>; > > + }; > > The rest looks good, but I cannot verify the register block. > > > + > > i2c3: i2c@e66d0000 { > > #address-cells = <1>; > > #size-cells = <0>; Thanks, I have applied this after dropping the #interrupt-cells property. From mboxrd@z Thu Jan 1 00:00:00 1970 From: horms@verge.net.au (Simon Horman) Date: Wed, 16 May 2018 09:43:34 +0200 Subject: [PATCH 3/3] arm64: dts: renesas: r8a7795: add ccree binding In-Reply-To: References: <1526387370-17142-1-git-send-email-gilad@benyossef.com> <1526387370-17142-4-git-send-email-gilad@benyossef.com> Message-ID: <20180516074333.i2672u435ymwffk3@verge.net.au> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, May 15, 2018 at 04:50:44PM +0200, Geert Uytterhoeven wrote: > Hi Gilad, > > On Tue, May 15, 2018 at 2:29 PM, Gilad Ben-Yossef wrote: > > Add bindings for CryptoCell instance in the SoC. > > > > Signed-off-by: Gilad Ben-Yossef > > Thanks for your patch! > > > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > > @@ -528,6 +528,14 @@ > > status = "disabled"; > > }; > > > > + arm_cc630p: crypto at e6601000 { > > + compatible = "arm,cryptocell-630p-ree"; > > + interrupts = ; > > + #interrupt-cells = <2>; > > I believe the #interrupt-cells property is not needed. > > > + reg = <0x0 0xe6601000 0 0x1000>; > > + clocks = <&cpg CPG_MOD 229>; > > + }; > > The rest looks good, but I cannot verify the register block. > > > + > > i2c3: i2c at e66d0000 { > > #address-cells = <1>; > > #size-cells = <0>; Thanks, I have applied this after dropping the #interrupt-cells property.