From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrea Arcangeli <aarcange@redhat.com>,
Andi Kleen <andi.kleen@intel.com>, Jan Kara <jack@suse.cz>,
Michal Hocko <mhocko@suse.com>,
Matthew Wilcox <mawilcox@microsoft.com>,
Hugh Dickins <hughd@google.com>, Minchan Kim <minchan@kernel.org>,
Shaohua Li <shli@fb.com>, Christopher Lameter <cl@linux.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Punit Agrawal <punit.agrawal@arm.com>,
Anshuman Khandual <khandual@linux.vnet.ibm.com>
Subject: Re: [PATCH -mm] mm, hugetlb: Pass fault address to no page handler
Date: Wed, 16 May 2018 11:03:12 +0300 [thread overview]
Message-ID: <20180516080312.rx6owusozklkmypj@black.fi.intel.com> (raw)
In-Reply-To: <878t8kzb0c.fsf@yhuang-dev.intel.com>
On Wed, May 16, 2018 at 12:42:43AM +0000, Huang, Ying wrote:
> >> + unsigned long address = faddress & huge_page_mask(h);
> >
> > faddress? I would rather keep it address and rename maked out variable to
> > 'haddr'. We use 'haddr' for the cause in other places.
>
> I found haddr is popular in huge_memory.c but not used in hugetlb.c at
> all. Is it desirable to start to use "haddr" in hugetlb.c?
Yes, I think so. There's no reason to limit haddr convention to THP.
--
Kirill A. Shutemov
next prev parent reply other threads:[~2018-05-16 8:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 0:57 [PATCH -mm] mm, hugetlb: Pass fault address to no page handler Huang, Ying
2018-05-15 3:25 ` Mike Kravetz
2018-05-15 5:19 ` Huang, Ying
2018-05-15 10:38 ` Kirill A. Shutemov
2018-05-16 0:42 ` Huang, Ying
2018-05-16 8:03 ` Kirill A. Shutemov [this message]
2018-05-17 1:39 ` Huang, Ying
2018-05-15 20:03 ` David Rientjes
2018-05-16 9:12 ` Michal Hocko
2018-05-16 20:04 ` Mike Kravetz
2018-05-17 1:45 ` Huang, Ying
2018-05-17 1:41 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180516080312.rx6owusozklkmypj@black.fi.intel.com \
--to=kirill.shutemov@linux.intel.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi.kleen@intel.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=cl@linux.com \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=khandual@linux.vnet.ibm.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mawilcox@microsoft.com \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=punit.agrawal@arm.com \
--cc=shli@fb.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.