All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: Fam Zheng <famz@redhat.com>, qemu-devel <qemu-devel@nongnu.org>,
	qemu block <qemu-block@nongnu.org>, Max Reitz <mreitz@redhat.com>,
	John Snow <jsnow@redhat.com>,
	"gilbert >> Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Juan Q >> Juan Jose Quintela Carreira" <quintela@redhat.com>
Subject: Re: [Qemu-devel] Restoring bitmaps after failed/cancelled migration
Date: Wed, 16 May 2018 14:47:55 +0200	[thread overview]
Message-ID: <20180516124755.GB4435@localhost.localdomain> (raw)
In-Reply-To: <9a59b786-2351-e8ae-f582-5e436ce0383c@virtuozzo.com>

Am 14.05.2018 um 12:09 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 14.05.2018 09:41, Fam Zheng wrote:
> > On Wed, 04/18 17:00, Vladimir Sementsov-Ogievskiy wrote:
> > > Is it possible, that target will change the disk, and then we return control
> > > to the source? In this case bitmaps will be invalid. So, should not we drop
> > > all the bitmaps on inactivate?
> > Yes, dropping all live bitmaps upon inactivate sounds reasonable. If the dst
> > fails to start, and we want to resume VM at src, we could (optionally?) reload
> > the persistent bitmaps, I guess.
> 
> Reload from where? We didn't store them.

Maybe this just means that it turns out that not storing them was a bad
idea?

What was the motivation for not storing the bitmap? The additional
downtime? Is it really that bad, though? Bitmaps should be fairly small
for the usual image sizes and writing them out should be quick.

Kevin

  parent reply	other threads:[~2018-05-16 12:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18 14:00 [Qemu-devel] Restoring bitmaps after failed/cancelled migration Vladimir Sementsov-Ogievskiy
2018-04-23 18:41 ` Dr. David Alan Gilbert
2018-05-11 21:23 ` John Snow
2018-05-14  9:55   ` Vladimir Sementsov-Ogievskiy
2018-05-14  6:41 ` Fam Zheng
2018-05-14 10:09   ` Vladimir Sementsov-Ogievskiy
2018-05-14 10:23     ` Vladimir Sementsov-Ogievskiy
2018-05-15  2:03       ` Fam Zheng
2018-05-16 12:47     ` Kevin Wolf [this message]
2018-05-16 15:10       ` Vladimir Sementsov-Ogievskiy
2018-05-16 15:32         ` Kevin Wolf
2018-05-16 15:52           ` Vladimir Sementsov-Ogievskiy
2018-05-17  2:14             ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180516124755.GB4435@localhost.localdomain \
    --to=kwolf@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=famz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.