From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:47485 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752311AbeEPM7S (ORCPT ); Wed, 16 May 2018 08:59:18 -0400 Date: Wed, 16 May 2018 15:03:44 +0200 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , Souptick Joarder , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, devel@lists.orangefs.org, ceph-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-mtd@lists.infradead.org, dri-devel@lists.freedesktop.org, lustre-devel@lists.lustre.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [PATCH 14/14] mm: turn on vm_fault_t type checking Message-ID: <20180516130344.GC32454@lst.de> References: <20180516054348.15950-1-hch@lst.de> <20180516054348.15950-15-hch@lst.de> <20180516112813.GC20670@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <20180516112813.GC20670@bombadil.infradead.org> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Wed, May 16, 2018 at 04:28:13AM -0700, Matthew Wilcox wrote: > On Wed, May 16, 2018 at 07:43:48AM +0200, Christoph Hellwig wrote: > > Switch vm_fault_t to point to an unsigned int with __bіtwise annotations. > > This both catches any old ->fault or ->page_mkwrite instance with plain > > compiler type checking, as well as finding more intricate problems with > > sparse. > > Come on, Christoph; you know better than this. This patch is completely > unreviewable. Split it into one patch per maintainer tree, and in any > event, the patch to convert vm_fault_t to an unsigned int should be > separated from all the trivial conversions. The whole point is that tiny split patches for mechnical translations are totally pointless. Switching the typedef might be worth splitting if people really insist. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 14/14] mm: turn on vm_fault_t type checking Date: Wed, 16 May 2018 15:03:44 +0200 Message-ID: <20180516130344.GC32454@lst.de> References: <20180516054348.15950-1-hch@lst.de> <20180516054348.15950-15-hch@lst.de> <20180516112813.GC20670@bombadil.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180516112813.GC20670@bombadil.infradead.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" List-Archive: List-Post: To: Matthew Wilcox Cc: linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, ocfs2-devel@oss.oracle.com, Souptick Joarder , linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org, ceph-devel@vger.kernel.org, linux-ext4@vger.kernel.org, Christoph Hellwig , devel@lists.orangefs.org, lustre-devel@lists.lustre.org List-ID: T24gV2VkLCBNYXkgMTYsIDIwMTggYXQgMDQ6Mjg6MTNBTSAtMDcwMCwgTWF0dGhldyBXaWxjb3gg d3JvdGU6Cj4gT24gV2VkLCBNYXkgMTYsIDIwMTggYXQgMDc6NDM6NDhBTSArMDIwMCwgQ2hyaXN0 b3BoIEhlbGx3aWcgd3JvdGU6Cj4gPiBTd2l0Y2ggdm1fZmF1bHRfdCB0byBwb2ludCB0byBhbiB1 bnNpZ25lZCBpbnQgd2l0aCBfX2LRlnR3aXNlIGFubm90YXRpb25zLgo+ID4gVGhpcyBib3RoIGNh dGNoZXMgYW55IG9sZCAtPmZhdWx0IG9yIC0+cGFnZV9ta3dyaXRlIGluc3RhbmNlIHdpdGggcGxh aW4KPiA+IGNvbXBpbGVyIHR5cGUgY2hlY2tpbmcsIGFzIHdlbGwgYXMgZmluZGluZyBtb3JlIGlu dHJpY2F0ZSBwcm9ibGVtcyB3aXRoCj4gPiBzcGFyc2UuCj4gCj4gQ29tZSBvbiwgQ2hyaXN0b3Bo OyB5b3Uga25vdyBiZXR0ZXIgdGhhbiB0aGlzLiAgVGhpcyBwYXRjaCBpcyBjb21wbGV0ZWx5Cj4g dW5yZXZpZXdhYmxlLiAgU3BsaXQgaXQgaW50byBvbmUgcGF0Y2ggcGVyIG1haW50YWluZXIgdHJl ZSwgYW5kIGluIGFueQo+IGV2ZW50LCB0aGUgcGF0Y2ggdG8gY29udmVydCB2bV9mYXVsdF90IHRv IGFuIHVuc2lnbmVkIGludCBzaG91bGQgYmUKPiBzZXBhcmF0ZWQgZnJvbSBhbGwgdGhlIHRyaXZp YWwgY29udmVyc2lvbnMuCgpUaGUgd2hvbGUgcG9pbnQgaXMgdGhhdCB0aW55IHNwbGl0IHBhdGNo ZXMgZm9yIG1lY2huaWNhbCB0cmFuc2xhdGlvbnMKYXJlIHRvdGFsbHkgcG9pbnRsZXNzLiAgU3dp dGNoaW5nIHRoZSB0eXBlZGVmIG1pZ2h0IGJlIHdvcnRoIHNwbGl0dGluZwppZiBwZW9wbGUgcmVh bGx5IGluc2lzdC4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Wed, 16 May 2018 15:03:44 +0200 Subject: [Ocfs2-devel] [PATCH 14/14] mm: turn on vm_fault_t type checking In-Reply-To: <20180516112813.GC20670@bombadil.infradead.org> References: <20180516054348.15950-1-hch@lst.de> <20180516054348.15950-15-hch@lst.de> <20180516112813.GC20670@bombadil.infradead.org> Message-ID: <20180516130344.GC32454@lst.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Matthew Wilcox Cc: linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, ocfs2-devel@oss.oracle.com, Souptick Joarder , linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org, ceph-devel@vger.kernel.org, linux-ext4@vger.kernel.org, Christoph Hellwig , devel@lists.orangefs.org, lustre-devel@lists.lustre.org On Wed, May 16, 2018 at 04:28:13AM -0700, Matthew Wilcox wrote: > On Wed, May 16, 2018 at 07:43:48AM +0200, Christoph Hellwig wrote: > > Switch vm_fault_t to point to an unsigned int with __b?twise annotations. > > This both catches any old ->fault or ->page_mkwrite instance with plain > > compiler type checking, as well as finding more intricate problems with > > sparse. > > Come on, Christoph; you know better than this. This patch is completely > unreviewable. Split it into one patch per maintainer tree, and in any > event, the patch to convert vm_fault_t to an unsigned int should be > separated from all the trivial conversions. The whole point is that tiny split patches for mechnical translations are totally pointless. Switching the typedef might be worth splitting if people really insist. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f72.google.com (mail-wm0-f72.google.com [74.125.82.72]) by kanga.kvack.org (Postfix) with ESMTP id A93766B0329 for ; Wed, 16 May 2018 08:59:17 -0400 (EDT) Received: by mail-wm0-f72.google.com with SMTP id f63-v6so324101wmi.4 for ; Wed, 16 May 2018 05:59:17 -0700 (PDT) Received: from newverein.lst.de (verein.lst.de. [213.95.11.211]) by mx.google.com with ESMTPS id r63-v6si1950891wmr.125.2018.05.16.05.59.16 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 May 2018 05:59:16 -0700 (PDT) Date: Wed, 16 May 2018 15:03:44 +0200 From: Christoph Hellwig Subject: Re: [PATCH 14/14] mm: turn on vm_fault_t type checking Message-ID: <20180516130344.GC32454@lst.de> References: <20180516054348.15950-1-hch@lst.de> <20180516054348.15950-15-hch@lst.de> <20180516112813.GC20670@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180516112813.GC20670@bombadil.infradead.org> Sender: owner-linux-mm@kvack.org List-ID: To: Matthew Wilcox Cc: Christoph Hellwig , Souptick Joarder , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, devel@lists.orangefs.org, ceph-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-mtd@lists.infradead.org, dri-devel@lists.freedesktop.org, lustre-devel@lists.lustre.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org On Wed, May 16, 2018 at 04:28:13AM -0700, Matthew Wilcox wrote: > On Wed, May 16, 2018 at 07:43:48AM +0200, Christoph Hellwig wrote: > > Switch vm_fault_t to point to an unsigned int with __bN?twise annotations. > > This both catches any old ->fault or ->page_mkwrite instance with plain > > compiler type checking, as well as finding more intricate problems with > > sparse. > > Come on, Christoph; you know better than this. This patch is completely > unreviewable. Split it into one patch per maintainer tree, and in any > event, the patch to convert vm_fault_t to an unsigned int should be > separated from all the trivial conversions. The whole point is that tiny split patches for mechnical translations are totally pointless. Switching the typedef might be worth splitting if people really insist. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Wed, 16 May 2018 15:03:44 +0200 Subject: [lustre-devel] [PATCH 14/14] mm: turn on vm_fault_t type checking In-Reply-To: <20180516112813.GC20670@bombadil.infradead.org> References: <20180516054348.15950-1-hch@lst.de> <20180516054348.15950-15-hch@lst.de> <20180516112813.GC20670@bombadil.infradead.org> Message-ID: <20180516130344.GC32454@lst.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Matthew Wilcox Cc: linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, ocfs2-devel@oss.oracle.com, Souptick Joarder , linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org, ceph-devel@vger.kernel.org, linux-ext4@vger.kernel.org, Christoph Hellwig , devel@lists.orangefs.org, lustre-devel@lists.lustre.org On Wed, May 16, 2018 at 04:28:13AM -0700, Matthew Wilcox wrote: > On Wed, May 16, 2018 at 07:43:48AM +0200, Christoph Hellwig wrote: > > Switch vm_fault_t to point to an unsigned int with __b?twise annotations. > > This both catches any old ->fault or ->page_mkwrite instance with plain > > compiler type checking, as well as finding more intricate problems with > > sparse. > > Come on, Christoph; you know better than this. This patch is completely > unreviewable. Split it into one patch per maintainer tree, and in any > event, the patch to convert vm_fault_t to an unsigned int should be > separated from all the trivial conversions. The whole point is that tiny split patches for mechnical translations are totally pointless. Switching the typedef might be worth splitting if people really insist. From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@lst.de (Christoph Hellwig) Date: Wed, 16 May 2018 15:03:44 +0200 Subject: [PATCH 14/14] mm: turn on vm_fault_t type checking In-Reply-To: <20180516112813.GC20670@bombadil.infradead.org> References: <20180516054348.15950-1-hch@lst.de> <20180516054348.15950-15-hch@lst.de> <20180516112813.GC20670@bombadil.infradead.org> Message-ID: <20180516130344.GC32454@lst.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, May 16, 2018 at 04:28:13AM -0700, Matthew Wilcox wrote: > On Wed, May 16, 2018 at 07:43:48AM +0200, Christoph Hellwig wrote: > > Switch vm_fault_t to point to an unsigned int with __b?twise annotations. > > This both catches any old ->fault or ->page_mkwrite instance with plain > > compiler type checking, as well as finding more intricate problems with > > sparse. > > Come on, Christoph; you know better than this. This patch is completely > unreviewable. Split it into one patch per maintainer tree, and in any > event, the patch to convert vm_fault_t to an unsigned int should be > separated from all the trivial conversions. The whole point is that tiny split patches for mechnical translations are totally pointless. Switching the typedef might be worth splitting if people really insist.