From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: i.MX6S/DL and QCA8334 switch using DSA driver - CPU port not working Date: Wed, 16 May 2018 15:17:53 +0200 Message-ID: <20180516131753.GG22000@lunn.ch> References: <48c029f1-1632-573f-c628-86b4972d668c@gmail.com> <20180430132025.GF10066@lunn.ch> <573258a9-b115-ca4a-121c-5174798d5621@gmail.com> <20180504133014.GB9666@lunn.ch> <5e8ecfed-c772-5668-4bac-1549143f599a@gmail.com> <20180510142904.GB7698@lunn.ch> <46a92995-b976-130c-7658-4d9576d5bee9@gmail.com> <20180515160824.GJ27867@lunn.ch> <21fc20c7-77d2-cba0-8f58-6bacb41f0970@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Florian Fainelli , netdev@vger.kernel.org, Vivien Didelot To: Michal =?utf-8?B?Vm9rw6HEjQ==?= Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:33106 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752133AbeEPNRz (ORCPT ); Wed, 16 May 2018 09:17:55 -0400 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: > So as the fixed-link subnode is optional we still should force some sensible > defaults if it is not used. Same as Marvell drives does. Can I say that we > agreed that the current CPU port setting is not correct and the fastest link > speed and duplex supported by the chip should be set as a default? That is a sensible default. > >As far as people using this driver, John submitted it, but we have not > >see many fixes/enhancements, so I am not clear who is actually using it > >these days... glad you are though! > > Thanks. > > To the compatibility of the driver with the QCA8334 that I use. I am not sure > what should be the correct way to deal with that. For example Marvell binding > uses only two compatible strings for a large range of chips in one family. > While Broadcom has one compatible string for each chip. With the Marvell devices, there is an ID register which tells you the model. The compatible string tells us the information we need in order to find that ID register. Once we know the ID, we have all the information we need, so don't need a more specific compatible string. > As I mentioned earlier > in this thread the QCA8334 switch has four ports while the already supported > QCA8337 has seven ports. That is the only difference. Register address space > is the same. Can you identify the exact model using some ID register? If yes, than the existing compatible string is sufficient. If no, you need an additional compatible string. Andrew