From: Andrew Lunn <andrew@lunn.ch>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/3] sh_eth: add RGMII support
Date: Wed, 16 May 2018 22:30:31 +0200 [thread overview]
Message-ID: <20180516203031.GI26028@lunn.ch> (raw)
In-Reply-To: <38a56174-c05d-8864-adf0-d3099e426a60@cogentembedded.com>
On Wed, May 16, 2018 at 10:56:45PM +0300, Sergei Shtylyov wrote:
> The R-Car V3H (AKA R8A77980) GEther controller adds support for the RGMII
> PHY interface mode as a new value for the RMII_MII register.
>
> Based on the original (and large) patch by Vladimir Barinov.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> drivers/net/ethernet/renesas/sh_eth.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> Index: net-next/drivers/net/ethernet/renesas/sh_eth.c
> ===================================================================
> --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.c
> +++ net-next/drivers/net/ethernet/renesas/sh_eth.c
> @@ -466,6 +466,9 @@ static void sh_eth_select_mii(struct net
> u32 value;
>
> switch (mdp->phy_interface) {
> + case PHY_INTERFACE_MODE_RGMII:
> + value = 0x3;
> + break;
Hi Sergei
What about
PHY_INTERFACE_MODE_RGMII_ID,
PHY_INTERFACE_MODE_RGMII_RXID,
PHY_INTERFACE_MODE_RGMII_TXID,
Andrew
next prev parent reply other threads:[~2018-05-16 20:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 19:52 [PATCH 0/3] Add R8A77980 GEther support Sergei Shtylyov
2018-05-16 19:56 ` [PATCH 1/3] sh_eth: add RGMII support Sergei Shtylyov
2018-05-16 20:30 ` Andrew Lunn [this message]
2018-05-16 20:34 ` Sergei Shtylyov
2018-05-16 20:37 ` Andrew Lunn
2018-05-17 8:15 ` Sergei Shtylyov
2018-05-16 19:58 ` [PATCH 2/3] sh_eth: add EDMR.NBST support Sergei Shtylyov
2018-05-17 8:12 ` Simon Horman
2018-05-16 20:00 ` [PATCH 3/3] sh_eth: add R8A77980 support Sergei Shtylyov
2018-05-17 8:56 ` Simon Horman
2018-05-17 18:53 ` [PATCH 0/3] Add R8A77980 GEther support David Miller
2018-05-18 11:00 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180516203031.GI26028@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.