From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] net: NET_VENDOR_MICROSEMI should default ot N Date: Thu, 17 May 2018 12:32:03 -0400 (EDT) Message-ID: <20180517.123203.962104853214011861.davem@davemloft.net> References: <20180517154330.10678-1-dsahern@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, alexandre.belloni@bootlin.com To: dsahern@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:58520 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752173AbeEQQcH (ORCPT ); Thu, 17 May 2018 12:32:07 -0400 In-Reply-To: <20180517154330.10678-1-dsahern@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: David Ahern Date: Thu, 17 May 2018 08:43:30 -0700 > Other ethernet drivers default to N. There is no reason for Microsemi > to default to y. I believe Linus has set the bar at a feature that cures > cancer can be enabled by default. [1] > > [1] https://lkml.org/lkml/2010/3/2/366 > > Signed-off-by: David Ahern For "drivers" yes, those should default to N. But for vendor guards like this, they should default to Y.