From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: dmaengine: sprd: fix an NULL vs IS_ERR() bug From: Vinod Koul Message-Id: <20180517043105.GR13271@vkoul-mobl> Date: Thu, 17 May 2018 10:01:05 +0530 To: Dan Carpenter Cc: Dan Williams , Baolin Wang , Orson Zhai , Chunyan Zhang , dmaengine@vger.kernel.org, kernel-janitors@vger.kernel.org List-ID: T24gMTYtMDUtMTgsIDExOjQ4LCBEYW4gQ2FycGVudGVyIHdyb3RlOgo+IFdlIHJlY2VudGx5IGNs ZWFuZWQgdGhpcyBjb2RlIHVwIGJ1dCB3ZSBuZWVkIHRvIHVwZGF0ZSB0aGUgZXJyb3IKPiBoYW5k bGluZyBhcyB3ZWxsLiAgVGhlIGRldm1faW9yZW1hcF9yZXNvdXJjZSgpIHJldHVybnMgZXJyb3Ig cG9pbnRlcnMgb24KPiBlcnJvciwgbmV2ZXIgTlVMTC4KCkFwcGxpZWQsIHRoYW5rcwo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Date: Thu, 17 May 2018 04:43:05 +0000 Subject: Re: [PATCH] dmaengine: sprd: fix an NULL vs IS_ERR() bug Message-Id: <20180517043105.GR13271@vkoul-mobl> List-Id: References: <20180516084807.GA23043@mwanda> In-Reply-To: <20180516084807.GA23043@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Dan Williams , Baolin Wang , Orson Zhai , Chunyan Zhang , dmaengine@vger.kernel.org, kernel-janitors@vger.kernel.org On 16-05-18, 11:48, Dan Carpenter wrote: > We recently cleaned this code up but we need to update the error > handling as well. The devm_ioremap_resource() returns error pointers on > error, never NULL. Applied, thanks -- ~Vinod