From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v4 11/23] rte_mbuf.h: explicit cast
 restricting ptrdiff to uint16
Date: Thu, 17 May 2018 11:50:42 +0100
Message-ID: <20180517105042.GC22048@bricha3-MOBL.ger.corp.intel.com>
References: <152627436523.53156.4398253089110011263.stgit@localhost.localdomain>
 <152627462287.53156.1972221889368883834.stgit@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Andy Green <andy@warmcat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 868665B1C
 for <dev@dpdk.org>; Thu, 17 May 2018 12:50:46 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <152627462287.53156.1972221889368883834.stgit@localhost.localdomain>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, May 14, 2018 at 01:10:22PM +0800, Andy Green wrote:
> /projects/lagopus/src/dpdk/build/include/rte_common.h:141:34:
> warning: conversion from 'long unsigned int' to 'uint16_t'
> {aka 'short unsigned int'} may change value [-Wconversion]
>  #define RTE_PTR_DIFF(ptr1, ptr2) ((uintptr_t)(ptr1) -
> (uintptr_t)(ptr2))
>                                   ^
> /projects/lagopus/src/dpdk/build/include/rte_mbuf.h:1360:13:
> note: in expansion of macro 'RTE_PTR_DIFF'
>   *buf_len = RTE_PTR_DIFF(shinfo, buf_addr);
> 
> Signed-off-by: Andy Green <andy@warmcat.com>
> ---
>  lib/librte_mbuf/rte_mbuf.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> index a27dbb878..0580ec8a0 100644
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -1358,7 +1358,7 @@ rte_pktmbuf_ext_shinfo_init_helper(void *buf_addr, uint16_t *buf_len,
>  	shinfo->fcb_opaque = fcb_opaque;
>  	rte_mbuf_ext_refcnt_set(shinfo, 1);
>  
> -	*buf_len = RTE_PTR_DIFF(shinfo, buf_addr);
> +	*buf_len = (uint16_t)RTE_PTR_DIFF(shinfo, buf_addr);
>  	return shinfo;
>  }
Acked-by: Bruce Richardson <bruce.richardson@intel.com>