All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 7/7] nvme-pci: drop IRQ disabling on submission queue lock
Date: Thu, 17 May 2018 18:31:52 +0200	[thread overview]
Message-ID: <20180517163152.23155-8-hch@lst.de> (raw)
In-Reply-To: <20180517163152.23155-1-hch@lst.de>

From: Jens Axboe <axboe@kernel.dk>

Since we aren't sharing the lock for completions now, we don't
have to make it IRQ safe.

Reviewed-by: Christoph Hellwig <hch at lst.de>
Signed-off-by: Jens Axboe <axboe at kernel.dk>
Signed-off-by: Christoph Hellwig <hch at lst.de>
---
 drivers/nvme/host/pci.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 49c783801fd4..96cf91256fc8 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -895,9 +895,9 @@ static blk_status_t nvme_queue_rq(struct blk_mq_hw_ctx *hctx,
 
 	blk_mq_start_request(req);
 
-	spin_lock_irq(&nvmeq->sq_lock);
+	spin_lock(&nvmeq->sq_lock);
 	__nvme_submit_cmd(nvmeq, &cmnd);
-	spin_unlock_irq(&nvmeq->sq_lock);
+	spin_unlock(&nvmeq->sq_lock);
 	return BLK_STS_OK;
 out_cleanup_iod:
 	nvme_free_iod(dev, req);
@@ -1052,9 +1052,9 @@ static void nvme_pci_submit_async_event(struct nvme_ctrl *ctrl)
 	c.common.opcode = nvme_admin_async_event;
 	c.common.command_id = NVME_AQ_BLK_MQ_DEPTH;
 
-	spin_lock_irq(&nvmeq->sq_lock);
+	spin_lock(&nvmeq->sq_lock);
 	__nvme_submit_cmd(nvmeq, &c);
-	spin_unlock_irq(&nvmeq->sq_lock);
+	spin_unlock(&nvmeq->sq_lock);
 }
 
 static int adapter_delete_queue(struct nvme_dev *dev, u8 opcode, u16 id)
-- 
2.17.0

  parent reply	other threads:[~2018-05-17 16:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-17 16:31 RFC: handle completions outside the queue lock and split the queue lock Christoph Hellwig
2018-05-17 16:31 ` [PATCH 1/7] nvme: mark the result argument to nvme_complete_async_event volatile Christoph Hellwig
2018-05-17 16:31 ` [PATCH 2/7] nvme-pci: simplify nvme_cqe_valid Christoph Hellwig
2018-05-17 16:31 ` [PATCH 3/7] nvme-pci: remove cq check after submission Christoph Hellwig
2018-05-17 16:31 ` [PATCH 4/7] nvme-pci: move ->cq_vector == -1 check outside of ->q_lock Christoph Hellwig
2018-05-17 16:31 ` [PATCH 5/7] nvme-pci: handle completions outside of the queue lock Christoph Hellwig
2018-05-17 16:31 ` [PATCH 6/7] nvme-pci: split the nvme queue lock into submission and completion locks Christoph Hellwig
2018-05-17 16:31 ` Christoph Hellwig [this message]
2018-05-17 16:36 ` RFC: handle completions outside the queue lock and split the queue lock Jens Axboe
2018-05-17 16:44   ` Christoph Hellwig
2018-05-17 16:55 ` Keith Busch
2018-05-17 17:00   ` Christoph Hellwig
2018-05-17 17:05     ` Keith Busch
2018-05-17 17:08       ` Jens Axboe
2018-05-18 14:52 [PATCHSET v2 0/7] Improve nvme completion handling Jens Axboe
2018-05-18 14:52 ` [PATCH 7/7] nvme-pci: drop IRQ disabling on submission queue lock Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180517163152.23155-8-hch@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.