From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752197AbeEQT3e (ORCPT ); Thu, 17 May 2018 15:29:34 -0400 Received: from freki.datenkhaos.de ([81.7.17.101]:43542 "EHLO freki.datenkhaos.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752014AbeEQT3b (ORCPT ); Thu, 17 May 2018 15:29:31 -0400 Date: Thu, 17 May 2018 21:29:23 +0200 From: Johannes Hirte To: Borislav Petkov Cc: "Ghannam, Yazen" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "tony.luck@intel.com" , "x86@kernel.org" Subject: Re: [PATCH 3/3] x86/MCE/AMD: Get address from already initialized block Message-ID: <20180517192922.GA11686@probook> References: <20180201184813.82253-1-Yazen.Ghannam@amd.com> <20180201184813.82253-3-Yazen.Ghannam@amd.com> <20180414004230.GA2033@probook> <20180416115624.GA1543@probook> <20180515093953.GA1746@probook> <20180516224641.GA31929@pd.tnic> <20180517064930.GA26421@probook> <20180517104124.GA25595@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180517104124.GA25595@pd.tnic> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018 Mai 17, Borislav Petkov wrote: > On Thu, May 17, 2018 at 08:49:31AM +0200, Johannes Hirte wrote: > > Maybe I'm missing something, but those RDMSR IPSs don't happen on > > pre-SMCA systems, right? So the caching should be avoided here, cause > > the whole lookup looks more expensive to me than the simple switch-block > > in get_block_address. > > Yeah, and we should simply cache all those MSR values as I suggested then. > > The patch at the end should fix your issue. > Works as expected on my Carrizo. -- Regards, Johannes From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [3/3] x86/MCE/AMD: Get address from already initialized block From: Johannes Hirte Message-Id: <20180517192922.GA11686@probook> Date: Thu, 17 May 2018 21:29:23 +0200 To: Borislav Petkov Cc: "Ghannam, Yazen" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "tony.luck@intel.com" , "x86@kernel.org" List-ID: T24gMjAxOCBNYWkgMTcsIEJvcmlzbGF2IFBldGtvdiB3cm90ZToKPiBPbiBUaHUsIE1heSAxNywg MjAxOCBhdCAwODo0OTozMUFNICswMjAwLCBKb2hhbm5lcyBIaXJ0ZSB3cm90ZToKPiA+IE1heWJl IEknbSBtaXNzaW5nIHNvbWV0aGluZywgYnV0IHRob3NlIFJETVNSIElQU3MgZG9uJ3QgaGFwcGVu IG9uCj4gPiBwcmUtU01DQSBzeXN0ZW1zLCByaWdodD8gU28gdGhlIGNhY2hpbmcgc2hvdWxkIGJl IGF2b2lkZWQgaGVyZSwgY2F1c2UKPiA+IHRoZSB3aG9sZSBsb29rdXAgbG9va3MgbW9yZSBleHBl bnNpdmUgdG8gbWUgdGhhbiB0aGUgc2ltcGxlIHN3aXRjaC1ibG9jawo+ID4gaW4gZ2V0X2Jsb2Nr X2FkZHJlc3MuCj4gCj4gWWVhaCwgYW5kIHdlIHNob3VsZCBzaW1wbHkgY2FjaGUgYWxsIHRob3Nl IE1TUiB2YWx1ZXMgYXMgSSBzdWdnZXN0ZWQgdGhlbi4KPiAKPiBUaGUgcGF0Y2ggYXQgdGhlIGVu ZCBzaG91bGQgZml4IHlvdXIgaXNzdWUuCj4gCgpXb3JrcyBhcyBleHBlY3RlZCBvbiBteSBDYXJy aXpvLgo=