All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Sandipan Das <sandipan@linux.vnet.ibm.com>
Cc: jolsa@redhat.com, linux-kernel@vger.kernel.org,
	ravi.bangoria@linux.ibm.com, naveen.n.rao@linux.vnet.ibm.com
Subject: Re: [PATCH 1/2] perf script: Show virtual addresses instead of offsets
Date: Thu, 17 May 2018 16:59:57 -0300	[thread overview]
Message-ID: <20180517195957.GD18538@kernel.org> (raw)
In-Reply-To: <20180517063326.6319-1-sandipan@linux.vnet.ibm.com>

Em Thu, May 17, 2018 at 12:03:25PM +0530, Sandipan Das escreveu:
> When perf data is recorded with the call-graph option enabled,
> the callchain shown by perf script shows the binary offsets of
> the symbols as the ip. This is incorrect for kernel symbols as
> the ip values are always off by a fixed offset depending on the
> architecture. If the offsets from the start of the symbols are
> printed, they are also incorrect for both kernel and userspace
> symbols.
> 
> Without the call-graph option, the callchain shows the virtual
> addresses of the symbols rather than their binary offsets. The
> offsets printed in this case are also correct.
> 
> This fixes the inconsistency in perf script's output.

Thanks, tested and applied,

- Arnaldo

  parent reply	other threads:[~2018-05-17 20:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-17  6:33 [PATCH 1/2] perf script: Show virtual addresses instead of offsets Sandipan Das
2018-05-17  6:33 ` [PATCH 2/2] perf script: Show symbol offsets by default Sandipan Das
2018-05-19 11:45   ` [tip:perf/core] " tip-bot for Sandipan Das
2018-05-17 19:59 ` Arnaldo Carvalho de Melo [this message]
2018-05-18  4:33   ` [PATCH 1/2] perf script: Show virtual addresses instead of offsets Ravi Bangoria
2018-05-19 11:45 ` [tip:perf/core] " tip-bot for Sandipan Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180517195957.GD18538@kernel.org \
    --to=acme@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=naveen.n.rao@linux.vnet.ibm.com \
    --cc=ravi.bangoria@linux.ibm.com \
    --cc=sandipan@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.