From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752519AbeEROOH (ORCPT <rfc822;w@1wt.eu>);
        Fri, 18 May 2018 10:14:07 -0400
Received: from mail.kernel.org ([198.145.29.99]:40122 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752348AbeEROOD (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 18 May 2018 10:14:03 -0400
Date: Fri, 18 May 2018 11:13:59 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@kernel.org>
Cc: Kim Phillips <kim.phillips@arm.com>, Ingo Molnar <mingo@kernel.org>,
        Clark Williams <williams@redhat.com>, linux-kernel@vger.kernel.org,
        linux-perf-users@vger.kernel.org,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>, David Ahern <dsahern@gmail.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH 01/11] perf tests parse-events: Add intel_pt parse test
Message-ID: <20180518141359.GA32141@kernel.org>
References: <20180516144908.22212-1-acme@kernel.org>
 <20180516144908.22212-2-acme@kernel.org>
 <20180516163355.d8e4c669ad29d416e9ffb13e@arm.com>
 <20180517201553.GB25467@kernel.org>
 <20180517205811.GE12497@krava>
 <20180517175410.d23409d805581923bc456ec2@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180517175410.d23409d805581923bc456ec2@arm.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Thu, May 17, 2018 at 05:54:10PM -0500, Kim Phillips escreveu:
> On Thu, 17 May 2018 22:58:11 +0200
> Jiri Olsa <jolsa@redhat.com> wrote:
> 
> > On Thu, May 17, 2018 at 05:15:53PM -0300, Arnaldo Carvalho de Melo wrote:
> > > So parse_state->error == NULL, Jiri, ideas?
> > 
> > yep, we don't use it in tests.. and when trying intel_pt on
> > system without that pmu, the parse_events_add_pmu fails
> > and store the error to NULL.. we should check on that err pointer
> > 
> > wrt to the test itself, how about we add callback
> > to check if the test is valid before we run it,
> > something like below

As Kim says, that is ok, but then, I think that the test would better
reflect reality if it tested all the error paths, i.e. if it, in the
face of a missing PMU, would fill in the error structs, that would then
be checked for validity, etc.

So if instead of checking if the intel_pt PMU is present to perform the
test it would run the test, with te error struct passed as expected,
then, when it fails, check that the failure indicates that indeed, that
PMU is not there by checking that routine you used to bypass the test,
huh?

Thanks,

- Arnaldo

> > jirka
> 
> That diff makes this test pass again on x86 without an intel_pt, and
> on Arm32/64 (the intel_pt test gets skipped on those machines):
> 
> Tested-by: Kim Phillips <kim.phillips@arm.com>
> 
> Thanks,
> 
> Kim