From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net, netanel@amazon.com, saeedb@amazon.com,
zorik@amazon.com
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
jogreene@redhat.com, Mitch Williams <mitch.a.williams@intel.com>
Subject: [net-next 2/2] ena: Fix settings/advertising for ethtool
Date: Fri, 18 May 2018 09:59:47 -0700 [thread overview]
Message-ID: <20180518165947.20948-3-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <20180518165947.20948-1-jeffrey.t.kirsher@intel.com>
It appears that the Amazon Ethernet driver was setting bits in the
'settings' field twice. Almost certainly this was supposed to set bits in
the 'advertising' field instead.
CC: Mitch Williams <mitch.a.williams@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
---
drivers/net/ethernet/amazon/ena/ena_ethtool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/amazon/ena/ena_ethtool.c b/drivers/net/ethernet/amazon/ena/ena_ethtool.c
index 0a4de911e6cc..2f5e4cf84934 100644
--- a/drivers/net/ethernet/amazon/ena/ena_ethtool.c
+++ b/drivers/net/ethernet/amazon/ena/ena_ethtool.c
@@ -283,7 +283,7 @@ static int ena_get_link_ksettings(struct net_device *netdev,
if (link->flags & ENA_ADMIN_GET_FEATURE_LINK_DESC_AUTONEG_MASK) {
ethtool_ks_add_mode(link_ksettings, supported, Autoneg);
- ethtool_ks_add_mode(link_ksettings, supported, Autoneg);
+ ethtool_ks_add_mode(link_ksettings, advertising, Autoneg);
}
link_ksettings->base.autoneg =
--
2.17.0
next prev parent reply other threads:[~2018-05-18 16:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 16:59 [net-next 0/2][pull request] 40GbE Intel Wired LAN Driver Updates 2018-05-18 Jeff Kirsher
2018-05-18 16:59 ` [net-next 1/2] ethtool: stop the line wrapping madness Jeff Kirsher
2018-05-18 16:59 ` Jeff Kirsher [this message]
2018-05-20 3:04 ` [net-next 0/2][pull request] 40GbE Intel Wired LAN Driver Updates 2018-05-18 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518165947.20948-3-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=jogreene@redhat.com \
--cc=mitch.a.williams@intel.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=saeedb@amazon.com \
--cc=sassmann@redhat.com \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.