From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752103AbeESHm4 (ORCPT ); Sat, 19 May 2018 03:42:56 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:39092 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750864AbeESHmz (ORCPT ); Sat, 19 May 2018 03:42:55 -0400 X-Google-Smtp-Source: AB8JxZrA+t+Rj5PG/5znjpXnhk1NaI7kUtLRxSjGobG41TpQzRh24pRbDb4CnEnuArvACRKog0iDdg== Date: Sat, 19 May 2018 09:42:51 +0200 From: Ingo Molnar To: Josh Poimboeuf Cc: Jiri Slaby , Peter Zijlstra , Andy Lutomirski , Borislav Petkov , mingo@redhat.com, linux-kernel@vger.kernel.org, Thomas Gleixner , "H. Peter Anvin" , x86@kernel.org Subject: Re: [PATCH v3 1/6] x86/stacktrace: do not unwind after user regs Message-ID: <20180519074251.GA2952@gmail.com> References: <20180518064713.26440-1-jslaby@suse.cz> <20180518065547.GA18262@gmail.com> <20180518224125.w2ty35wngxbzx6kv@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180518224125.w2ty35wngxbzx6kv@treble> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Josh Poimboeuf wrote: > On Fri, May 18, 2018 at 08:55:47AM +0200, Ingo Molnar wrote: > > > > * Jiri Slaby wrote: > > > > > Josh pointed out, that there is no way a frame can be after user regs. > > > So remove the last unwind and the check. > > > > > > Signed-off-by: Jiri Slaby > > > Cc: Thomas Gleixner > > > Cc: Ingo Molnar > > > Cc: "H. Peter Anvin" > > > Cc: x86@kernel.org > > > Cc: Josh Poimboeuf > > > > Josh: an Acked-by or Reviewed-by for the whole series from you would be nice. > > The patches look good, but I want to run it through some testing before > I give them an ACK. Sure thing and thanks! Ingo