From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751421AbeETGWu (ORCPT ); Sun, 20 May 2018 02:22:50 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:55130 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750918AbeETGWs (ORCPT ); Sun, 20 May 2018 02:22:48 -0400 X-Google-Smtp-Source: AB8JxZrpcoqwV+Lylgg6Y0y4NYy9OBQunwOgwOYw3vB3akRNu4/BPbin7/UJbAhqj/DGH+nbrqJQ8Q== Date: Sun, 20 May 2018 08:22:42 +0200 From: Jiri Pirko To: Marcelo Ricardo Leitner Cc: Vlad Buslov , netdev@vger.kernel.org, davem@davemloft.net, jhs@mojatatu.com, xiyou.wangcong@gmail.com, pablo@netfilter.org, kadlec@blackhole.kfki.hu, fw@strlen.de, ast@kernel.org, daniel@iogearbox.net, edumazet@google.com, keescook@chromium.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, kliteyn@mellanox.com Subject: Re: [PATCH 06/14] net: sched: implement reference counted action release Message-ID: <20180520062242.GB2255@nanopsycho.orion> References: <1526308035-12484-1-git-send-email-vladbu@mellanox.com> <1526308035-12484-7-git-send-email-vladbu@mellanox.com> <20180519214327.GC5488@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180519214327.GC5488@localhost.localdomain> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sat, May 19, 2018 at 11:43:27PM CEST, marcelo.leitner@gmail.com wrote: >On Mon, May 14, 2018 at 05:27:07PM +0300, Vlad Buslov wrote: >... >> @@ -1052,6 +1088,36 @@ static int tca_action_flush(struct net *net, struct nlattr *nla, >> return err; >> } >> >> +static int tcf_action_delete(struct net *net, struct list_head *actions, >> + struct netlink_ext_ack *extack) >> +{ >> + int ret; > >Reverse christmass tree.. this line should be the last in variable >declarations. > >> + struct tc_action *a, *tmp; >> + char kind[IFNAMSIZ]; >> + u32 act_index; >> + >> + list_for_each_entry_safe(a, tmp, actions, list) { >> + const struct tc_action_ops *ops = a->ops; >> + >> + /* Actions can be deleted concurrently >> + * so we must save their type and id to search again >> + * after reference is released. >> + */ >> + strncpy(kind, a->ops->kind, sizeof(kind) - 1); > >This may be problematic. Why strncpy here? This is not necessary if Vlad is going to hold module referece, ops cannot disappear. > >a->ops->kind is also of size IFNAMSIZ. If a->ops->kind is actually >IFNAMSIZ-1 long, kind here won't be NULL terminated, as kind is not >initialized and strncpy won't add the NULL. > >> + act_index = a->tcfa_index; >> + >> + list_del(&a->list); >> + if (tcf_action_put(a)) >> + module_put(ops->owner); >> + >> + /* now do the delete */ >> + ret = tcf_action_del_1(net, kind, act_index, extack); >> + if (ret < 0) >> + return ret; >> + } >> + return 0; >> +}