From: Wei Liu <wei.liu2@citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v1] libxl: always call qemus xen-save-devices-state in suspend/resume
Date: Mon, 21 May 2018 09:18:20 +0100 [thread overview]
Message-ID: <20180521081820.2eue7occ26ouxzb3@citrix.com> (raw)
In-Reply-To: <20180518210910.02c83631.olaf@aepfle.de>
On Fri, May 18, 2018 at 09:09:10PM +0200, Olaf Hering wrote:
> Am Fri, 18 May 2018 18:01:42 +0100
> schrieb Wei Liu <wei.liu2@citrix.com>:
>
> > You don't need to test if the guest is HVM anymore. You only need to
> > know if QEMU upstream is running.
>
> libxl__domain_suspend_device_model handles qemu-xen and qemu-xen-trad.
> That function can not be called unconditionally I think.
> Perhaps I should adjust the commit message.
What I mean is: now you seem to want to call
libxl__domain_suspend_device_model when QEMU upstream is running,
regardless of whether a guest is HVM or PV, so the check for HVM should
be gone.
Does that make sense?
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-05-21 8:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 15:51 [PATCH v1] libxl: always call qemus xen-save-devices-state in suspend/resume Olaf Hering
2018-05-18 7:25 ` Juergen Gross
2018-05-18 8:02 ` Olaf Hering
2018-05-18 16:55 ` Wei Liu
2018-05-18 17:01 ` Wei Liu
2018-05-18 19:09 ` Olaf Hering
2018-05-21 8:18 ` Wei Liu [this message]
2018-05-22 8:52 ` Olaf Hering
2018-05-22 11:14 ` Wei Liu
2018-05-25 13:59 ` Olaf Hering
2018-06-04 17:31 ` Anthony PERARD
2018-06-21 15:34 ` Olaf Hering
2018-06-21 15:59 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180521081820.2eue7occ26ouxzb3@citrix.com \
--to=wei.liu2@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=olaf@aepfle.de \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.