From: Patchwork <patchwork@emeril.freedesktop.org>
To: Mahesh Kumar <mahesh1.kumar@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for drm/i915/skl+: ddb allocation algorithm optimization
Date: Mon, 21 May 2018 12:06:47 -0000 [thread overview]
Message-ID: <20180521120647.9984.87031@emeril.freedesktop.org> (raw)
In-Reply-To: <20180521113605.29818-1-mahesh1.kumar@intel.com>
== Series Details ==
Series: drm/i915/skl+: ddb allocation algorithm optimization
URL : https://patchwork.freedesktop.org/series/43508/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
73a56949d33f drm/i915/skl+: ddb allocation algorithm optimization
-:51: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#51: FILE: drivers/gpu/drm/i915/intel_pm.c:4289:
+ if (level > max_level || level_wm->min_dbuf_req > plane_ddb
+ || (level && level_wm->plane_res_l >= 31)
-:52: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#52: FILE: drivers/gpu/drm/i915/intel_pm.c:4290:
+ || (level && level_wm->plane_res_l >= 31)
+ || level_wm->plane_res_b == 0) {
-:133: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'level < 0'
#133: FILE: drivers/gpu/drm/i915/intel_pm.c:4403:
+ if ((level < 0) || (total_min_blocks > alloc_size)) {
-:133: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'total_min_blocks > alloc_size'
#133: FILE: drivers/gpu/drm/i915/intel_pm.c:4403:
+ if ((level < 0) || (total_min_blocks > alloc_size)) {
-:451: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#451: FILE: drivers/gpu/drm/i915/intel_pm.c:5127:
+ if ((skl_ddb_entry_equal(&cur_ddb->plane[pipe][plane_id],
&new_ddb->plane[pipe][plane_id]) &&
-:469: WARNING:LINE_SPACING: Missing a blank line after declarations
#469: FILE: drivers/gpu/drm/i915/intel_pm.c:5145:
+ struct skl_ddb_allocation *ddb, /* out */
+ bool *changed /* out */)
total: 0 errors, 1 warnings, 5 checks, 507 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-05-21 12:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 11:36 [PATCH] drm/i915/skl+: ddb allocation algorithm optimization Mahesh Kumar
2018-05-21 12:06 ` Patchwork [this message]
2018-05-21 12:07 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
2018-05-21 12:26 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-05-21 15:07 ` ✓ Fi.CI.BAT: success " Patchwork
2018-05-21 17:05 ` ✓ Fi.CI.IGT: " Patchwork
2018-05-22 7:57 ` [PATCH] " Maarten Lankhorst
2018-05-23 13:58 ` Kumar, Mahesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180521120647.9984.87031@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mahesh1.kumar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.