All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: Elijah Newren <newren@gmail.com>, Git Mailing list <git@vger.kernel.org>
Subject: Re: which files are "known to git"?
Date: Mon, 21 May 2018 11:15:11 -0700	[thread overview]
Message-ID: <20180521181511.GD10623@aiede.svl.corp.google.com> (raw)
In-Reply-To: <alpine.LFD.2.21.1805211405410.21888@localhost.localdomain>

Hi,

Robert P. J. Day wrote:

>   i did a quick search for that phrase in the current code base and
> came up with:
>
> builtin/difftool.c:		/* The symlink is unknown to Git so read from the filesystem */
> dir.c:		error("pathspec '%s' did not match any file(s) known to git.",
> Documentation/git-rm.txt:removes only the paths that are known to Git.  Giving the name of
> Documentation/git-commit.txt:   be known to Git);
> Documentation/user-manual.txt:error: pathspec '261dfac35cb99d380eb966e102c1197139f7fa24' did not match any file(s) known to git.
> Documentation/gitattributes.txt:	Notice all types of potential whitespace errors known to Git.
> Documentation/git-clean.txt:Normally, only files unknown to Git are removed, but if the `-x`
> Documentation/RelNotes/1.8.2.1.txt: * The code to keep track of what directory names are known to Git on
> Documentation/RelNotes/1.8.1.6.txt: * The code to keep track of what directory names are known to Git on
> Documentation/RelNotes/2.9.0.txt:   known to Git.  They have been taught to do the normalization.
> Documentation/RelNotes/2.8.4.txt:   known to Git.  They have been taught to do the normalization.
> Documentation/RelNotes/1.8.3.txt: * The code to keep track of what directory names are known to Git on
> t/t3005-ls-files-relative.sh:			echo "error: pathspec $sq$f$sq did not match any file(s) known to git."
> t/t3005-ls-files-relative.sh:			echo "error: pathspec $sq$f$sq did not match any file(s) known to git."
>
> so it's not like there's a *ton* of that, but still enough to want to
> get it right. should there be a precise definition for the phrase
> "known to git", or should that phrase simply be banned/replaced?

In my opinion: the latter.

It's not like the phrase represents some concept that we don't have
any other name for.  They're also known as "tracked files" and that
name is more intuitive.

Thanks,
Jonathan

  reply	other threads:[~2018-05-21 18:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-21 11:18 which files are "known to git"? Robert P. J. Day
2018-05-21 13:58 ` Randall S. Becker
2018-05-21 15:09 ` Elijah Newren
2018-05-21 15:18   ` Duy Nguyen
2018-05-21 15:49   ` Robert P. J. Day
2018-05-21 15:53   ` Robert P. J. Day
2018-05-21 16:08   ` Junio C Hamano
2018-05-21 17:40   ` Robert P. J. Day
2018-05-21 17:53     ` Jonathan Nieder
2018-05-21 18:09       ` Robert P. J. Day
2018-05-21 18:15         ` Jonathan Nieder [this message]
2018-05-22  2:14       ` Junio C Hamano
2018-05-23  8:20       ` Robert P. J. Day
2018-05-21 18:13     ` Elijah Newren
2018-05-21 18:14       ` Robert P. J. Day
2018-05-21 18:15     ` Stefan Beller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180521181511.GD10623@aiede.svl.corp.google.com \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    --cc=rpjday@crashcourse.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.