From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AB8JxZqudvJx4O4XLHp7Nx+G7L40rdFTdhNqCr3yiiiedAkmKnqItuhd254nCpqiNxWtKpd5Freu ARC-Seal: i=1; a=rsa-sha256; t=1526937888; cv=none; d=google.com; s=arc-20160816; b=r0dzITXdjQ3lcg8TKjkQPQYj1Kn5g236b0Sg4aQtW0X6ig0bxpzZuRtSeoYpYdYy51 x0mcMpasoxMbK7y1YRJBWYZkpLrrfUtj3oGWT4Y7vHS5qjxFl2z6a/3cedBXJgTMg/YW LWtjD2QixGxMZhnWpMV7tossvLvBTfsIqaB49F41RjLYfiehag0zkzF4suArEAT44r+F j6Yl6/uhzjuKuPTzdc6HxhH011Pkw1uK2G+zAfaEdozyYiKno2x6AwTsxA+FLcPFaHtq +/CClj1zI8sTRGqSeQXjDjzHAIaycenzRwz6UEbI+8J168EgxHb5Gkmhw+bkaPpMa5Dv ymzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=OIb13Ui5adWE/03jrVuGOtEFsjYc/wuBrtyR/Mfm0yU=; b=mCH5jEhfHhq4bIOYkbhz1kTLcPITXxa0bZTXhSYx94il6haMp9NKHFi3Hap87HpqVP QuBebTDgp/pvy5sJdQ9RzEw4Sx6dEu4UeslwOBOCoqEHeM6pgWXZlB+St1tjQFqcoA5t yG2N3eCA+xSPOQAUXIVJ7QUJ5Hs+UOpVuuG2bjKtek4RDO+CUTW/Fcl6Gb90VzYOO2fP RSi7DaccmhUwox2zF+arYn8H7pl2Ep3LFJzghgQSon9nhsuuR8mGpNhjqZXFxHJysFIt 7bJxQFZVpN6CDWC9Gv2+lmRGfDUlcUJOF5fOAaLZIVIj3SSXd68C9jfW6MS4djzOG1U3 M81w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=aHUHZN4k; spf=pass (google.com: domain of srs0=nia/=ii=linuxfoundation.org=gregkh@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=SRS0=nia/=II=linuxfoundation.org=gregkh@kernel.org Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=aHUHZN4k; spf=pass (google.com: domain of srs0=nia/=ii=linuxfoundation.org=gregkh@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=SRS0=nia/=II=linuxfoundation.org=gregkh@kernel.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Liu Bo , Filipe Manana , Qu Wenruo , David Sterba , Nikolay Borisov Subject: [PATCH 4.16 061/110] btrfs: fix reading stale metadata blocks after degraded raid1 mounts Date: Mon, 21 May 2018 23:11:58 +0200 Message-Id: <20180521210511.440167357@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180521210503.823249477@linuxfoundation.org> References: <20180521210503.823249477@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1601109818430995354?= X-GMAIL-MSGID: =?utf-8?q?1601110424091478313?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Liu Bo commit 02a3307aa9c20b4f6626255b028f07f6cfa16feb upstream. If a btree block, aka. extent buffer, is not available in the extent buffer cache, it'll be read out from the disk instead, i.e. btrfs_search_slot() read_block_for_search() # hold parent and its lock, go to read child btrfs_release_path() read_tree_block() # read child Unfortunately, the parent lock got released before reading child, so commit 5bdd3536cbbe ("Btrfs: Fix block generation verification race") had used 0 as parent transid to read the child block. It forces read_tree_block() not to check if parent transid is different with the generation id of the child that it reads out from disk. A simple PoC is included in btrfs/124, 0. A two-disk raid1 btrfs, 1. Right after mkfs.btrfs, block A is allocated to be device tree's root. 2. Mount this filesystem and put it in use, after a while, device tree's root got COW but block A hasn't been allocated/overwritten yet. 3. Umount it and reload the btrfs module to remove both disks from the global @fs_devices list. 4. mount -odegraded dev1 and write some data, so now block A is allocated to be a leaf in checksum tree. Note that only dev1 has the latest metadata of this filesystem. 5. Umount it and mount it again normally (with both disks), since raid1 can pick up one disk by the writer task's pid, if btrfs_search_slot() needs to read block A, dev2 which does NOT have the latest metadata might be read for block A, then we got a stale block A. 6. As parent transid is not checked, block A is marked as uptodate and put into the extent buffer cache, so the future search won't bother to read disk again, which means it'll make changes on this stale one and make it dirty and flush it onto disk. To avoid the problem, parent transid needs to be passed to read_tree_block(). In order to get a valid parent transid, we need to hold the parent's lock until finishing reading child. This patch needs to be slightly adapted for stable kernels, the &first_key parameter added to read_tree_block() is from 4.16+ (581c1760415c4). The fix is to replace 0 by 'gen'. Fixes: 5bdd3536cbbe ("Btrfs: Fix block generation verification race") CC: stable@vger.kernel.org # 4.4+ Signed-off-by: Liu Bo Reviewed-by: Filipe Manana Reviewed-by: Qu Wenruo [ update changelog ] Signed-off-by: David Sterba Signed-off-by: Nikolay Borisov Signed-off-by: Greg Kroah-Hartman --- fs/btrfs/ctree.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/fs/btrfs/ctree.c +++ b/fs/btrfs/ctree.c @@ -2491,10 +2491,8 @@ read_block_for_search(struct btrfs_root if (p->reada != READA_NONE) reada_for_search(fs_info, p, level, slot, key->objectid); - btrfs_release_path(p); - ret = -EAGAIN; - tmp = read_tree_block(fs_info, blocknr, 0); + tmp = read_tree_block(fs_info, blocknr, gen); if (!IS_ERR(tmp)) { /* * If the read above didn't mark this buffer up to date, @@ -2508,6 +2506,8 @@ read_block_for_search(struct btrfs_root } else { ret = PTR_ERR(tmp); } + + btrfs_release_path(p); return ret; }