From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753124AbeEVTko (ORCPT ); Tue, 22 May 2018 15:40:44 -0400 Received: from mail-pl0-f65.google.com ([209.85.160.65]:44267 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753109AbeEVTkl (ORCPT ); Tue, 22 May 2018 15:40:41 -0400 X-Google-Smtp-Source: AB8JxZqGw6ZVkocy+M3Ztv7FgV3Kjl2FR579iAIYWVbFkpUeSyViMZMxM7dkQaQZt/ocvrjTEPWt8Q== Date: Tue, 22 May 2018 14:40:39 -0500 From: Rob Herring To: Michal =?utf-8?B?Vm9rw6HEjQ==?= Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, f.fainelli@gmail.com, vivien.didelot@savoirfairelinux.com, andrew@lunn.ch, mark.rutland@arm.com, davem@davemloft.net, michal.vokac@ysoft.com Subject: Re: [PATCH net-next v2 1/7] net: dsa: qca8k: Add QCA8334 binding documentation Message-ID: <20180522194039.GA15413@rob-hp-laptop> References: <1526987792-56861-1-git-send-email-michal.vokac@ysoft.com> <1526987792-56861-2-git-send-email-michal.vokac@ysoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1526987792-56861-2-git-send-email-michal.vokac@ysoft.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 22, 2018 at 01:16:26PM +0200, Michal Vokáč wrote: > Add support for the four-port variant of the Qualcomm QCA833x switch. > > The CPU port default link settings can be reconfigured using > a fixed-link sub-node. > > Signed-off-by: Michal Vokáč > --- > Changes in v2: > - Add commit message and document fixed-link binding. > > .../devicetree/bindings/net/dsa/qca8k.txt | 23 +++++++++++++++++++++- > 1 file changed, 22 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > index 9c67ee4..15b9057 100644 > --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt > +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > @@ -2,7 +2,10 @@ > > Required properties: > > -- compatible: should be "qca,qca8337" > +- compatible: should be one of: > + "qca,qca8334" > + "qca,qca8337" > + > - #size-cells: must be 0 > - #address-cells: must be 1 > > @@ -14,6 +17,20 @@ port and PHY id, each subnode describing a port needs to have a valid phandle > referencing the internal PHY connected to it. The CPU port of this switch is > always port 0. > > +A CPU port node has the following optional property: s/property/node/ Otherwise, Reviewed-by: Rob Herring