All of lore.kernel.org
 help / color / mirror / Atom feed

diff for duplicates of <20180523.115636.2241611659399097483.davem@davemloft.net>

diff --git a/a/1.txt b/N1/1.txt
index c12ec15..2e77fcb 100644
--- a/a/1.txt
+++ b/N1/1.txt
@@ -2,13 +2,13 @@ From: Guillaume Nault <g.nault@alphalink.fr>
 Date: Wed, 23 May 2018 15:57:08 +0200
 
 > I'd rather add
-> +	if (cmd == PPPIOCDETACH) {
+> +	if (cmd = PPPIOCDETACH) {
 > +		err = -EINVAL;
 > +		goto out;
 > +	}
 > 
 > Making PPPIOCDETACH unknown to ppp_generic means that the ioctl would
-> be handled by the underlying channel when pf->kind == CHANNEL (see the
+> be handled by the underlying channel when pf->kind = CHANNEL (see the
 > chan->ops->ioctl() call further down). That shouldn't be a problem per
 > se, but even though PPPIOCDETACH is unsupported, I feel that it should
 > remain a ppp_generic thing. I don't really want its value to be reused
diff --git a/a/content_digest b/N1/content_digest
index 19fc231..f9b5751 100644
--- a/a/content_digest
+++ b/N1/content_digest
@@ -14,7 +14,7 @@
   "Subject\0Re: [PATCH] ppp: remove the PPPIOCDETACH ioctl\0"
 ]
 [
-  "Date\0Wed, 23 May 2018 11:56:36 -0400 (EDT)\0"
+  "Date\0Wed, 23 May 2018 15:56:36 +0000\0"
 ]
 [
   "To\0g.nault\@alphalink.fr\0"
@@ -40,13 +40,13 @@
   "Date: Wed, 23 May 2018 15:57:08 +0200\n",
   "\n",
   "> I'd rather add\n",
-  "> +\tif (cmd == PPPIOCDETACH) {\n",
+  "> +\tif (cmd = PPPIOCDETACH) {\n",
   "> +\t\terr = -EINVAL;\n",
   "> +\t\tgoto out;\n",
   "> +\t}\n",
   "> \n",
   "> Making PPPIOCDETACH unknown to ppp_generic means that the ioctl would\n",
-  "> be handled by the underlying channel when pf->kind == CHANNEL (see the\n",
+  "> be handled by the underlying channel when pf->kind = CHANNEL (see the\n",
   "> chan->ops->ioctl() call further down). That shouldn't be a problem per\n",
   "> se, but even though PPPIOCDETACH is unsupported, I feel that it should\n",
   "> remain a ppp_generic thing. I don't really want its value to be reused\n",
@@ -61,4 +61,4 @@
   "I agree."
 ]
 
-38b65b926eba8bb823559b3d225868ce214f362490f99e0143a231ba92990367
+81591caa453831f666b398dbe506fcd478081bdc0ef7e530128cd55b9b54af96
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.