* [PATCH] atmel: Add missing call to pci_disable_device()
@ 2018-05-23 10:34 ` YueHaibing
0 siblings, 0 replies; 3+ messages in thread
From: YueHaibing @ 2018-05-23 10:34 UTC (permalink / raw)
To: simon, kvalo, davem; +Cc: netdev, linux-wireless, YueHaibing
add pci_disable_device in error handling while init_atmel_card failed.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/wireless/atmel/atmel_pci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/atmel/atmel_pci.c b/drivers/net/wireless/atmel/atmel_pci.c
index bcf1f27..30df58a 100644
--- a/drivers/net/wireless/atmel/atmel_pci.c
+++ b/drivers/net/wireless/atmel/atmel_pci.c
@@ -61,8 +61,10 @@ static int atmel_pci_probe(struct pci_dev *pdev,
dev = init_atmel_card(pdev->irq, pdev->resource[1].start,
ATMEL_FW_TYPE_506,
&pdev->dev, NULL, NULL);
- if (!dev)
+ if (!dev) {
+ pci_disable_device(pdev);
return -ENODEV;
+ }
pci_set_drvdata(pdev, dev);
return 0;
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] atmel: Add missing call to pci_disable_device()
@ 2018-05-23 10:34 ` YueHaibing
0 siblings, 0 replies; 3+ messages in thread
From: YueHaibing @ 2018-05-23 10:34 UTC (permalink / raw)
To: simon-xn1N/tgparsycpQjotevgVpr/1R2p/CL,
kvalo-sgV2jX0FEOL9JmXXK+q4OQ, davem-fT/PcQaiUtIeIZ0/mPfg9Q
Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
linux-wireless-u79uwXL29TY76Z2rM5mHXA, YueHaibing
add pci_disable_device in error handling while init_atmel_card failed.
Signed-off-by: YueHaibing <yuehaibing-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
---
drivers/net/wireless/atmel/atmel_pci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/atmel/atmel_pci.c b/drivers/net/wireless/atmel/atmel_pci.c
index bcf1f27..30df58a 100644
--- a/drivers/net/wireless/atmel/atmel_pci.c
+++ b/drivers/net/wireless/atmel/atmel_pci.c
@@ -61,8 +61,10 @@ static int atmel_pci_probe(struct pci_dev *pdev,
dev = init_atmel_card(pdev->irq, pdev->resource[1].start,
ATMEL_FW_TYPE_506,
&pdev->dev, NULL, NULL);
- if (!dev)
+ if (!dev) {
+ pci_disable_device(pdev);
return -ENODEV;
+ }
pci_set_drvdata(pdev, dev);
return 0;
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: atmel: Add missing call to pci_disable_device()
2018-05-23 10:34 ` YueHaibing
(?)
@ 2018-05-29 7:20 ` Kalle Valo
-1 siblings, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2018-05-29 7:20 UTC (permalink / raw)
To: YueHaibing; +Cc: simon, davem, netdev, linux-wireless, YueHaibing
YueHaibing <yuehaibing@huawei.com> wrote:
> add pci_disable_device in error handling while init_atmel_card failed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Patch applied to wireless-drivers-next.git, thanks.
88027c8ff0a3 atmel: Add missing call to pci_disable_device()
--
https://patchwork.kernel.org/patch/10420905/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-29 7:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-23 10:34 [PATCH] atmel: Add missing call to pci_disable_device() YueHaibing
2018-05-23 10:34 ` YueHaibing
2018-05-29 7:20 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.