From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH net-next 0/8] nfp: offload LAG for tc flower egress Date: Thu, 24 May 2018 11:53:18 -0700 Message-ID: <20180524115318.605915b2@cakuba> References: <20180524022255.18548-1-jakub.kicinski@netronome.com> <185db5ee-4a86-6479-46e6-4c48f9516a90@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: Or Gerlitz , David Miller , Linux Netdev List , oss-drivers@netronome.com, Jiri Pirko , Jay Vosburgh , Veaceslav Falico , Andy Gospodarek To: "Samudrala, Sridhar" Return-path: Received: from mail-qt0-f193.google.com ([209.85.216.193]:36815 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032744AbeEXSxY (ORCPT ); Thu, 24 May 2018 14:53:24 -0400 Received: by mail-qt0-f193.google.com with SMTP id q6-v6so3429076qtn.3 for ; Thu, 24 May 2018 11:53:23 -0700 (PDT) In-Reply-To: <185db5ee-4a86-6479-46e6-4c48f9516a90@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 24 May 2018 11:23:00 -0700, Samudrala, Sridhar wrote: > On 5/24/2018 10:04 AM, Or Gerlitz wrote: > > On Thu, May 24, 2018 at 5:22 AM, Jakub Kicinski > > wrote: =20 > >> Hi! > >> > >> This series from John adds bond offload to the nfp driver. Patch 5 > >> exposes the hash type for NETDEV_LAG_TX_TYPE_HASH to make sure nfp > >> hashing matches that of the software LAG. This may be unnecessarily > >> conservative, let's see what LAG maintainers think :) > >> > >> John says: > >> > >> This patchset sets up the infrastructure and offloads output actions f= or > >> when a TC flower rule attempts to egress a packet to a LAG port. > >> > >> Firstly it adds some of the infrastructure required to the flower app = and > >> to the nfp core. This includes the ability to change the MAC address o= f a > >> repr, a function for combining lookup and write to a FW symbol, and the > >> addition of private data to a repr on a per app basis. > >> > >> Patch 6 continues by implementing notifiers that track Linux bonds and > >> communicates to the FW those which enslave reprs, along with the curre= nt > >> state of reprs within the bond. > >> > >> Patch 7 ensures bonds are synchronised with FW by receiving and acting > >> upon cmsgs sent to the kernel. These may request that a bond message is > >> retransmitted when FW can process it, or may request a full sync of the > >> bonds defined in the kernel. > >> > >> Patch 8 offloads a flower action when that action requires egressing t= o a > >> pre-defined Linux bond. =20 > > Does this apply also to non-uplink representors? if yes, what is the us= e case? > > > > We are looking on supporting uplink lag in sriov switchdev scheme - we = refer to > > it as "vf lag" -- b/c the netdev and rdma devices seen by the VF are ac= tually > > subject to HA and/or LAG - I wasn't sure if/how you limit this series > > to uplink reprs =20 >=20 > Also, does this patchset support offloading LAG when using vxlan based tu= nnels? >=20 > When using OVS offloading with vxlan,=C2=A0 the encap rule that gets offl= oaded via tc-flower > has egress port as vxlan device and the decap rule has the in-port as vxl= an device, not > the actual egress port. How are you addressing this issue? It is very much on our radar, I think we will send out a related RFC later today :) But to be honest I think you can just install an egress callback on the bond and that will pretty much work today. You don't have to "own" the egress device to install a egdev callback on it.