From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033475AbeEXQHg (ORCPT ); Thu, 24 May 2018 12:07:36 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:53084 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030546AbeEXQHe (ORCPT ); Thu, 24 May 2018 12:07:34 -0400 Date: Thu, 24 May 2018 09:07:29 -0700 From: Guenter Roeck To: Robin Murphy Cc: Mark Rutland , devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org, Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, Rob Herring , Ray Jui , bcm-kernel-feedback-list@broadcom.com, Wim Van Sebroeck , Frank Rowand , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/5] Documentation: DT: Add optional 'timeout-sec' property for sp805 Message-ID: <20180524160729.GA27710@roeck-us.net> References: <1527014840-21236-1-git-send-email-ray.jui@broadcom.com> <1527014840-21236-2-git-send-email-ray.jui@broadcom.com> <20180523181058.GC27570@roeck-us.net> <91d27df4-29d0-de7f-6805-c3e5f329caf3@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <91d27df4-29d0-de7f-6805-c3e5f329caf3@arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 24, 2018 at 02:25:34PM +0100, Robin Murphy wrote: > On 23/05/18 19:10, Guenter Roeck wrote: > >On Wed, May 23, 2018 at 11:57:25AM +0100, Robin Murphy wrote: > >>On 22/05/18 19:47, Ray Jui wrote: > >>>Update the SP805 binding document to add optional 'timeout-sec' > >>>devicetree property > >>> > >>>Signed-off-by: Ray Jui > >>>Reviewed-by: Scott Branden > >>>--- > >>> Documentation/devicetree/bindings/watchdog/sp805-wdt.txt | 2 ++ > >>> 1 file changed, 2 insertions(+) > >>> > >>>diff --git a/Documentation/devicetree/bindings/watchdog/sp805-wdt.txt b/Documentation/devicetree/bindings/watchdog/sp805-wdt.txt > >>>index edc4f0e..f898a86 100644 > >>>--- a/Documentation/devicetree/bindings/watchdog/sp805-wdt.txt > >>>+++ b/Documentation/devicetree/bindings/watchdog/sp805-wdt.txt > >>>@@ -19,6 +19,8 @@ Required properties: > >>> Optional properties: > >>> - interrupts : Should specify WDT interrupt number. > >>>+- timeout-sec : Should specify default WDT timeout in seconds. If unset, the > >>>+ default timeout is 30 seconds > >> > >>According to the SP805 TRM, the default interval is dependent on the rate of > >>WDOGCLK, but would typically be a lot longer than that :/ > >> > >Depends on the definition of "default". In the context of watchdog drivers, > >it is (or should be) a driver default, not a chip default. > > DT describes hardware, not driver behaviour. > In this case it describes expected system behavior. Most definitely it does not describe some hardware default. Please note that I do not engage in discussions I consider bike-shedding. This is one of those. Dropping out. Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@roeck-us.net (Guenter Roeck) Date: Thu, 24 May 2018 09:07:29 -0700 Subject: [PATCH 1/5] Documentation: DT: Add optional 'timeout-sec' property for sp805 In-Reply-To: <91d27df4-29d0-de7f-6805-c3e5f329caf3@arm.com> References: <1527014840-21236-1-git-send-email-ray.jui@broadcom.com> <1527014840-21236-2-git-send-email-ray.jui@broadcom.com> <20180523181058.GC27570@roeck-us.net> <91d27df4-29d0-de7f-6805-c3e5f329caf3@arm.com> Message-ID: <20180524160729.GA27710@roeck-us.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, May 24, 2018 at 02:25:34PM +0100, Robin Murphy wrote: > On 23/05/18 19:10, Guenter Roeck wrote: > >On Wed, May 23, 2018 at 11:57:25AM +0100, Robin Murphy wrote: > >>On 22/05/18 19:47, Ray Jui wrote: > >>>Update the SP805 binding document to add optional 'timeout-sec' > >>>devicetree property > >>> > >>>Signed-off-by: Ray Jui > >>>Reviewed-by: Scott Branden > >>>--- > >>> Documentation/devicetree/bindings/watchdog/sp805-wdt.txt | 2 ++ > >>> 1 file changed, 2 insertions(+) > >>> > >>>diff --git a/Documentation/devicetree/bindings/watchdog/sp805-wdt.txt b/Documentation/devicetree/bindings/watchdog/sp805-wdt.txt > >>>index edc4f0e..f898a86 100644 > >>>--- a/Documentation/devicetree/bindings/watchdog/sp805-wdt.txt > >>>+++ b/Documentation/devicetree/bindings/watchdog/sp805-wdt.txt > >>>@@ -19,6 +19,8 @@ Required properties: > >>> Optional properties: > >>> - interrupts : Should specify WDT interrupt number. > >>>+- timeout-sec : Should specify default WDT timeout in seconds. If unset, the > >>>+ default timeout is 30 seconds > >> > >>According to the SP805 TRM, the default interval is dependent on the rate of > >>WDOGCLK, but would typically be a lot longer than that :/ > >> > >Depends on the definition of "default". In the context of watchdog drivers, > >it is (or should be) a driver default, not a chip default. > > DT describes hardware, not driver behaviour. > In this case it describes expected system behavior. Most definitely it does not describe some hardware default. Please note that I do not engage in discussions I consider bike-shedding. This is one of those. Dropping out. Guenter