From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034122AbeEXRJP (ORCPT ); Thu, 24 May 2018 13:09:15 -0400 Received: from mail-pl0-f67.google.com ([209.85.160.67]:39936 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031515AbeEXRJL (ORCPT ); Thu, 24 May 2018 13:09:11 -0400 X-Google-Smtp-Source: AB8JxZpSKzFLcg2xCW6rfcDQPZ1dA9JT+1TsYw9YBErMHf2nJZR7TONXJJ/Lqb6nMrBLsukZXtumiw== Date: Thu, 24 May 2018 10:09:08 -0700 From: Moritz Fischer To: Alan Tull Cc: Greg Kroah-Hartman , Jonathan Corbet , Moritz Fischer , linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org Subject: Re: [PATCH 08/14] fpga: region: kernel-doc fixes Message-ID: <20180524170908.GE4051@archbook> References: <20180516235007.3951-1-atull@kernel.org> <20180516235007.3951-9-atull@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180516235007.3951-9-atull@kernel.org> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 16, 2018 at 06:50:01PM -0500, Alan Tull wrote: > Fix formatting and some cleanup for the kernel-doc documentation in > fpga-region.c > > Signed-off-by: Alan Tull Acked-by: Moritz Fischer > --- > drivers/fpga/fpga-region.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c > index 0878f62..112fa3a 100644 > --- a/drivers/fpga/fpga-region.c > +++ b/drivers/fpga/fpga-region.c > @@ -81,13 +81,16 @@ static void fpga_region_put(struct fpga_region *region) > > /** > * fpga_region_program_fpga - program FPGA > + * > * @region: FPGA region > + * > * Program an FPGA using fpga image info (region->info). > * If the region has a get_bridges function, the exclusive reference for the > * bridges will be held if programming succeeds. This is intended to prevent > * reprogramming the region until the caller considers it safe to do so. > * The caller will need to call fpga_bridges_put() before attempting to > * reprogram the region. > + * > * Return 0 for success or negative error code. > */ > int fpga_region_program_fpga(struct fpga_region *region) > @@ -216,7 +219,7 @@ void fpga_region_free(struct fpga_region *region) > } > EXPORT_SYMBOL_GPL(fpga_region_free); > > -/* > +/** > * fpga_region_register - register a FPGA region > * @region: FPGA region created by fpga_region_create > * Return: 0 or -errno > @@ -228,7 +231,7 @@ int fpga_region_register(struct fpga_region *region) > } > EXPORT_SYMBOL_GPL(fpga_region_register); > > -/* > +/** > * fpga_region_unregister - unregister a FPGA region > * @region: FPGA region > */ > -- > 2.7.4 > Thanks, Moritz