From: Matthew Wilcox <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk
Subject: Re: [PATCH 1/3] mpage: mpage_readpages() should submit IO as read-ahead
Date: Thu, 24 May 2018 12:57:41 -0700 [thread overview]
Message-ID: <20180524195741.GA12237@bombadil.infradead.org> (raw)
In-Reply-To: <20180524124306.1d8833f06366fcad29506182@linux-foundation.org>
On Thu, May 24, 2018 at 12:43:06PM -0700, Andrew Morton wrote:
> On Thu, 24 May 2018 10:02:52 -0600 Jens Axboe <axboe@kernel.dk> wrote:
> > do_mpage_readpage(struct bio *bio, struct page *page, unsigned nr_pages,
> > sector_t *last_block_in_bio, struct buffer_head *map_bh,
> > unsigned long *first_logical_block, get_block_t get_block,
> > - gfp_t gfp)
> > + gfp_t gfp, bool is_readahead)
>
> That's a lot of arguments.
struct mpage_args args = {
.bio = NULL,
.first_logical_block = 0,
.last_block_in_bio = 0,
.is_readahead = true,
.map_bh = {
.b_state = 0;
.b_size = 0;
},
.get_block = get_block,
.gfp = readahead_gfp_mask(mapping);
};
...
do_mpage_readpages(&args, page, nr_pages - page_idx);
better than inlining?
next prev parent reply other threads:[~2018-05-24 19:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 16:02 [PATCHSET 0/3] Submit ->readpages() IO as read-ahead Jens Axboe
2018-05-24 16:02 ` [PATCH 1/3] mpage: mpage_readpages() should submit " Jens Axboe
2018-05-24 19:43 ` Andrew Morton
2018-05-24 19:57 ` Matthew Wilcox [this message]
2018-05-24 20:24 ` Jens Axboe
2018-05-29 14:36 ` Jens Axboe
2018-05-29 21:59 ` Andrew Morton
2018-05-29 22:18 ` Jens Axboe
2018-05-29 22:37 ` Jens Axboe
2018-05-24 16:02 ` [PATCH 2/3] btrfs: readpages() " Jens Axboe
2018-05-24 16:02 ` [PATCH 3/3] ext4: " Jens Axboe
2018-05-24 20:47 ` Theodore Y. Ts'o
2018-05-24 20:53 ` Jens Axboe
2018-05-24 21:05 ` Jens Axboe
2018-05-25 8:32 ` [PATCHSET 0/3] Submit ->readpages() " Christoph Hellwig
2018-05-25 14:21 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180524195741.GA12237@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.