From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42573) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fM5Pq-00088a-W3 for qemu-devel@nongnu.org; Fri, 25 May 2018 01:37:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fM5Pn-00053G-SD for qemu-devel@nongnu.org; Fri, 25 May 2018 01:37:27 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:32956 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fM5Pn-000536-M8 for qemu-devel@nongnu.org; Fri, 25 May 2018 01:37:23 -0400 Date: Fri, 25 May 2018 13:37:18 +0800 From: Fam Zheng Message-ID: <20180525053718.GB28589@lemon.usersys.redhat.com> References: <20180525005839.11556-1-crosa@redhat.com> <20180525005839.11556-4-crosa@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180525005839.11556-4-crosa@redhat.com> Subject: Re: [Qemu-devel] [PATCH 3/5] Acceptance tests: add quick VNC tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cleber Rosa Cc: qemu-devel@nongnu.org, Eduardo Habkost , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Stefan Hajnoczi , Amador Pahim On Thu, 05/24 20:58, Cleber Rosa wrote: > This patch adds a few simple behavior tests for VNC. These tests > introduce manipulation of the QEMUMachine arguments, by setting > the arguments, instead of adding to the existing ones. I'm confused by this. The code uses 'add_args', so it does add to the arguments, no? > > Signed-off-by: Cleber Rosa > --- > tests/acceptance/test_vnc.py | 50 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 tests/acceptance/test_vnc.py > > diff --git a/tests/acceptance/test_vnc.py b/tests/acceptance/test_vnc.py > new file mode 100644 > index 0000000000..9d9a35cf55 > --- /dev/null > +++ b/tests/acceptance/test_vnc.py > @@ -0,0 +1,50 @@ Copyright header is missing here too. Fam > +from avocado_qemu import Test > + > + > +class Vnc(Test): Should VncTest be a better class name? > + """ > + :avocado: enable > + :avocado: tags=vnc,quick > + """ > + def test_no_vnc(self): > + self.vm.add_args('-nodefaults', '-S') > + self.vm.launch() > + self.assertFalse(self.vm.qmp('query-vnc')['return']['enabled']) > + > + def test_no_vnc_change_password(self): > + self.vm.add_args('-nodefaults', '-S') > + self.vm.launch() > + self.assertFalse(self.vm.qmp('query-vnc')['return']['enabled']) > + set_password_response = self.vm.qmp('change', > + device='vnc', > + target='password', > + arg='new_password') > + self.assertIn('error', set_password_response) > + self.assertEqual(set_password_response['error']['class'], > + 'GenericError') > + self.assertEqual(set_password_response['error']['desc'], > + 'Could not set password') > + > + def test_vnc_change_password_requires_a_password(self): > + self.vm.add_args('-nodefaults', '-S', '-vnc', ':0') > + self.vm.launch() > + self.assertTrue(self.vm.qmp('query-vnc')['return']['enabled']) > + set_password_response = self.vm.qmp('change', > + device='vnc', > + target='password', > + arg='new_password') > + self.assertIn('error', set_password_response) > + self.assertEqual(set_password_response['error']['class'], > + 'GenericError') > + self.assertEqual(set_password_response['error']['desc'], > + 'Could not set password') > + > + def test_vnc_change_password(self): > + self.vm.add_args('-nodefaults', '-S', '-vnc', ':0,password') > + self.vm.launch() > + self.assertTrue(self.vm.qmp('query-vnc')['return']['enabled']) > + set_password_response = self.vm.qmp('change', > + device='vnc', > + target='password', > + arg='new_password') > + self.assertEqual(set_password_response['return'], {}) > -- > 2.17.0 > Fam