* [U-Boot] [PATCH v3 0/3] drivers: Add reset ctrl to drivers
@ 2018-05-08 3:19 Ley Foon Tan
2018-05-08 3:19 ` [U-Boot] [PATCH v3 1/3] mmc: dwmmc: socfpga: Add reset ctrl to driver Ley Foon Tan
` (2 more replies)
0 siblings, 3 replies; 18+ messages in thread
From: Ley Foon Tan @ 2018-05-08 3:19 UTC (permalink / raw)
To: u-boot
Add reset ctrl to dwmmc socfpga, designware Ethernet and ns16550 serial drivers.
A reset property is an optional feature, so only print out a warning and
do not fail if a reset property is not present.
If a reset property is discovered, then use it to deassert, thus bringing the
IP out of reset.
This is preparation to upstream Intel Stratix 10 SoC support in [1].
v2 change:
- remove #ifdef CONFIG_DM_RESET switch
- add maintainer emails
History:
v1: https://patchwork.ozlabs.org/cover/905519/
v2: https://patchwork.ozlabs.org/cover/908667/
[1]: https://patchwork.ozlabs.org/cover/900499/
Ley Foon Tan (3):
mmc: dwmmc: socfpga: Add reset ctrl to driver
serial: ns16550: Add reset ctrl to driver
net: designware: Add reset ctrl to driver
drivers/mmc/socfpga_dw_mmc.c | 17 +++++++++++++++++
drivers/net/designware.c | 8 ++++++++
drivers/serial/ns16550.c | 8 ++++++++
3 files changed, 33 insertions(+), 0 deletions(-)
^ permalink raw reply [flat|nested] 18+ messages in thread
* [U-Boot] [PATCH v3 1/3] mmc: dwmmc: socfpga: Add reset ctrl to driver
2018-05-08 3:19 [U-Boot] [PATCH v3 0/3] drivers: Add reset ctrl to drivers Ley Foon Tan
@ 2018-05-08 3:19 ` Ley Foon Tan
2018-05-13 22:01 ` Simon Glass
2018-05-24 12:39 ` [U-Boot] [U-Boot, v3, " Tom Rini
2018-05-08 3:19 ` [U-Boot] [PATCH v3 2/3] serial: ns16550: " Ley Foon Tan
2018-05-08 3:19 ` [U-Boot] [PATCH v3 3/3] net: designware: " Ley Foon Tan
2 siblings, 2 replies; 18+ messages in thread
From: Ley Foon Tan @ 2018-05-08 3:19 UTC (permalink / raw)
To: u-boot
Add code to reset all reset signals as in mmc DT node. A reset property is an optional feature,
so only print out a warning and do not fail if a reset property is not present.
If a reset property is discovered, then use it to deassert, thus bringing the
IP out of reset.
Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
---
drivers/mmc/socfpga_dw_mmc.c | 17 +++++++++++++++++
1 files changed, 17 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/socfpga_dw_mmc.c b/drivers/mmc/socfpga_dw_mmc.c
index fa0e449..eb7e64e 100644
--- a/drivers/mmc/socfpga_dw_mmc.c
+++ b/drivers/mmc/socfpga_dw_mmc.c
@@ -13,6 +13,7 @@
#include <linux/libfdt.h>
#include <linux/err.h>
#include <malloc.h>
+#include <reset.h>
DECLARE_GLOBAL_DATA_PTR;
@@ -33,6 +34,20 @@ struct dwmci_socfpga_priv_data {
unsigned int smplsel;
};
+static void socfpga_dwmci_reset(struct udevice *dev)
+{
+ struct reset_ctl_bulk reset_bulk;
+ int ret;
+
+ ret = reset_get_bulk(dev, &reset_bulk);
+ if (ret) {
+ dev_warn(dev, "Can't get reset: %d\n", ret);
+ return;
+ }
+
+ reset_deassert_bulk(&reset_bulk);
+}
+
static void socfpga_dwmci_clksel(struct dwmci_host *host)
{
struct dwmci_socfpga_priv_data *priv = host->priv;
@@ -109,6 +124,8 @@ static int socfpga_dwmmc_probe(struct udevice *dev)
struct dwmci_socfpga_priv_data *priv = dev_get_priv(dev);
struct dwmci_host *host = &priv->host;
+ socfpga_dwmci_reset(dev);
+
#ifdef CONFIG_BLK
dwmci_setup_cfg(&plat->cfg, host, host->bus_hz, 400000);
host->mmc = &plat->mmc;
--
1.7.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [U-Boot] [PATCH v3 2/3] serial: ns16550: Add reset ctrl to driver
2018-05-08 3:19 [U-Boot] [PATCH v3 0/3] drivers: Add reset ctrl to drivers Ley Foon Tan
2018-05-08 3:19 ` [U-Boot] [PATCH v3 1/3] mmc: dwmmc: socfpga: Add reset ctrl to driver Ley Foon Tan
@ 2018-05-08 3:19 ` Ley Foon Tan
2018-05-24 2:25 ` Ley Foon Tan
2018-05-08 3:19 ` [U-Boot] [PATCH v3 3/3] net: designware: " Ley Foon Tan
2 siblings, 1 reply; 18+ messages in thread
From: Ley Foon Tan @ 2018-05-08 3:19 UTC (permalink / raw)
To: u-boot
Add code to reset all reset signals as in serial DT node. A reset property is an optional feature,
so do not fail if a reset property is not present.
If a reset property is discovered, then use it to deassert, thus bringing the
IP out of reset.
Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
Reviewed-by: Marek Vasut <marex@denx.de>
---
drivers/serial/ns16550.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
index 53550bf..9c80090 100644
--- a/drivers/serial/ns16550.c
+++ b/drivers/serial/ns16550.c
@@ -9,6 +9,7 @@
#include <dm.h>
#include <errno.h>
#include <ns16550.h>
+#include <reset.h>
#include <serial.h>
#include <watchdog.h>
#include <linux/types.h>
@@ -177,6 +178,7 @@ void NS16550_init(NS16550_t com_port, int baud_divisor)
#if defined(CONFIG_ARCH_OMAP2PLUS)
serial_out(0x7, &com_port->mdr1); /* mode select reset TL16C750*/
#endif
+
serial_out(UART_MCRVAL, &com_port->mcr);
serial_out(ns16550_getfcr(com_port), &com_port->fcr);
if (baud_divisor != -1)
@@ -370,6 +372,12 @@ static int ns16550_serial_setbrg(struct udevice *dev, int baudrate)
int ns16550_serial_probe(struct udevice *dev)
{
struct NS16550 *const com_port = dev_get_priv(dev);
+ struct reset_ctl_bulk reset_bulk;
+ int ret;
+
+ ret = reset_get_bulk(dev, &reset_bulk);
+ if (!ret)
+ reset_deassert_bulk(&reset_bulk);
com_port->plat = dev_get_platdata(dev);
NS16550_init(com_port, -1);
--
1.7.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [U-Boot] [PATCH v3 3/3] net: designware: Add reset ctrl to driver
2018-05-08 3:19 [U-Boot] [PATCH v3 0/3] drivers: Add reset ctrl to drivers Ley Foon Tan
2018-05-08 3:19 ` [U-Boot] [PATCH v3 1/3] mmc: dwmmc: socfpga: Add reset ctrl to driver Ley Foon Tan
2018-05-08 3:19 ` [U-Boot] [PATCH v3 2/3] serial: ns16550: " Ley Foon Tan
@ 2018-05-08 3:19 ` Ley Foon Tan
2018-05-13 22:01 ` Simon Glass
2018-05-15 21:08 ` Joe Hershberger
2 siblings, 2 replies; 18+ messages in thread
From: Ley Foon Tan @ 2018-05-08 3:19 UTC (permalink / raw)
To: u-boot
Add code to reset all reset signals as in Ethernet DT node. A reset property is an optional feature,
so only print out a warning and do not fail if a reset property is not present.
If a reset property is discovered, then use it to deassert, thus bringing the
IP out of reset.
Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
---
drivers/net/designware.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/net/designware.c b/drivers/net/designware.c
index cf12521..6797691 100644
--- a/drivers/net/designware.c
+++ b/drivers/net/designware.c
@@ -15,6 +15,7 @@
#include <miiphy.h>
#include <malloc.h>
#include <pci.h>
+#include <reset.h>
#include <linux/compiler.h>
#include <linux/err.h>
#include <linux/kernel.h>
@@ -664,6 +665,7 @@ int designware_eth_probe(struct udevice *dev)
u32 iobase = pdata->iobase;
ulong ioaddr;
int ret;
+ struct reset_ctl_bulk reset_bulk;
#ifdef CONFIG_CLK
int i, err, clock_nb;
@@ -710,6 +712,12 @@ int designware_eth_probe(struct udevice *dev)
}
#endif
+ ret = reset_get_bulk(dev, &reset_bulk);
+ if (ret)
+ dev_warn(dev, "Can't get reset: %d\n", ret);
+ else
+ reset_deassert_bulk(&reset_bulk);
+
#ifdef CONFIG_DM_PCI
/*
* If we are on PCI bus, either directly attached to a PCI root port,
--
1.7.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [U-Boot] [PATCH v3 1/3] mmc: dwmmc: socfpga: Add reset ctrl to driver
2018-05-08 3:19 ` [U-Boot] [PATCH v3 1/3] mmc: dwmmc: socfpga: Add reset ctrl to driver Ley Foon Tan
@ 2018-05-13 22:01 ` Simon Glass
2018-05-24 2:27 ` Ley Foon Tan
2018-05-24 12:39 ` [U-Boot] [U-Boot, v3, " Tom Rini
1 sibling, 1 reply; 18+ messages in thread
From: Simon Glass @ 2018-05-13 22:01 UTC (permalink / raw)
To: u-boot
On 8 May 2018 at 13:19, Ley Foon Tan <ley.foon.tan@intel.com> wrote:
> Add code to reset all reset signals as in mmc DT node. A reset property is an optional feature,
> so only print out a warning and do not fail if a reset property is not present.
>
> If a reset property is discovered, then use it to deassert, thus bringing the
> IP out of reset.
>
> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
> ---
> drivers/mmc/socfpga_dw_mmc.c | 17 +++++++++++++++++
> 1 files changed, 17 insertions(+), 0 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 18+ messages in thread
* [U-Boot] [PATCH v3 3/3] net: designware: Add reset ctrl to driver
2018-05-08 3:19 ` [U-Boot] [PATCH v3 3/3] net: designware: " Ley Foon Tan
@ 2018-05-13 22:01 ` Simon Glass
2018-05-15 21:08 ` Joe Hershberger
1 sibling, 0 replies; 18+ messages in thread
From: Simon Glass @ 2018-05-13 22:01 UTC (permalink / raw)
To: u-boot
On 8 May 2018 at 13:19, Ley Foon Tan <ley.foon.tan@intel.com> wrote:
> Add code to reset all reset signals as in Ethernet DT node. A reset property is an optional feature,
> so only print out a warning and do not fail if a reset property is not present.
>
> If a reset property is discovered, then use it to deassert, thus bringing the
> IP out of reset.
>
> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
> ---
> drivers/net/designware.c | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 18+ messages in thread
* [U-Boot] [PATCH v3 3/3] net: designware: Add reset ctrl to driver
2018-05-08 3:19 ` [U-Boot] [PATCH v3 3/3] net: designware: " Ley Foon Tan
2018-05-13 22:01 ` Simon Glass
@ 2018-05-15 21:08 ` Joe Hershberger
2018-05-24 2:22 ` Ley Foon Tan
1 sibling, 1 reply; 18+ messages in thread
From: Joe Hershberger @ 2018-05-15 21:08 UTC (permalink / raw)
To: u-boot
On Mon, May 7, 2018 at 10:19 PM, Ley Foon Tan <ley.foon.tan@intel.com> wrote:
> Add code to reset all reset signals as in Ethernet DT node. A reset property is an optional feature,
> so only print out a warning and do not fail if a reset property is not present.
>
> If a reset property is discovered, then use it to deassert, thus bringing the
> IP out of reset.
>
> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
^ permalink raw reply [flat|nested] 18+ messages in thread
* [U-Boot] [PATCH v3 3/3] net: designware: Add reset ctrl to driver
2018-05-15 21:08 ` Joe Hershberger
@ 2018-05-24 2:22 ` Ley Foon Tan
2018-06-12 20:50 ` Joe Hershberger
0 siblings, 1 reply; 18+ messages in thread
From: Ley Foon Tan @ 2018-05-24 2:22 UTC (permalink / raw)
To: u-boot
On Wed, May 16, 2018 at 5:08 AM, Joe Hershberger <joe.hershberger@ni.com> wrote:
> On Mon, May 7, 2018 at 10:19 PM, Ley Foon Tan <ley.foon.tan@intel.com> wrote:
>> Add code to reset all reset signals as in Ethernet DT node. A reset property is an optional feature,
>> so only print out a warning and do not fail if a reset property is not present.
>>
>> If a reset property is discovered, then use it to deassert, thus bringing the
>> IP out of reset.
>>
>> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
>
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Hi Joe
Will you merge this patch to mainline?
Regards
Ley Foon
^ permalink raw reply [flat|nested] 18+ messages in thread
* [U-Boot] [PATCH v3 2/3] serial: ns16550: Add reset ctrl to driver
2018-05-08 3:19 ` [U-Boot] [PATCH v3 2/3] serial: ns16550: " Ley Foon Tan
@ 2018-05-24 2:25 ` Ley Foon Tan
0 siblings, 0 replies; 18+ messages in thread
From: Ley Foon Tan @ 2018-05-24 2:25 UTC (permalink / raw)
To: u-boot
On Tue, May 8, 2018 at 11:19 AM, Ley Foon Tan <ley.foon.tan@intel.com> wrote:
> Add code to reset all reset signals as in serial DT node. A reset property is an optional feature,
> so do not fail if a reset property is not present.
>
> If a reset property is discovered, then use it to deassert, thus bringing the
> IP out of reset.
>
> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
> Reviewed-by: Marek Vasut <marex@denx.de>
> ---
> drivers/serial/ns16550.c | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
> index 53550bf..9c80090 100644
> --- a/drivers/serial/ns16550.c
> +++ b/drivers/serial/ns16550.c
> @@ -9,6 +9,7 @@
> #include <dm.h>
> #include <errno.h>
> #include <ns16550.h>
> +#include <reset.h>
> #include <serial.h>
> #include <watchdog.h>
> #include <linux/types.h>
> @@ -177,6 +178,7 @@ void NS16550_init(NS16550_t com_port, int baud_divisor)
> #if defined(CONFIG_ARCH_OMAP2PLUS)
> serial_out(0x7, &com_port->mdr1); /* mode select reset TL16C750*/
> #endif
> +
> serial_out(UART_MCRVAL, &com_port->mcr);
> serial_out(ns16550_getfcr(com_port), &com_port->fcr);
> if (baud_divisor != -1)
> @@ -370,6 +372,12 @@ static int ns16550_serial_setbrg(struct udevice *dev, int baudrate)
> int ns16550_serial_probe(struct udevice *dev)
> {
> struct NS16550 *const com_port = dev_get_priv(dev);
> + struct reset_ctl_bulk reset_bulk;
> + int ret;
> +
> + ret = reset_get_bulk(dev, &reset_bulk);
> + if (!ret)
> + reset_deassert_bulk(&reset_bulk);
>
> com_port->plat = dev_get_platdata(dev);
> NS16550_init(com_port, -1);
> --
> 1.7.1
>
Hi Tom
Can you help to merge this patch if okay with this patch?
Regards
Ley Foon
^ permalink raw reply [flat|nested] 18+ messages in thread
* [U-Boot] [PATCH v3 1/3] mmc: dwmmc: socfpga: Add reset ctrl to driver
2018-05-13 22:01 ` Simon Glass
@ 2018-05-24 2:27 ` Ley Foon Tan
0 siblings, 0 replies; 18+ messages in thread
From: Ley Foon Tan @ 2018-05-24 2:27 UTC (permalink / raw)
To: u-boot
On Mon, May 14, 2018 at 6:01 AM, Simon Glass <sjg@chromium.org> wrote:
> On 8 May 2018 at 13:19, Ley Foon Tan <ley.foon.tan@intel.com> wrote:
>> Add code to reset all reset signals as in mmc DT node. A reset property is an optional feature,
>> so only print out a warning and do not fail if a reset property is not present.
>>
>> If a reset property is discovered, then use it to deassert, thus bringing the
>> IP out of reset.
>>
>> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
>> ---
>> drivers/mmc/socfpga_dw_mmc.c | 17 +++++++++++++++++
>> 1 files changed, 17 insertions(+), 0 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Hi Jaehoon
Can you help to merge this patch?
Regards
Ley Foon
^ permalink raw reply [flat|nested] 18+ messages in thread
* [U-Boot] [U-Boot, v3, 1/3] mmc: dwmmc: socfpga: Add reset ctrl to driver
2018-05-08 3:19 ` [U-Boot] [PATCH v3 1/3] mmc: dwmmc: socfpga: Add reset ctrl to driver Ley Foon Tan
2018-05-13 22:01 ` Simon Glass
@ 2018-05-24 12:39 ` Tom Rini
2018-05-25 2:45 ` Ley Foon Tan
1 sibling, 1 reply; 18+ messages in thread
From: Tom Rini @ 2018-05-24 12:39 UTC (permalink / raw)
To: u-boot
On Tue, May 08, 2018 at 11:19:24AM +0800, Ley Foon Tan wrote:
> Add code to reset all reset signals as in mmc DT node. A reset property is an optional feature,
> so only print out a warning and do not fail if a reset property is not present.
>
> If a reset property is discovered, then use it to deassert, thus bringing the
> IP out of reset.
>
> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
> drivers/mmc/socfpga_dw_mmc.c | 17 +++++++++++++++++
> 1 files changed, 17 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/socfpga_dw_mmc.c b/drivers/mmc/socfpga_dw_mmc.c
> index fa0e449..eb7e64e 100644
> --- a/drivers/mmc/socfpga_dw_mmc.c
> +++ b/drivers/mmc/socfpga_dw_mmc.c
> @@ -13,6 +13,7 @@
> #include <linux/libfdt.h>
> #include <linux/err.h>
> #include <malloc.h>
> +#include <reset.h>
>
> DECLARE_GLOBAL_DATA_PTR;
>
> @@ -33,6 +34,20 @@ struct dwmci_socfpga_priv_data {
> unsigned int smplsel;
> };
>
> +static void socfpga_dwmci_reset(struct udevice *dev)
> +{
> + struct reset_ctl_bulk reset_bulk;
> + int ret;
> +
> + ret = reset_get_bulk(dev, &reset_bulk);
> + if (ret) {
> + dev_warn(dev, "Can't get reset: %d\n", ret);
> + return;
> + }
> +
> + reset_deassert_bulk(&reset_bulk);
> +}
The driver doesn't depend on DM_RESET and this code hunk doesn't either
so it fails to build on a number of platforms. This type of comment
applies to the whole series, and may be fixed differently in different
cases (it might be OK to enforce DM_RESET for this driver, but not for
the ns16550 driver).
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180524/bf723319/attachment.sig>
^ permalink raw reply [flat|nested] 18+ messages in thread
* [U-Boot] [U-Boot, v3, 1/3] mmc: dwmmc: socfpga: Add reset ctrl to driver
2018-05-24 12:39 ` [U-Boot] [U-Boot, v3, " Tom Rini
@ 2018-05-25 2:45 ` Ley Foon Tan
2018-05-25 11:16 ` Tom Rini
0 siblings, 1 reply; 18+ messages in thread
From: Ley Foon Tan @ 2018-05-25 2:45 UTC (permalink / raw)
To: u-boot
On Thu, May 24, 2018 at 8:39 PM, Tom Rini <trini@konsulko.com> wrote:
> On Tue, May 08, 2018 at 11:19:24AM +0800, Ley Foon Tan wrote:
>
>> Add code to reset all reset signals as in mmc DT node. A reset property is an optional feature,
>> so only print out a warning and do not fail if a reset property is not present.
>>
>> If a reset property is discovered, then use it to deassert, thus bringing the
>> IP out of reset.
>>
>> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
>> Reviewed-by: Simon Glass <sjg@chromium.org>
>> ---
>> drivers/mmc/socfpga_dw_mmc.c | 17 +++++++++++++++++
>> 1 files changed, 17 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/mmc/socfpga_dw_mmc.c b/drivers/mmc/socfpga_dw_mmc.c
>> index fa0e449..eb7e64e 100644
>> --- a/drivers/mmc/socfpga_dw_mmc.c
>> +++ b/drivers/mmc/socfpga_dw_mmc.c
>> @@ -13,6 +13,7 @@
>> #include <linux/libfdt.h>
>> #include <linux/err.h>
>> #include <malloc.h>
>> +#include <reset.h>
>>
>> DECLARE_GLOBAL_DATA_PTR;
>>
>> @@ -33,6 +34,20 @@ struct dwmci_socfpga_priv_data {
>> unsigned int smplsel;
>> };
>>
>> +static void socfpga_dwmci_reset(struct udevice *dev)
>> +{
>> + struct reset_ctl_bulk reset_bulk;
>> + int ret;
>> +
>> + ret = reset_get_bulk(dev, &reset_bulk);
>> + if (ret) {
>> + dev_warn(dev, "Can't get reset: %d\n", ret);
>> + return;
>> + }
>> +
>> + reset_deassert_bulk(&reset_bulk);
>> +}
>
> The driver doesn't depend on DM_RESET and this code hunk doesn't either
> so it fails to build on a number of platforms. This type of comment
> applies to the whole series, and may be fixed differently in different
> cases (it might be OK to enforce DM_RESET for this driver, but not for
> the ns16550 driver).
>
> --
> Tom
>
include/reset.h has the DM_RESET wrapper, so it will not cause the
compilation error if the CONFIG_DM_RESET is disabled.
I have tried compile the uboot with CONFIG_DM_RESET disabled,
compilation is fine.
Thanks.
Regards
Ley Foon
^ permalink raw reply [flat|nested] 18+ messages in thread
* [U-Boot] [U-Boot, v3, 1/3] mmc: dwmmc: socfpga: Add reset ctrl to driver
2018-05-25 2:45 ` Ley Foon Tan
@ 2018-05-25 11:16 ` Tom Rini
2018-05-29 13:30 ` Dinh Nguyen
2018-05-31 3:02 ` Ley Foon Tan
0 siblings, 2 replies; 18+ messages in thread
From: Tom Rini @ 2018-05-25 11:16 UTC (permalink / raw)
To: u-boot
On Fri, May 25, 2018 at 10:45:53AM +0800, Ley Foon Tan wrote:
> On Thu, May 24, 2018 at 8:39 PM, Tom Rini <trini@konsulko.com> wrote:
> > On Tue, May 08, 2018 at 11:19:24AM +0800, Ley Foon Tan wrote:
> >
> >> Add code to reset all reset signals as in mmc DT node. A reset property is an optional feature,
> >> so only print out a warning and do not fail if a reset property is not present.
> >>
> >> If a reset property is discovered, then use it to deassert, thus bringing the
> >> IP out of reset.
> >>
> >> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
> >> Reviewed-by: Simon Glass <sjg@chromium.org>
> >> ---
> >> drivers/mmc/socfpga_dw_mmc.c | 17 +++++++++++++++++
> >> 1 files changed, 17 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/drivers/mmc/socfpga_dw_mmc.c b/drivers/mmc/socfpga_dw_mmc.c
> >> index fa0e449..eb7e64e 100644
> >> --- a/drivers/mmc/socfpga_dw_mmc.c
> >> +++ b/drivers/mmc/socfpga_dw_mmc.c
> >> @@ -13,6 +13,7 @@
> >> #include <linux/libfdt.h>
> >> #include <linux/err.h>
> >> #include <malloc.h>
> >> +#include <reset.h>
> >>
> >> DECLARE_GLOBAL_DATA_PTR;
> >>
> >> @@ -33,6 +34,20 @@ struct dwmci_socfpga_priv_data {
> >> unsigned int smplsel;
> >> };
> >>
> >> +static void socfpga_dwmci_reset(struct udevice *dev)
> >> +{
> >> + struct reset_ctl_bulk reset_bulk;
> >> + int ret;
> >> +
> >> + ret = reset_get_bulk(dev, &reset_bulk);
> >> + if (ret) {
> >> + dev_warn(dev, "Can't get reset: %d\n", ret);
> >> + return;
> >> + }
> >> +
> >> + reset_deassert_bulk(&reset_bulk);
> >> +}
> >
> > The driver doesn't depend on DM_RESET and this code hunk doesn't either
> > so it fails to build on a number of platforms. This type of comment
> > applies to the whole series, and may be fixed differently in different
> > cases (it might be OK to enforce DM_RESET for this driver, but not for
> > the ns16550 driver).
> >
> > --
> > Tom
> >
> include/reset.h has the DM_RESET wrapper, so it will not cause the
> compilation error if the CONFIG_DM_RESET is disabled.
>
> I have tried compile the uboot with CONFIG_DM_RESET disabled,
> compilation is fine.
This whole series causes a good percent of the world to fail to link, so
something is off about the wrappers or use of them. See:
https://travis-ci.org/trini/u-boot/jobs/382783645
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180525/9d686024/attachment.sig>
^ permalink raw reply [flat|nested] 18+ messages in thread
* [U-Boot] [U-Boot, v3, 1/3] mmc: dwmmc: socfpga: Add reset ctrl to driver
2018-05-25 11:16 ` Tom Rini
@ 2018-05-29 13:30 ` Dinh Nguyen
2018-05-31 3:02 ` Ley Foon Tan
1 sibling, 0 replies; 18+ messages in thread
From: Dinh Nguyen @ 2018-05-29 13:30 UTC (permalink / raw)
To: u-boot
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 05/25/2018 06:16 AM, Tom Rini wrote:
> On Fri, May 25, 2018 at 10:45:53AM +0800, Ley Foon Tan wrote:
>> On Thu, May 24, 2018 at 8:39 PM, Tom Rini <trini@konsulko.com>
>> wrote:
>>> On Tue, May 08, 2018 at 11:19:24AM +0800, Ley Foon Tan wrote:
>>>
>>>> Add code to reset all reset signals as in mmc DT node. A
>>>> reset property is an optional feature, so only print out a
>>>> warning and do not fail if a reset property is not present.
>>>>
>>>> If a reset property is discovered, then use it to deassert,
>>>> thus bringing the IP out of reset.
>>>>
>>>> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
>>>> Reviewed-by: Simon Glass <sjg@chromium.org> ---
>>>> drivers/mmc/socfpga_dw_mmc.c | 17 +++++++++++++++++ 1 files
>>>> changed, 17 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/drivers/mmc/socfpga_dw_mmc.c
>>>> b/drivers/mmc/socfpga_dw_mmc.c index fa0e449..eb7e64e 100644
>>>> --- a/drivers/mmc/socfpga_dw_mmc.c +++
>>>> b/drivers/mmc/socfpga_dw_mmc.c @@ -13,6 +13,7 @@ #include
>>>> <linux/libfdt.h> #include <linux/err.h> #include <malloc.h>
>>>> +#include <reset.h>
>>>>
>>>> DECLARE_GLOBAL_DATA_PTR;
>>>>
>>>> @@ -33,6 +34,20 @@ struct dwmci_socfpga_priv_data { unsigned
>>>> int smplsel; };
>>>>
>>>> +static void socfpga_dwmci_reset(struct udevice *dev) +{ +
>>>> struct reset_ctl_bulk reset_bulk; + int ret; + + ret
>>>> = reset_get_bulk(dev, &reset_bulk); + if (ret) { +
>>>> dev_warn(dev, "Can't get reset: %d\n", ret); +
>>>> return; + } + + reset_deassert_bulk(&reset_bulk); +}
>>>
>>> The driver doesn't depend on DM_RESET and this code hunk
>>> doesn't either so it fails to build on a number of platforms.
>>> This type of comment applies to the whole series, and may be
>>> fixed differently in different cases (it might be OK to enforce
>>> DM_RESET for this driver, but not for the ns16550 driver).
>>>
>>> -- Tom
>>>
>> include/reset.h has the DM_RESET wrapper, so it will not cause
>> the compilation error if the CONFIG_DM_RESET is disabled.
>>
>> I have tried compile the uboot with CONFIG_DM_RESET disabled,
>> compilation is fine.
The case is fine when CONFIG_DM_RESET is disabled, but it fails when
CONFIG_DM_RESET is enabled.
You need:
CONFIG_SPL_RESET_SUPPORT=y
Dinh
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQIcBAEBCAAGBQJbDVXVAAoJEBmUBAuBoyj0GrwP/1UAMiFWllpyq/19Lktr8yDa
hZxl4Ynj6HHOSSUWorZeAdaAE0r79lPMR037G7XLV1EiVfe7XkKgVXp8EUusNbMA
nYY+TOe321MoSF+agXoVr6QbwTwH67lAJO5uZ+sbStlElkH1ATTbbsNE092P6Gp9
WgwK8fT1p78BJQ4djTUwDnxIFe9hW3O4VhIeKEte0Ny7cgxsoYH0a6eXd1ozjOp/
H7j31vgjemPUYQI7gf+2JEz/38DaFOMvF4n5eofftIV44Nx8yE/VzgM+9ry+QxNn
h+7/VM2LYbTTwDA+9YuRyleLrv8hcIgbcd/TFnxkBr8Yw4N3JSQjhyjeK/LkTGge
hyixyy132bng89GcGZn3oXxKLTdUi3v9pwBI5payjZ/sKuH8nySM3OAas3nrPWI3
g62t8/x3ufD+ZegaVWL66Sp2kLt3xamJe+WrLtcGgXzOLJDC9lsE8/iV+d2Jrat6
4x6gvcxPJvd0WieEapzsP6SqU/J0yA/RrMAtTwASQrXd9yH5CH6+FD/Yw+ShyEiO
FiIz/p80NL3yqkFOBASm422r8RKPZ84hOeHNbV79rWNrBaQHAlK/mKwPrNjhao7l
j3izAGOi75/aQO8QBnD2uCDXHRDL0+mCPPcwBzX90/HtubIjB/ZHiZuDuwCa+JrN
wwbHCJO6WDj3sqv0iErz
=JhCN
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 18+ messages in thread
* [U-Boot] [U-Boot, v3, 1/3] mmc: dwmmc: socfpga: Add reset ctrl to driver
2018-05-25 11:16 ` Tom Rini
2018-05-29 13:30 ` Dinh Nguyen
@ 2018-05-31 3:02 ` Ley Foon Tan
2018-05-31 11:16 ` Tom Rini
1 sibling, 1 reply; 18+ messages in thread
From: Ley Foon Tan @ 2018-05-31 3:02 UTC (permalink / raw)
To: u-boot
On Fri, May 25, 2018 at 7:16 PM, Tom Rini <trini@konsulko.com> wrote:
> On Fri, May 25, 2018 at 10:45:53AM +0800, Ley Foon Tan wrote:
>> On Thu, May 24, 2018 at 8:39 PM, Tom Rini <trini@konsulko.com> wrote:
>> > On Tue, May 08, 2018 at 11:19:24AM +0800, Ley Foon Tan wrote:
>> >
>> >> Add code to reset all reset signals as in mmc DT node. A reset property is an optional feature,
>> >> so only print out a warning and do not fail if a reset property is not present.
>> >>
>> >> If a reset property is discovered, then use it to deassert, thus bringing the
>> >> IP out of reset.
>> >>
>> >> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
>> >> Reviewed-by: Simon Glass <sjg@chromium.org>
>> >> ---
>> >> drivers/mmc/socfpga_dw_mmc.c | 17 +++++++++++++++++
>> >> 1 files changed, 17 insertions(+), 0 deletions(-)
>> >>
>> >> diff --git a/drivers/mmc/socfpga_dw_mmc.c b/drivers/mmc/socfpga_dw_mmc.c
>> >> index fa0e449..eb7e64e 100644
>> >> --- a/drivers/mmc/socfpga_dw_mmc.c
>> >> +++ b/drivers/mmc/socfpga_dw_mmc.c
>> >> @@ -13,6 +13,7 @@
>> >> #include <linux/libfdt.h>
>> >> #include <linux/err.h>
>> >> #include <malloc.h>
>> >> +#include <reset.h>
>> >>
>> >> DECLARE_GLOBAL_DATA_PTR;
>> >>
>> >> @@ -33,6 +34,20 @@ struct dwmci_socfpga_priv_data {
>> >> unsigned int smplsel;
>> >> };
>> >>
>> >> +static void socfpga_dwmci_reset(struct udevice *dev)
>> >> +{
>> >> + struct reset_ctl_bulk reset_bulk;
>> >> + int ret;
>> >> +
>> >> + ret = reset_get_bulk(dev, &reset_bulk);
>> >> + if (ret) {
>> >> + dev_warn(dev, "Can't get reset: %d\n", ret);
>> >> + return;
>> >> + }
>> >> +
>> >> + reset_deassert_bulk(&reset_bulk);
>> >> +}
>> >
>> > The driver doesn't depend on DM_RESET and this code hunk doesn't either
>> > so it fails to build on a number of platforms. This type of comment
>> > applies to the whole series, and may be fixed differently in different
>> > cases (it might be OK to enforce DM_RESET for this driver, but not for
>> > the ns16550 driver).
>> >
>> > --
>> > Tom
>> >
>> include/reset.h has the DM_RESET wrapper, so it will not cause the
>> compilation error if the CONFIG_DM_RESET is disabled.
>>
>> I have tried compile the uboot with CONFIG_DM_RESET disabled,
>> compilation is fine.
>
> This whole series causes a good percent of the world to fail to link, so
> something is off about the wrappers or use of them. See:
> https://travis-ci.org/trini/u-boot/jobs/382783645
>
This build is happened in SPL build, when CONF_DM_RESET is enabled,
but CONFIG_SPL_RESET_SUPPORT is disabled.
So, adding #ifdef CONFIG_DM_RESET checking in these peripherals also
can't resolve the compilation error.
Two possible fix below, or you have better suggestion.
(1) select SPL_RESET_SUPPORT when DM_RESET is enabled.
diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index 33c39b7..b43cd89 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -3,6 +3,7 @@ menu "Reset Controller Support"
config DM_RESET
bool "Enable reset controllers using Driver Model"
depends on DM && OF_CONTROL
+ select SPL_RESET_SUPPORT
help
(2) Add CONFIG_SPL_RESET_SUPPORT checking in reset.h file
diff --git a/include/reset.h b/include/reset.h
index 201bafc..0ac0a47 100644
--- a/include/reset.h
+++ b/include/reset.h
@@ -77,7 +77,8 @@ struct reset_ctl_bulk {
unsigned int count;
};
-#ifdef CONFIG_DM_RESET
+#if (!defined(CONFIG_SPL_BUILD) && defined(CONFIG_DM_RESET)) || \
+ (defined(CONFIG_SPL_RESET_SUPPORT) && defined(CONFIG_DM_RESET))
Regards
Ley Foon
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [U-Boot] [U-Boot, v3, 1/3] mmc: dwmmc: socfpga: Add reset ctrl to driver
2018-05-31 3:02 ` Ley Foon Tan
@ 2018-05-31 11:16 ` Tom Rini
2018-06-01 2:01 ` Ley Foon Tan
0 siblings, 1 reply; 18+ messages in thread
From: Tom Rini @ 2018-05-31 11:16 UTC (permalink / raw)
To: u-boot
On Thu, May 31, 2018 at 11:02:39AM +0800, Ley Foon Tan wrote:
> On Fri, May 25, 2018 at 7:16 PM, Tom Rini <trini@konsulko.com> wrote:
> > On Fri, May 25, 2018 at 10:45:53AM +0800, Ley Foon Tan wrote:
> >> On Thu, May 24, 2018 at 8:39 PM, Tom Rini <trini@konsulko.com> wrote:
> >> > On Tue, May 08, 2018 at 11:19:24AM +0800, Ley Foon Tan wrote:
> >> >
> >> >> Add code to reset all reset signals as in mmc DT node. A reset property is an optional feature,
> >> >> so only print out a warning and do not fail if a reset property is not present.
> >> >>
> >> >> If a reset property is discovered, then use it to deassert, thus bringing the
> >> >> IP out of reset.
> >> >>
> >> >> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
> >> >> Reviewed-by: Simon Glass <sjg@chromium.org>
> >> >> ---
> >> >> drivers/mmc/socfpga_dw_mmc.c | 17 +++++++++++++++++
> >> >> 1 files changed, 17 insertions(+), 0 deletions(-)
> >> >>
> >> >> diff --git a/drivers/mmc/socfpga_dw_mmc.c b/drivers/mmc/socfpga_dw_mmc.c
> >> >> index fa0e449..eb7e64e 100644
> >> >> --- a/drivers/mmc/socfpga_dw_mmc.c
> >> >> +++ b/drivers/mmc/socfpga_dw_mmc.c
> >> >> @@ -13,6 +13,7 @@
> >> >> #include <linux/libfdt.h>
> >> >> #include <linux/err.h>
> >> >> #include <malloc.h>
> >> >> +#include <reset.h>
> >> >>
> >> >> DECLARE_GLOBAL_DATA_PTR;
> >> >>
> >> >> @@ -33,6 +34,20 @@ struct dwmci_socfpga_priv_data {
> >> >> unsigned int smplsel;
> >> >> };
> >> >>
> >> >> +static void socfpga_dwmci_reset(struct udevice *dev)
> >> >> +{
> >> >> + struct reset_ctl_bulk reset_bulk;
> >> >> + int ret;
> >> >> +
> >> >> + ret = reset_get_bulk(dev, &reset_bulk);
> >> >> + if (ret) {
> >> >> + dev_warn(dev, "Can't get reset: %d\n", ret);
> >> >> + return;
> >> >> + }
> >> >> +
> >> >> + reset_deassert_bulk(&reset_bulk);
> >> >> +}
> >> >
> >> > The driver doesn't depend on DM_RESET and this code hunk doesn't either
> >> > so it fails to build on a number of platforms. This type of comment
> >> > applies to the whole series, and may be fixed differently in different
> >> > cases (it might be OK to enforce DM_RESET for this driver, but not for
> >> > the ns16550 driver).
> >> >
> >> > --
> >> > Tom
> >> >
> >> include/reset.h has the DM_RESET wrapper, so it will not cause the
> >> compilation error if the CONFIG_DM_RESET is disabled.
> >>
> >> I have tried compile the uboot with CONFIG_DM_RESET disabled,
> >> compilation is fine.
> >
> > This whole series causes a good percent of the world to fail to link, so
> > something is off about the wrappers or use of them. See:
> > https://travis-ci.org/trini/u-boot/jobs/382783645
> >
> This build is happened in SPL build, when CONF_DM_RESET is enabled,
> but CONFIG_SPL_RESET_SUPPORT is disabled.
> So, adding #ifdef CONFIG_DM_RESET checking in these peripherals also
> can't resolve the compilation error.
> Two possible fix below, or you have better suggestion.
>
> (1) select SPL_RESET_SUPPORT when DM_RESET is enabled.
>
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 33c39b7..b43cd89 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -3,6 +3,7 @@ menu "Reset Controller Support"
> config DM_RESET
> bool "Enable reset controllers using Driver Model"
> depends on DM && OF_CONTROL
> + select SPL_RESET_SUPPORT
> help
>
>
>
> (2) Add CONFIG_SPL_RESET_SUPPORT checking in reset.h file
>
> diff --git a/include/reset.h b/include/reset.h
> index 201bafc..0ac0a47 100644
> --- a/include/reset.h
> +++ b/include/reset.h
> @@ -77,7 +77,8 @@ struct reset_ctl_bulk {
> unsigned int count;
> };
>
> -#ifdef CONFIG_DM_RESET
> +#if (!defined(CONFIG_SPL_BUILD) && defined(CONFIG_DM_RESET)) || \
> + (defined(CONFIG_SPL_RESET_SUPPORT) && defined(CONFIG_DM_RESET))
We need option #2, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180531/cf646f19/attachment.sig>
^ permalink raw reply [flat|nested] 18+ messages in thread
* [U-Boot] [U-Boot, v3, 1/3] mmc: dwmmc: socfpga: Add reset ctrl to driver
2018-05-31 11:16 ` Tom Rini
@ 2018-06-01 2:01 ` Ley Foon Tan
0 siblings, 0 replies; 18+ messages in thread
From: Ley Foon Tan @ 2018-06-01 2:01 UTC (permalink / raw)
To: u-boot
On Thu, May 31, 2018 at 7:16 PM, Tom Rini <trini@konsulko.com> wrote:
> On Thu, May 31, 2018 at 11:02:39AM +0800, Ley Foon Tan wrote:
>> On Fri, May 25, 2018 at 7:16 PM, Tom Rini <trini@konsulko.com> wrote:
>> > On Fri, May 25, 2018 at 10:45:53AM +0800, Ley Foon Tan wrote:
>> >> On Thu, May 24, 2018 at 8:39 PM, Tom Rini <trini@konsulko.com> wrote:
>> >> > On Tue, May 08, 2018 at 11:19:24AM +0800, Ley Foon Tan wrote:
>> >> >
>> >> >> Add code to reset all reset signals as in mmc DT node. A reset property is an optional feature,
>> >> >> so only print out a warning and do not fail if a reset property is not present.
>> >> >>
>> >> >> If a reset property is discovered, then use it to deassert, thus bringing the
>> >> >> IP out of reset.
>> >> >>
>> >> >> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
>> >> >> Reviewed-by: Simon Glass <sjg@chromium.org>
>> >> >> ---
>> >> >> drivers/mmc/socfpga_dw_mmc.c | 17 +++++++++++++++++
>> >> >> 1 files changed, 17 insertions(+), 0 deletions(-)
>> >> >>
>> >> >> diff --git a/drivers/mmc/socfpga_dw_mmc.c b/drivers/mmc/socfpga_dw_mmc.c
>> >> >> index fa0e449..eb7e64e 100644
>> >> >> --- a/drivers/mmc/socfpga_dw_mmc.c
>> >> >> +++ b/drivers/mmc/socfpga_dw_mmc.c
>> >> >> @@ -13,6 +13,7 @@
>> >> >> #include <linux/libfdt.h>
>> >> >> #include <linux/err.h>
>> >> >> #include <malloc.h>
>> >> >> +#include <reset.h>
>> >> >>
>> >> >> DECLARE_GLOBAL_DATA_PTR;
>> >> >>
>> >> >> @@ -33,6 +34,20 @@ struct dwmci_socfpga_priv_data {
>> >> >> unsigned int smplsel;
>> >> >> };
>> >> >>
>> >> >> +static void socfpga_dwmci_reset(struct udevice *dev)
>> >> >> +{
>> >> >> + struct reset_ctl_bulk reset_bulk;
>> >> >> + int ret;
>> >> >> +
>> >> >> + ret = reset_get_bulk(dev, &reset_bulk);
>> >> >> + if (ret) {
>> >> >> + dev_warn(dev, "Can't get reset: %d\n", ret);
>> >> >> + return;
>> >> >> + }
>> >> >> +
>> >> >> + reset_deassert_bulk(&reset_bulk);
>> >> >> +}
>> >> >
>> >> > The driver doesn't depend on DM_RESET and this code hunk doesn't either
>> >> > so it fails to build on a number of platforms. This type of comment
>> >> > applies to the whole series, and may be fixed differently in different
>> >> > cases (it might be OK to enforce DM_RESET for this driver, but not for
>> >> > the ns16550 driver).
>> >> >
>> >> > --
>> >> > Tom
>> >> >
>> >> include/reset.h has the DM_RESET wrapper, so it will not cause the
>> >> compilation error if the CONFIG_DM_RESET is disabled.
>> >>
>> >> I have tried compile the uboot with CONFIG_DM_RESET disabled,
>> >> compilation is fine.
>> >
>> > This whole series causes a good percent of the world to fail to link, so
>> > something is off about the wrappers or use of them. See:
>> > https://travis-ci.org/trini/u-boot/jobs/382783645
>> >
>> This build is happened in SPL build, when CONF_DM_RESET is enabled,
>> but CONFIG_SPL_RESET_SUPPORT is disabled.
>> So, adding #ifdef CONFIG_DM_RESET checking in these peripherals also
>> can't resolve the compilation error.
>> Two possible fix below, or you have better suggestion.
>>
>> (1) select SPL_RESET_SUPPORT when DM_RESET is enabled.
>>
>> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
>> index 33c39b7..b43cd89 100644
>> --- a/drivers/reset/Kconfig
>> +++ b/drivers/reset/Kconfig
>> @@ -3,6 +3,7 @@ menu "Reset Controller Support"
>> config DM_RESET
>> bool "Enable reset controllers using Driver Model"
>> depends on DM && OF_CONTROL
>> + select SPL_RESET_SUPPORT
>> help
>>
>>
>>
>> (2) Add CONFIG_SPL_RESET_SUPPORT checking in reset.h file
>>
>> diff --git a/include/reset.h b/include/reset.h
>> index 201bafc..0ac0a47 100644
>> --- a/include/reset.h
>> +++ b/include/reset.h
>> @@ -77,7 +77,8 @@ struct reset_ctl_bulk {
>> unsigned int count;
>> };
>>
>> -#ifdef CONFIG_DM_RESET
>> +#if (!defined(CONFIG_SPL_BUILD) && defined(CONFIG_DM_RESET)) || \
>> + (defined(CONFIG_SPL_RESET_SUPPORT) && defined(CONFIG_DM_RESET))
>
> We need option #2, thanks!
Okay, will add this patch in new revision.
Regards
Ley Foon
^ permalink raw reply [flat|nested] 18+ messages in thread
* [U-Boot] [PATCH v3 3/3] net: designware: Add reset ctrl to driver
2018-05-24 2:22 ` Ley Foon Tan
@ 2018-06-12 20:50 ` Joe Hershberger
0 siblings, 0 replies; 18+ messages in thread
From: Joe Hershberger @ 2018-06-12 20:50 UTC (permalink / raw)
To: u-boot
On Wed, May 23, 2018 at 9:22 PM, Ley Foon Tan <lftan.linux@gmail.com> wrote:
> On Wed, May 16, 2018 at 5:08 AM, Joe Hershberger <joe.hershberger@ni.com> wrote:
>> On Mon, May 7, 2018 at 10:19 PM, Ley Foon Tan <ley.foon.tan@intel.com> wrote:
>>> Add code to reset all reset signals as in Ethernet DT node. A reset property is an optional feature,
>>> so only print out a warning and do not fail if a reset property is not present.
>>>
>>> If a reset property is discovered, then use it to deassert, thus bringing the
>>> IP out of reset.
>>>
>>> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
>>
>> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
>
> Hi Joe
>
> Will you merge this patch to mainline?
OK... it was assigned to Tom in patchwork, but I moved it to me.
-Joe
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2018-06-12 20:50 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-08 3:19 [U-Boot] [PATCH v3 0/3] drivers: Add reset ctrl to drivers Ley Foon Tan
2018-05-08 3:19 ` [U-Boot] [PATCH v3 1/3] mmc: dwmmc: socfpga: Add reset ctrl to driver Ley Foon Tan
2018-05-13 22:01 ` Simon Glass
2018-05-24 2:27 ` Ley Foon Tan
2018-05-24 12:39 ` [U-Boot] [U-Boot, v3, " Tom Rini
2018-05-25 2:45 ` Ley Foon Tan
2018-05-25 11:16 ` Tom Rini
2018-05-29 13:30 ` Dinh Nguyen
2018-05-31 3:02 ` Ley Foon Tan
2018-05-31 11:16 ` Tom Rini
2018-06-01 2:01 ` Ley Foon Tan
2018-05-08 3:19 ` [U-Boot] [PATCH v3 2/3] serial: ns16550: " Ley Foon Tan
2018-05-24 2:25 ` Ley Foon Tan
2018-05-08 3:19 ` [U-Boot] [PATCH v3 3/3] net: designware: " Ley Foon Tan
2018-05-13 22:01 ` Simon Glass
2018-05-15 21:08 ` Joe Hershberger
2018-05-24 2:22 ` Ley Foon Tan
2018-06-12 20:50 ` Joe Hershberger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.