From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032796AbeE0POJ (ORCPT ); Sun, 27 May 2018 11:14:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:44726 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032595AbeE0POH (ORCPT ); Sun, 27 May 2018 11:14:07 -0400 Date: Sun, 27 May 2018 17:13:47 +0200 From: Greg KH To: Vadim Pasternak Cc: dvhart@infradead.org, andy.shevchenko@gmail.com, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, jiri@resnulli.us, michaelsh@mellanox.com, ivecera@redhat.com Subject: Re: [PATCH v3 6/7] platform/mellanox: Introduce support for Mellanox register access driver Message-ID: <20180527151347.GA15487@kroah.com> References: <1527439664-127317-1-git-send-email-vadimp@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1527439664-127317-1-git-send-email-vadimp@mellanox.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 27, 2018 at 04:47:43PM +0000, Vadim Pasternak wrote: > Introduce new Mellanox platform driver to allow access to Mellanox > programmable device register space trough sysfs interface. > The driver purpose is to provide sysfs interface for user space for the > registers essential for system control and monitoring. > The sets of registers for sysfs access are supposed to be defined per > system type bases and include the registers related to system resets > operation, system reset causes monitoring and some kinds of mux selection. > > Signed-off-by: Vadim Pasternak > --- > v1->v2: > Changed added by Vadim: > - Change ---help--- to help in Kconfig, according to new requirements; > v2->v3: > Comments pointed out by Darren: > - Remove conditional assignment per attribute mode type, because mode > will guard against not permitted access. > Verified by Vadim. > --- > drivers/platform/mellanox/Kconfig | 11 ++ > drivers/platform/mellanox/Makefile | 1 + > drivers/platform/mellanox/mlxreg-io.c | 203 ++++++++++++++++++++++++++++++++++ > 3 files changed, 215 insertions(+) > create mode 100644 drivers/platform/mellanox/mlxreg-io.c > > diff --git a/drivers/platform/mellanox/Kconfig b/drivers/platform/mellanox/Kconfig > index 591bccd..ddfae9fc 100644 > --- a/drivers/platform/mellanox/Kconfig > +++ b/drivers/platform/mellanox/Kconfig > @@ -23,4 +23,15 @@ config MLXREG_HOTPLUG > This driver handles hot-plug events for the power suppliers, power > cables and fans on the wide range Mellanox IB and Ethernet systems. > > +config MLXREG_IO > + tristate "Mellanox platform register access driver support" > + depends on REGMAP > + depends on HWMON > + help > + This driver allows access to Mellanox programmable device register > + space trough sysfs interface. The sets of registers for sysfs access > + are defined per system type bases and includes the registers related > + to system resets operation, system reset causes monitoring and some > + kinds of mux selection. No Documentation/ABI/ entries for these new sysfs files? Not good :( greg k-h