All of lore.kernel.org
 help / color / mirror / Atom feed
From: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
To: Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	John Fastabend <john.fastabend@gmail.com>
Cc: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>,
	"David S . Miller" <davem@davemloft.net>,
	Shuah Khan <shuah@kernel.org>,
	netdev@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: [PATCH bpf v2 2/5] selftests/bpf: test_sockmap, join cgroup in selftest mode
Date: Mon, 28 May 2018 13:38:00 +0900	[thread overview]
Message-ID: <20180528043803.4824-3-bhole_prashant_q7@lab.ntt.co.jp> (raw)
In-Reply-To: <20180528043803.4824-1-bhole_prashant_q7@lab.ntt.co.jp>

In case of selftest mode, temporary cgroup environment is created but
cgroup is not joined. It causes test failures. Fixed by joining the
cgroup

Fixes: 16962b2404ac ("bpf: sockmap, add selftests")
Acked-by: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
---
 tools/testing/selftests/bpf/test_sockmap.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tools/testing/selftests/bpf/test_sockmap.c b/tools/testing/selftests/bpf/test_sockmap.c
index 34feb74c95c4..8a81ea0e9fb6 100644
--- a/tools/testing/selftests/bpf/test_sockmap.c
+++ b/tools/testing/selftests/bpf/test_sockmap.c
@@ -1342,6 +1342,11 @@ static int __test_suite(char *bpf_file)
 		return cg_fd;
 	}
 
+	if (join_cgroup(CG_PATH)) {
+		fprintf(stderr, "ERROR: failed to join cgroup\n");
+		return -EINVAL;
+	}
+
 	/* Tests basic commands and APIs with range of iov values */
 	txmsg_start = txmsg_end = 0;
 	err = test_txmsg(cg_fd);
-- 
2.17.0

WARNING: multiple messages have this Message-ID (diff)
From: bhole_prashant_q7 at lab.ntt.co.jp (Prashant Bhole)
Subject: [PATCH bpf v2 2/5] selftests/bpf: test_sockmap, join cgroup in selftest mode
Date: Mon, 28 May 2018 13:38:00 +0900	[thread overview]
Message-ID: <20180528043803.4824-3-bhole_prashant_q7@lab.ntt.co.jp> (raw)
In-Reply-To: <20180528043803.4824-1-bhole_prashant_q7@lab.ntt.co.jp>

In case of selftest mode, temporary cgroup environment is created but
cgroup is not joined. It causes test failures. Fixed by joining the
cgroup

Fixes: 16962b2404ac ("bpf: sockmap, add selftests")
Acked-by: John Fastabend <john.fastabend at gmail.com>
Signed-off-by: Prashant Bhole <bhole_prashant_q7 at lab.ntt.co.jp>
---
 tools/testing/selftests/bpf/test_sockmap.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tools/testing/selftests/bpf/test_sockmap.c b/tools/testing/selftests/bpf/test_sockmap.c
index 34feb74c95c4..8a81ea0e9fb6 100644
--- a/tools/testing/selftests/bpf/test_sockmap.c
+++ b/tools/testing/selftests/bpf/test_sockmap.c
@@ -1342,6 +1342,11 @@ static int __test_suite(char *bpf_file)
 		return cg_fd;
 	}
 
+	if (join_cgroup(CG_PATH)) {
+		fprintf(stderr, "ERROR: failed to join cgroup\n");
+		return -EINVAL;
+	}
+
 	/* Tests basic commands and APIs with range of iov values */
 	txmsg_start = txmsg_end = 0;
 	err = test_txmsg(cg_fd);
-- 
2.17.0


--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: bhole_prashant_q7@lab.ntt.co.jp (Prashant Bhole)
Subject: [PATCH bpf v2 2/5] selftests/bpf: test_sockmap, join cgroup in selftest mode
Date: Mon, 28 May 2018 13:38:00 +0900	[thread overview]
Message-ID: <20180528043803.4824-3-bhole_prashant_q7@lab.ntt.co.jp> (raw)
Message-ID: <20180528043800.JpgMCoSpMm2v0KLIgEhhE9ur7bgPIKsIUeXmlfrZ1_8@z> (raw)
In-Reply-To: <20180528043803.4824-1-bhole_prashant_q7@lab.ntt.co.jp>

In case of selftest mode, temporary cgroup environment is created but
cgroup is not joined. It causes test failures. Fixed by joining the
cgroup

Fixes: 16962b2404ac ("bpf: sockmap, add selftests")
Acked-by: John Fastabend <john.fastabend at gmail.com>
Signed-off-by: Prashant Bhole <bhole_prashant_q7 at lab.ntt.co.jp>
---
 tools/testing/selftests/bpf/test_sockmap.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tools/testing/selftests/bpf/test_sockmap.c b/tools/testing/selftests/bpf/test_sockmap.c
index 34feb74c95c4..8a81ea0e9fb6 100644
--- a/tools/testing/selftests/bpf/test_sockmap.c
+++ b/tools/testing/selftests/bpf/test_sockmap.c
@@ -1342,6 +1342,11 @@ static int __test_suite(char *bpf_file)
 		return cg_fd;
 	}
 
+	if (join_cgroup(CG_PATH)) {
+		fprintf(stderr, "ERROR: failed to join cgroup\n");
+		return -EINVAL;
+	}
+
 	/* Tests basic commands and APIs with range of iov values */
 	txmsg_start = txmsg_end = 0;
 	err = test_txmsg(cg_fd);
-- 
2.17.0


--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2018-05-28  4:39 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-28  4:37 [PATCH bpf v2 0/5] fix test_sockmap Prashant Bhole
2018-05-28  4:37 ` Prashant Bhole
2018-05-28  4:37 ` bhole_prashant_q7
2018-05-28  4:37 ` [PATCH bpf v2 1/5] selftests/bpf: test_sockmap, check test failure Prashant Bhole
2018-05-28  4:37   ` Prashant Bhole
2018-05-28  4:37   ` bhole_prashant_q7
2018-05-29 15:37   ` John Fastabend
2018-05-29 15:37     ` John Fastabend
2018-05-29 15:37     ` john.fastabend
2018-05-28  4:38 ` Prashant Bhole [this message]
2018-05-28  4:38   ` [PATCH bpf v2 2/5] selftests/bpf: test_sockmap, join cgroup in selftest mode Prashant Bhole
2018-05-28  4:38   ` bhole_prashant_q7
2018-05-28  4:38 ` [PATCH bpf v2 3/5] selftests/bpf: test_sockmap, fix test timeout Prashant Bhole
2018-05-28  4:38   ` Prashant Bhole
2018-05-28  4:38   ` bhole_prashant_q7
2018-05-28  4:38 ` [PATCH bpf v2 4/5] selftests/bpf: test_sockmap, fix data verification Prashant Bhole
2018-05-28  4:38   ` Prashant Bhole
2018-05-28  4:38   ` bhole_prashant_q7
2018-05-28  4:38 ` [PATCH bpf v2 5/5] selftests/bpf: test_sockmap, print additional test options Prashant Bhole
2018-05-28  4:38   ` Prashant Bhole
2018-05-28  4:38   ` bhole_prashant_q7
2018-05-29 15:48 ` [PATCH bpf v2 0/5] fix test_sockmap John Fastabend
2018-05-29 15:48   ` John Fastabend
2018-05-29 15:48   ` john.fastabend
2018-05-30  0:44   ` Prashant Bhole
2018-05-30  0:44     ` Prashant Bhole
2018-05-30  0:44     ` bhole_prashant_q7
2018-05-30  5:12     ` John Fastabend
2018-05-30  5:12       ` John Fastabend
2018-05-30  5:12       ` john.fastabend
2018-05-30  5:31       ` Prashant Bhole
2018-05-30  5:31         ` Prashant Bhole
2018-05-30  5:31         ` bhole_prashant_q7

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180528043803.4824-3-bhole_prashant_q7@lab.ntt.co.jp \
    --to=bhole_prashant_q7@lab.ntt.co.jp \
    --cc=ast@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=john.fastabend@gmail.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.