All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: linux-pci@vger.kernel.org,
	Marek Vasut <marek.vasut+renesas@gmail.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Phil Edworthy <phil.edworthy@renesas.com>,
	Wolfram Sang <wsa@the-dreams.de>,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v4 2/6] PCI: rcar: Add missing irq_dispose_mapping() into failpath
Date: Mon, 28 May 2018 10:51:23 +0200	[thread overview]
Message-ID: <20180528085122.oufttjzjk6yqe6ts@verge.net.au> (raw)
In-Reply-To: <20180524143624.26718-3-marek.vasut+renesas@gmail.com>

On Thu, May 24, 2018 at 04:36:20PM +0200, Marek Vasut wrote:
> The rcar_pcie_get_resources() is another misnomer with a side effect.
> The function does not only get resources, but also maps MSI IRQs via
> irq_of_parse_and_map(). In case anything fails afterward, the IRQ
> mapping must be disposed through irq_dispose_mapping() which is not
> done.
> 
> This patch handles irq_of_parse_and_map() failures in by disposing
> of the mapping in rcar_pcie_get_resources() as well as in probe.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: Phil Edworthy <phil.edworthy@renesas.com>
> Cc: Simon Horman <horms+renesas@verge.net.au>
> Cc: Wolfram Sang <wsa@the-dreams.de>
> Cc: linux-renesas-soc@vger.kernel.org


Acked-by: Simon Horman <horms+renesas@verge.net.au>

  reply	other threads:[~2018-05-28  8:51 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-24 14:36 [PATCH v4 0/6] PCI: rcar: Failpath fixes Marek Vasut
2018-05-24 14:36 ` [PATCH v4 1/6] PCI: rcar: Pull bus clock enable/disable from rcar_pcie_get_resources() Marek Vasut
2018-05-28  8:51   ` Simon Horman
2018-05-24 14:36 ` [PATCH v4 2/6] PCI: rcar: Add missing irq_dispose_mapping() into failpath Marek Vasut
2018-05-28  8:51   ` Simon Horman [this message]
2018-05-24 14:36 ` [PATCH v4 3/6] PCI: rcar: Teardown MSI setup if rcar_pcie_enable() fails Marek Vasut
2018-05-28  8:52   ` Simon Horman
2018-05-24 14:36 ` [PATCH v4 4/6] PCI: rcar: Poll more often in rcar_pcie_wait_for_dl() Marek Vasut
2018-05-28  8:53   ` Simon Horman
2018-05-24 14:36 ` [PATCH v4 5/6] PCI: rcar: Remove IRQ mappings in rcar_pcie_enable_msi failpath Marek Vasut
2018-05-28  8:53   ` Simon Horman
2018-05-24 14:36 ` [PATCH v4 6/6] PCI: rcar: Shut the PHY down in failpath Marek Vasut
2018-05-25 10:09   ` Geert Uytterhoeven
2018-05-25 18:34     ` Marek Vasut
2018-05-28  8:48   ` Simon Horman
2018-06-01 23:30     ` Marek Vasut
2018-06-29 13:38   ` Lorenzo Pieralisi
2018-05-25  9:35 ` [PATCH v4 0/6] PCI: rcar: Failpath fixes Lorenzo Pieralisi
2018-05-25  9:39   ` Geert Uytterhoeven
2018-05-25  9:56     ` Lorenzo Pieralisi
2018-05-25 10:01       ` Geert Uytterhoeven
2018-05-25 16:43 ` Lorenzo Pieralisi
2018-05-25 17:10   ` Marek Vasut
2018-05-28  8:54   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180528085122.oufttjzjk6yqe6ts@verge.net.au \
    --to=horms@verge.net.au \
    --cc=geert+renesas@glider.be \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=marek.vasut+renesas@gmail.com \
    --cc=marek.vasut@gmail.com \
    --cc=phil.edworthy@renesas.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.