From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754276AbeE1JlE (ORCPT ); Mon, 28 May 2018 05:41:04 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:40932 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754090AbeE1JlC (ORCPT ); Mon, 28 May 2018 05:41:02 -0400 Date: Mon, 28 May 2018 17:40:48 +0800 From: Herbert Xu To: Davidlohr Bueso Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org, tgraf@suug.ch, manfred@colorfullife.com, guillaume.knispel@supersonicimagine.com, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Davidlohr Bueso Subject: Re: [PATCH 1/6] lib/rhashtable: convert param sanitations to WARN_ON Message-ID: <20180528094048.etqeu2ubc227qrxf@gondor.apana.org.au> References: <20180524211135.27760-1-dave@stgolabs.net> <20180524211135.27760-2-dave@stgolabs.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180524211135.27760-2-dave@stgolabs.net> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 24, 2018 at 02:11:30PM -0700, Davidlohr Bueso wrote: > For the purpose of making rhashtable_init() unable to fail, > we can replace the returning -EINVAL with WARN_ONs whenever > the caller passes bogus parameters during initialization. > > Signed-off-by: Davidlohr Bueso I don't really see why we need these WARN_ONs. The problem should be quite obvious when you're writing your code. If you really want them perhaps add them to the ipc code instead? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt