From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 28 May 2018 15:35:01 -0400 Subject: [U-Boot] [U-Boot,v2,4/7] mach-snapdragon: Fix UART clock flow In-Reply-To: References: <20180516091342.7509-4-ramon.fried@gmail.com> <20180528191241.GD21194@bill-the-cat.ec.rr.com> <75456e68-d6e0-5fd8-f906-53a232dec488@baylibre.com> <20180528192611.GV21194@bill-the-cat.ec.rr.com> Message-ID: <20180528193501.GW21194@bill-the-cat.ec.rr.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, May 28, 2018 at 10:28:51PM +0300, Ramon Fried wrote: > On Mon, May 28, 2018 at 10:26 PM, Tom Rini wrote: > > On Mon, May 28, 2018 at 10:24:36PM +0300, Ramon Fried wrote: > >> On Mon, May 28, 2018 at 10:19 PM, Jorge Ramirez-Ortiz > >> wrote: > >> > On 05/28/2018 09:12 PM, Tom Rini wrote: > >> >> > >> >> On Wed, May 16, 2018 at 12:13:39PM +0300, Ramon Fried wrote: > >> >> > >> >>> UART clock enabling flow was wrong. > >> >>> Changed the flow according to downstream implementation in LK. > >> >>> > >> >>> Signed-off-by: Ramon Fried > >> >> > >> >> Applied to u-boot/master, thanks! > >> >> > >> > > >> > Ramon, did you re-test this one on the 820 as we discussed? > >> > Sorry Tom, when I tested this on Friday it broke my 820 (I should have > >> > reported it to the ML). > >> > > >> > I think it introduces a regression but I'll let Ramon to confirm. > >> Hi. > >> It's funny, I'm debugging it now. don't have any conclusions yet but I > >> was under the assumption that it won't get merged as it was > >> missing Reviewed-by. > >> Let me get back to you on these one in couple of hours. > > > > Yeah, sorry guys, I didn't see anything in public about problems so I > > fixed up the one new warning. Please let me know if you need me to > > revert these or if it's an "easy" fix, thanks! > Sure. > I'll keep you posted. but without any doubt, the following patch is > necessary to make it work: > https://patchwork.ozlabs.org/patch/921407/ > Can you please merge it as well ? 0x0800 is still pretty small. We're talking about (and oops, I think I need to for v2018.07..) bump it to 0x2000 for all TI platforms. Can you v2 doing that size if it works for you (it ought...) and as a default VAL if ARCH_SNAPDRAGON ? Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: