From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934769AbeE1WAg (ORCPT ); Mon, 28 May 2018 18:00:36 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:46090 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934503AbeE1V6S (ORCPT ); Mon, 28 May 2018 17:58:18 -0400 X-Google-Smtp-Source: AB8JxZo+KnnV2Hn0H5Ds0JQN2QHMjwaXatdvjZ7f5xWTVP6k/c8sUte+ozJPxb0l80mOIdf2W/BrPQ== From: Christian Brauner To: linux-kernel@vger.kernel.org Cc: ebiederm@xmission.com, gregkh@linuxfoundation.org, mingo@kernel.org, james.morris@microsoft.com, keescook@chromium.org, peterz@infradead.org, sds@tycho.nsa.gov, viro@zeniv.linux.org.uk, akpm@linux-foundation.org, oleg@redhat.com, Christian Brauner Subject: [PATCH v1 13/20] signal: make has_pending_signals() return bool Date: Mon, 28 May 2018 23:53:48 +0200 Message-Id: <20180528215355.16119-14-christian@brauner.io> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180528215355.16119-1-christian@brauner.io> References: <20180528215355.16119-1-christian@brauner.io> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org has_pending_signals() already behaves like a boolean function. Let's actually declare it as such too. Signed-off-by: Christian Brauner --- v0->v1: * patch introduced --- kernel/signal.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/kernel/signal.c b/kernel/signal.c index 60c501db15d9..d2d4d10223ca 100644 --- a/kernel/signal.c +++ b/kernel/signal.c @@ -110,30 +110,33 @@ static bool sig_ignored(struct task_struct *t, int sig, bool force) * Re-calculate pending state from the set of locally pending * signals, globally pending signals, and blocked signals. */ -static inline int has_pending_signals(sigset_t *signal, sigset_t *blocked) +static inline bool has_pending_signals(sigset_t *signal, sigset_t *blocked) { unsigned long ready; long i; switch (_NSIG_WORDS) { default: - for (i = _NSIG_WORDS, ready = 0; --i >= 0 ;) - ready |= signal->sig[i] &~ blocked->sig[i]; + for (i = _NSIG_WORDS, ready = 0; --i >= 0;) + ready |= signal->sig[i] & ~blocked->sig[i]; break; - case 4: ready = signal->sig[3] &~ blocked->sig[3]; - ready |= signal->sig[2] &~ blocked->sig[2]; - ready |= signal->sig[1] &~ blocked->sig[1]; - ready |= signal->sig[0] &~ blocked->sig[0]; + case 4: + ready = signal->sig[3] & ~blocked->sig[3]; + ready |= signal->sig[2] & ~blocked->sig[2]; + ready |= signal->sig[1] & ~blocked->sig[1]; + ready |= signal->sig[0] & ~blocked->sig[0]; break; - case 2: ready = signal->sig[1] &~ blocked->sig[1]; - ready |= signal->sig[0] &~ blocked->sig[0]; + case 2: + ready = signal->sig[1] & ~blocked->sig[1]; + ready |= signal->sig[0] & ~blocked->sig[0]; break; - case 1: ready = signal->sig[0] &~ blocked->sig[0]; + case 1: + ready = signal->sig[0] & ~blocked->sig[0]; } - return ready != 0; + return ready != 0; } #define PENDING(p,b) has_pending_signals(&(p)->signal, (b)) -- 2.17.0