From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932741AbeE2J5s (ORCPT <rfc822;w@1wt.eu>);
        Tue, 29 May 2018 05:57:48 -0400
Received: from foss.arm.com ([217.140.101.70]:36352 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932476AbeE2J5o (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 29 May 2018 05:57:44 -0400
Date: Tue, 29 May 2018 10:57:40 +0100
From: Mark Rutland <mark.rutland@arm.com>
To: linux-kernel@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>
Cc: Boqun Feng <boqun.feng@gmail.com>, Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH 13/13] atomics/treewide: make test ops optional
Message-ID: <20180529095740.v6pn7xe24n4sqfaz@lakrids.cambridge.arm.com>
References: <20180523133533.1076-1-mark.rutland@arm.com>
 <20180523133533.1076-14-mark.rutland@arm.com>
 <20180529091047.kg3et36pxzwohhat@lakrids.cambridge.arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180529091047.kg3et36pxzwohhat@lakrids.cambridge.arm.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 29, 2018 at 10:11:19AM +0100, Mark Rutland wrote:
> On Wed, May 23, 2018 at 02:35:33PM +0100, Mark Rutland wrote:
> > Some of the atomics return the result of a test applied after the atomic
> > operation, and almost all architectures implement these as trivial
> > wrappers around the underlying atomic. Specifically:
> > 
> > * <atomic>_inc_and_test(v) is (<atomic>_inc_return(v) == 0)
> > 
> > * <atomic>_dec_and_test(v) is (<atomic>_dec_return(v) == 0)
> > 
> > * <atomic>_sub_and_test(i, v) is (<atomic>_sub_return(i, v) == 0)
> > 
> > * <atomic>_add_negative(i, v) is (<atomic>_add_return(i, v) < 0)
> > 
> > Rather than have these definitions duplicated in all architectures, with
> > minor inconsistencies in formatting and documentation, let's make these
> > operations optional, with default fallbacks as above. Implementations
> > must now provide a preprocessor symbol.
> > 
> > The instrumented atomics are updated accordingly.
> > 
> > Both x86 and m68k have custom implementations, which are left as-is,
> > given preprocessor symbols to avoid being overridden.
> > 
> > There should be no functional change as a result of this patch.
> > 
> > Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> > Cc: Boqun Feng <boqun.feng@gmail.com>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Will Deacon <will.deacon@arm.com>
> > ---
> >  arch/alpha/include/asm/atomic.h           |  12 ---
> >  arch/arc/include/asm/atomic.h             |  10 ---
> >  arch/arm/include/asm/atomic.h             |   9 ---
> >  arch/arm64/include/asm/atomic.h           |   8 --
> >  arch/h8300/include/asm/atomic.h           |   5 --
> >  arch/hexagon/include/asm/atomic.h         |   5 --
> >  arch/ia64/include/asm/atomic.h            |  23 ------
> >  arch/m68k/include/asm/atomic.h            |   4 +
> >  arch/mips/include/asm/atomic.h            |  84 --------------------
> >  arch/parisc/include/asm/atomic.h          |  22 ------
> >  arch/powerpc/include/asm/atomic.h         |  30 --------
> >  arch/s390/include/asm/atomic.h            |   8 --
> >  arch/sh/include/asm/atomic.h              |   4 -
> >  arch/sparc/include/asm/atomic_32.h        |  15 ----
> >  arch/sparc/include/asm/atomic_64.h        |  20 -----
> >  arch/x86/include/asm/atomic.h             |   4 +
> >  arch/x86/include/asm/atomic64_32.h        |  54 -------------
> >  arch/x86/include/asm/atomic64_64.h        |   4 +
> >  arch/xtensa/include/asm/atomic.h          |  42 ----------
> >  include/asm-generic/atomic-instrumented.h |  24 ++++++
> >  include/asm-generic/atomic.h              |   9 ---
> >  include/asm-generic/atomic64.h            |   4 -
> >  include/linux/atomic.h                    | 124 ++++++++++++++++++++++++++++++
> >  23 files changed, 160 insertions(+), 364 deletions(-)
> 
> I missed the risvc bits, since those are generated and don't have
> preprocessor symbols.

Ugh, I missed a guard for inc_not_zero on x86_32 in an earlier patch,
too.

I'll spin a v2 of the series.

Mark.