From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934186AbeE2MhL (ORCPT ); Tue, 29 May 2018 08:37:11 -0400 Received: from mx2.suse.de ([195.135.220.15]:34785 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933778AbeE2MhH (ORCPT ); Tue, 29 May 2018 08:37:07 -0400 Date: Tue, 29 May 2018 14:37:04 +0200 From: Michal Hocko To: Jonathan Corbet Cc: Dave Chinner , Randy Dunlap , Mike Rapoport , LKML , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2] doc: document scope NOFS, NOIO APIs Message-ID: <20180529123704.GT27180@dhcp22.suse.cz> References: <20180524114341.1101-1-mhocko@kernel.org> <20180529082644.26192-1-mhocko@kernel.org> <20180529055158.0170231e@lwn.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180529055158.0170231e@lwn.net> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 29-05-18 05:51:58, Jonathan Corbet wrote: > On Tue, 29 May 2018 10:26:44 +0200 > Michal Hocko wrote: > > > Although the api is documented in the source code Ted has pointed out > > that there is no mention in the core-api Documentation and there are > > people looking there to find answers how to use a specific API. > > So, I still think that this: > > > +The traditional way to avoid this deadlock problem is to clear __GFP_FS > > +respectively __GFP_IO (note the latter implies clearing the first as well) in > > doesn't read the way you intend it to. But we've sent you in more > than enough circles on this already, so I went ahead and applied it; > wording can always be tweaked later. Thanks a lot Jonathan! I am open to any suggestions of course and can follow up with some refinements. Just for the background. The above paragraph is meant to say that: - clearing __GFP_FS is a way to avoid reclaim recursion into filesystems deadlocks - clearing __GFP_IO is a way to avoid reclaim recursion into the IO layer deadlocks - GFP_NOIO implies __GFP_NOFS > You added the kerneldoc comments, but didn't bring them into your new > document. I'm going to tack this on afterward, hopefully nobody will > object. I have to confess I've never studied how the rst and kerneldoc should be interlinked so thanks for the fix up! -- Michal Hocko SUSE Labs