From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1fNff1-0003jL-7T for mharc-grub-devel@gnu.org; Tue, 29 May 2018 10:31:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37081) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fNfex-0003iT-Hg for grub-devel@gnu.org; Tue, 29 May 2018 10:31:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fNfet-0005Uu-Lu for grub-devel@gnu.org; Tue, 29 May 2018 10:31:35 -0400 Received: from boksu.net-space.pl ([185.15.1.105]:41535) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.71) (envelope-from ) id 1fNfet-0005Pf-AG for grub-devel@gnu.org; Tue, 29 May 2018 10:31:31 -0400 Received: (from localhost user: 'dkiper' uid#4000 fake: STDIN (dkiper@boksu.net-space.pl)) by router-fw-old.local.net-space.pl id S1841566AbeE2ObZ (ORCPT ); Tue, 29 May 2018 16:31:25 +0200 Date: Tue, 29 May 2018 16:31:25 +0200 From: Daniel Kiper To: mcpain@basealt.ru Cc: grub-devel@gnu.org, phcoder@gmail.com Subject: Re: [PATCH] Enable /dev/mapper/dm-[0-9]-* scanning Message-ID: <20180529143125.GA18885@router-fw-old.local.net-space.pl> References: <6ef0e108-9b3c-0bb8-bf28-7fa013f01963@basealt.ru> <20180510193551.GL25320@router-fw-old.local.net-space.pl> <37013391-18cb-f1f7-6b7a-c6960f77c84b@basealt.ru> <20180514171303.GA8760@router-fw-old.local.net-space.pl> <348aa32f-a9bc-fe4d-0df5-d4c9982de3ef@basealt.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.28i X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 185.15.1.105 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 May 2018 14:31:36 -0000 On Tue, May 29, 2018 at 04:55:10PM +0300, Oleg Solovyov wrote: > 29.05.2018 16:50, Vladimir 'phcoder' Serbinenko ??????????: > > > > > > On Tue, 29 May 2018, 13:58 Oleg Solovyov, > > wrote: > > > > Anybody? > > > > Why do you need this? Normally the same devices should be under > > /dev/mapper. Using dm-X will mess up some other code most likely > What happens if you have /dev/mapper/dm-0-luks symlinked to /dev/dm-0? > This device will be skipped because basename starts with dm-0 > There's no checking whether device is under /dev/mapper or not yet. I have just pushed the patch. Sorry for delay but I was traveling recently. Daniel