From: Herbert Xu <herbert@gondor.apana.org.au>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org,
tgraf@suug.ch, manfred@colorfullife.com,
guillaume.knispel@supersonicimagine.com,
linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH 2/6] lib/rhashtable: guarantee initial hashtable allocation
Date: Wed, 30 May 2018 02:15:10 +0800 [thread overview]
Message-ID: <20180529181510.ttlmndxk36rmkwcy@gondor.apana.org.au> (raw)
In-Reply-To: <20180529175513.s7iju6rkoya3hvsf@linux-n805>
On Tue, May 29, 2018 at 10:55:13AM -0700, Davidlohr Bueso wrote:
> On Wed, 30 May 2018, Herbert Xu wrote:
>
> > On Tue, May 29, 2018 at 09:42:31AM -0700, Davidlohr Bueso wrote:
> > >
> > > For the sake of simplicity, Linus suggested directly using HASH_MIN_SIZE
> > > such that we have a single fallback.
> >
> > Where did he suggest that?
>
> https://lkml.org/lkml/2018/5/24/1265
Well I think we should respect min_size. rhashtable users may
fail at insertion time if the table is too small.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2018-05-29 18:15 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 21:11 [PATCH -next 0/6] rhashtable: guarantee first allocation Davidlohr Bueso
2018-05-24 21:11 ` [PATCH 1/6] lib/rhashtable: convert param sanitations to WARN_ON Davidlohr Bueso
2018-05-28 9:40 ` Herbert Xu
2018-05-28 13:12 ` Davidlohr Bueso
2018-05-28 15:54 ` Herbert Xu
2018-05-28 15:51 ` Davidlohr Bueso
2018-05-24 21:11 ` [PATCH 2/6] lib/rhashtable: guarantee initial hashtable allocation Davidlohr Bueso
2018-05-25 3:26 ` Davidlohr Bueso
2018-05-28 9:49 ` Herbert Xu
2018-05-29 17:03 ` Davidlohr Bueso
2018-05-29 18:04 ` Herbert Xu
2018-05-29 17:59 ` Davidlohr Bueso
2018-05-29 18:27 ` Herbert Xu
2018-05-30 14:29 ` Davidlohr Bueso
2018-05-28 10:02 ` Herbert Xu
2018-05-29 16:42 ` Davidlohr Bueso
2018-05-29 18:03 ` Herbert Xu
2018-05-29 17:55 ` Davidlohr Bueso
2018-05-29 18:15 ` Herbert Xu [this message]
2018-05-29 18:05 ` Davidlohr Bueso
2018-05-24 21:11 ` [PATCH 3/6] lib/bucket_locks: use kvmalloc_array() Davidlohr Bueso
2018-05-24 21:37 ` Linus Torvalds
2018-05-29 14:43 ` Michal Hocko
2018-05-29 14:51 ` Michal Hocko
2018-05-29 20:46 ` Linus Torvalds
2018-05-30 7:42 ` Michal Hocko
2018-05-31 15:01 ` Linus Torvalds
2018-05-31 15:29 ` Michal Hocko
2018-05-24 21:11 ` [PATCH 4/6] ipc: get rid of ids->tables_initialized hack Davidlohr Bueso
2018-05-24 21:11 ` [PATCH 5/6] ipc: simplify ipc initialization Davidlohr Bueso
2018-05-24 21:11 ` [PATCH 6/6] lib/test_rhashtable: rhashtable_init() can no longer fail Davidlohr Bueso
2018-05-24 21:41 ` [PATCH -next 0/6] rhashtable: guarantee first allocation Linus Torvalds
2018-05-25 3:34 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529181510.ttlmndxk36rmkwcy@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=guillaume.knispel@supersonicimagine.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=tgraf@suug.ch \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.