From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Dangaard Brouer Subject: Re: [PATCH bpf-next 03/11] bpf: fixup error message from gpl helpers on license mismatch Date: Tue, 29 May 2018 19:16:28 +0200 Message-ID: <20180529191628.3f6aa7dd@redhat.com> References: <20180528004344.3606-1-daniel@iogearbox.net> <20180528004344.3606-4-daniel@iogearbox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: brouer@redhat.com, netdev@vger.kernel.org To: Daniel Borkmann Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:43068 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965010AbeE2RQd (ORCPT ); Tue, 29 May 2018 13:16:33 -0400 In-Reply-To: <20180528004344.3606-4-daniel@iogearbox.net> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 28 May 2018 02:43:36 +0200 Daniel Borkmann wrote: > Stating 'proprietary program' in the error is just silly since it > can also be a different open source license than that which is just > not compatible. > > Reference: https://twitter.com/majek04/status/998531268039102465 > Signed-off-by: Daniel Borkmann > Acked-by: Alexei Starovoitov Acked-by: Jesper Dangaard Brouer Thank you for cleaning up this confusion :-) > --- > kernel/bpf/verifier.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c > index 1fd9667b..4f4786e 100644 > --- a/kernel/bpf/verifier.c > +++ b/kernel/bpf/verifier.c > @@ -2462,7 +2462,7 @@ static int check_helper_call(struct bpf_verifier_env *env, int func_id, int insn > > /* eBPF programs must be GPL compatible to use GPL-ed functions */ > if (!env->prog->gpl_compatible && fn->gpl_only) { > - verbose(env, "cannot call GPL only function from proprietary program\n"); > + verbose(env, "cannot call GPL-restricted function from non-GPL compatible program\n"); > return -EINVAL; > } > -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer