From: Joel Fernandes <joelaf@google.com> To: linux-kernel@vger.kernel.org Cc: kernel-team@android.com, "Joel Fernandes (Google)" <joel@joelfernandes.org>, Boqun Feng <boqun.feng@gmail.com>, Byungchul Park <byungchul.park@lge.com>, Erick Reyes <erickreyes@google.com>, Ingo Molnar <mingo@redhat.com>, Julia Cartwright <julia@ni.com>, linux-kselftest@vger.kernel.org, Masami Hiramatsu <mhiramat@kernel.org>, Mathieu Desnoyers <mathieu.desnoyers@efficios.com>, Namhyung Kim <namhyung@kernel.org>, Paul McKenney <paulmck@linux.vnet.ibm.com>, Peter Zijlstra <peterz@infradead.org>, Shuah Khan <shuah@kernel.org>, Steven Rostedt <rostedt@goodmis.org>, Thomas Glexiner <tglx@linutronix.de>, Todd Kjos <tkjos@google.com>, Tom Zanussi <tom.zanussi@linux.intel.com> Subject: [PATCH v8 0/8] Centralize and unify usage of preempt/irq tracepoints Date: Tue, 29 May 2018 17:04:52 -0700 [thread overview] Message-ID: <20180530000500.257225-1-joel@joelfernandes.org> (raw) From: "Joel Fernandes (Google)" <joel@joelfernandes.org> The preempt/irq tracepoints exist but not everything in the kernel is using it during preempt/irq on/off events. This makes things not work simultaneously (for ex, only either lockdep or irqsoff events can be used at a time). This series is an attempt to solve that, and also results in a nice clean up of the kernel in general. Several ifdefs are simpler, and the design is more unified and better. Also as a result of this, we also speeded up performance all rcuidle tracepoints since their handling is simpler. v7->v8: - Refactored irqsoff tracer probe defines based on Namhyung's suggestions. No functional change. v6->v7: - Added a module to simulate an atomic section, a kselftest to load and and trigger it which verifies the preempt-tracer and this series. - Fixed a new warning after I rebased in early boot, this is because early_boot_irqs_disabled was set too early, I moved it after the lockdep initialization. - added back the softirq fix since it appears it wasn't picked up. - Ran Ingo's locking API selftest suite which are passing with this series. - Mathieu suggested ifdef'ing the tracepoint_synchronize_unregister function incase tracepoints aren't enabled, did that. Joel Fernandes (Google) (7): softirq: reorder trace_softirqs_on to prevent lockdep splat srcu: Add notrace variant of srcu_dereference trace/irqsoff: Split reset into separate functions tracepoint: Make rcuidle tracepoint callers use SRCU tracing: Centralize preemptirq tracepoints and unify their usage lib: Add module to simulate atomic sections for testing preemptoff tracers kselftests: Add tests for the preemptoff and irqsoff tracers Paul McKenney (1): srcu: Add notrace variants of srcu_read_{lock,unlock} include/linux/ftrace.h | 11 +- include/linux/irqflags.h | 11 +- include/linux/lockdep.h | 8 +- include/linux/preempt.h | 2 +- include/linux/srcu.h | 22 ++ include/linux/tracepoint.h | 48 +++- include/trace/events/preemptirq.h | 23 +- init/main.c | 5 +- kernel/locking/lockdep.c | 35 +-- kernel/sched/core.c | 2 +- kernel/softirq.c | 6 +- kernel/trace/Kconfig | 22 +- kernel/trace/Makefile | 2 +- kernel/trace/trace_irqsoff.c | 253 ++++++------------ kernel/trace/trace_preemptirq.c | 71 +++++ kernel/tracepoint.c | 15 +- lib/Kconfig.debug | 8 + lib/Makefile | 1 + lib/test_atomic_sections.c | 79 ++++++ tools/testing/selftests/ftrace/config | 3 + .../test.d/preemptirq/irqsoff_tracer.tc | 74 +++++ 21 files changed, 459 insertions(+), 242 deletions(-) create mode 100644 kernel/trace/trace_preemptirq.c create mode 100644 lib/test_atomic_sections.c create mode 100644 tools/testing/selftests/ftrace/test.d/preemptirq/irqsoff_tracer.tc -- 2.17.0.921.gf22659ad46-goog
WARNING: multiple messages have this Message-ID
From: joelaf at google.com (Joel Fernandes) Subject: [PATCH v8 0/8] Centralize and unify usage of preempt/irq tracepoints Date: Tue, 29 May 2018 17:04:52 -0700 [thread overview] Message-ID: <20180530000500.257225-1-joel@joelfernandes.org> (raw) From: "Joel Fernandes (Google)" <joel at joelfernandes.org> The preempt/irq tracepoints exist but not everything in the kernel is using it during preempt/irq on/off events. This makes things not work simultaneously (for ex, only either lockdep or irqsoff events can be used at a time). This series is an attempt to solve that, and also results in a nice clean up of the kernel in general. Several ifdefs are simpler, and the design is more unified and better. Also as a result of this, we also speeded up performance all rcuidle tracepoints since their handling is simpler. v7->v8: - Refactored irqsoff tracer probe defines based on Namhyung's suggestions. No functional change. v6->v7: - Added a module to simulate an atomic section, a kselftest to load and and trigger it which verifies the preempt-tracer and this series. - Fixed a new warning after I rebased in early boot, this is because early_boot_irqs_disabled was set too early, I moved it after the lockdep initialization. - added back the softirq fix since it appears it wasn't picked up. - Ran Ingo's locking API selftest suite which are passing with this series. - Mathieu suggested ifdef'ing the tracepoint_synchronize_unregister function incase tracepoints aren't enabled, did that. Joel Fernandes (Google) (7): softirq: reorder trace_softirqs_on to prevent lockdep splat srcu: Add notrace variant of srcu_dereference trace/irqsoff: Split reset into separate functions tracepoint: Make rcuidle tracepoint callers use SRCU tracing: Centralize preemptirq tracepoints and unify their usage lib: Add module to simulate atomic sections for testing preemptoff tracers kselftests: Add tests for the preemptoff and irqsoff tracers Paul McKenney (1): srcu: Add notrace variants of srcu_read_{lock,unlock} include/linux/ftrace.h | 11 +- include/linux/irqflags.h | 11 +- include/linux/lockdep.h | 8 +- include/linux/preempt.h | 2 +- include/linux/srcu.h | 22 ++ include/linux/tracepoint.h | 48 +++- include/trace/events/preemptirq.h | 23 +- init/main.c | 5 +- kernel/locking/lockdep.c | 35 +-- kernel/sched/core.c | 2 +- kernel/softirq.c | 6 +- kernel/trace/Kconfig | 22 +- kernel/trace/Makefile | 2 +- kernel/trace/trace_irqsoff.c | 253 ++++++------------ kernel/trace/trace_preemptirq.c | 71 +++++ kernel/tracepoint.c | 15 +- lib/Kconfig.debug | 8 + lib/Makefile | 1 + lib/test_atomic_sections.c | 79 ++++++ tools/testing/selftests/ftrace/config | 3 + .../test.d/preemptirq/irqsoff_tracer.tc | 74 +++++ 21 files changed, 459 insertions(+), 242 deletions(-) create mode 100644 kernel/trace/trace_preemptirq.c create mode 100644 lib/test_atomic_sections.c create mode 100644 tools/testing/selftests/ftrace/test.d/preemptirq/irqsoff_tracer.tc -- 2.17.0.921.gf22659ad46-goog -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID
From: joelaf@google.com (Joel Fernandes) Subject: [PATCH v8 0/8] Centralize and unify usage of preempt/irq tracepoints Date: Tue, 29 May 2018 17:04:52 -0700 [thread overview] Message-ID: <20180530000500.257225-1-joel@joelfernandes.org> (raw) Message-ID: <20180530000452.lSerTsaXgD8jO3tPBaw7uLKMIsFlTbmGQ6O_fgu_ewE@z> (raw) From: "Joel Fernandes (Google)" <joel@joelfernandes.org> The preempt/irq tracepoints exist but not everything in the kernel is using it during preempt/irq on/off events. This makes things not work simultaneously (for ex, only either lockdep or irqsoff events can be used at a time). This series is an attempt to solve that, and also results in a nice clean up of the kernel in general. Several ifdefs are simpler, and the design is more unified and better. Also as a result of this, we also speeded up performance all rcuidle tracepoints since their handling is simpler. v7->v8: - Refactored irqsoff tracer probe defines based on Namhyung's suggestions. No functional change. v6->v7: - Added a module to simulate an atomic section, a kselftest to load and and trigger it which verifies the preempt-tracer and this series. - Fixed a new warning after I rebased in early boot, this is because early_boot_irqs_disabled was set too early, I moved it after the lockdep initialization. - added back the softirq fix since it appears it wasn't picked up. - Ran Ingo's locking API selftest suite which are passing with this series. - Mathieu suggested ifdef'ing the tracepoint_synchronize_unregister function incase tracepoints aren't enabled, did that. Joel Fernandes (Google) (7): softirq: reorder trace_softirqs_on to prevent lockdep splat srcu: Add notrace variant of srcu_dereference trace/irqsoff: Split reset into separate functions tracepoint: Make rcuidle tracepoint callers use SRCU tracing: Centralize preemptirq tracepoints and unify their usage lib: Add module to simulate atomic sections for testing preemptoff tracers kselftests: Add tests for the preemptoff and irqsoff tracers Paul McKenney (1): srcu: Add notrace variants of srcu_read_{lock,unlock} include/linux/ftrace.h | 11 +- include/linux/irqflags.h | 11 +- include/linux/lockdep.h | 8 +- include/linux/preempt.h | 2 +- include/linux/srcu.h | 22 ++ include/linux/tracepoint.h | 48 +++- include/trace/events/preemptirq.h | 23 +- init/main.c | 5 +- kernel/locking/lockdep.c | 35 +-- kernel/sched/core.c | 2 +- kernel/softirq.c | 6 +- kernel/trace/Kconfig | 22 +- kernel/trace/Makefile | 2 +- kernel/trace/trace_irqsoff.c | 253 ++++++------------ kernel/trace/trace_preemptirq.c | 71 +++++ kernel/tracepoint.c | 15 +- lib/Kconfig.debug | 8 + lib/Makefile | 1 + lib/test_atomic_sections.c | 79 ++++++ tools/testing/selftests/ftrace/config | 3 + .../test.d/preemptirq/irqsoff_tracer.tc | 74 +++++ 21 files changed, 459 insertions(+), 242 deletions(-) create mode 100644 kernel/trace/trace_preemptirq.c create mode 100644 lib/test_atomic_sections.c create mode 100644 tools/testing/selftests/ftrace/test.d/preemptirq/irqsoff_tracer.tc -- 2.17.0.921.gf22659ad46-goog -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2018-05-30 0:05 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-30 0:04 Joel Fernandes [this message] 2018-05-30 0:04 ` Joel Fernandes 2018-05-30 0:04 ` joelaf 2018-05-30 0:04 ` [PATCH v8 1/8] softirq: reorder trace_softirqs_on to prevent lockdep splat Joel Fernandes 2018-05-30 0:04 ` Joel Fernandes 2018-05-30 0:04 ` joelaf 2018-05-30 0:04 ` [PATCH v8 2/8] srcu: Add notrace variants of srcu_read_{lock,unlock} Joel Fernandes 2018-05-30 0:04 ` Joel Fernandes 2018-05-30 0:04 ` joelaf 2018-05-30 0:04 ` [PATCH v8 3/8] srcu: Add notrace variant of srcu_dereference Joel Fernandes 2018-05-30 0:04 ` Joel Fernandes 2018-05-30 0:04 ` joelaf 2018-05-30 0:04 ` [PATCH v8 4/8] trace/irqsoff: Split reset into separate functions Joel Fernandes 2018-05-30 0:04 ` Joel Fernandes 2018-05-30 0:04 ` joelaf 2018-05-30 0:04 ` [PATCH v8 5/8] tracepoint: Make rcuidle tracepoint callers use SRCU Joel Fernandes 2018-05-30 0:04 ` Joel Fernandes 2018-05-30 0:04 ` joelaf 2018-05-31 6:50 ` Mathieu Desnoyers 2018-05-31 6:50 ` Mathieu Desnoyers 2018-05-31 6:50 ` mathieu.desnoyers 2018-05-31 17:51 ` Joel Fernandes 2018-05-31 17:51 ` Joel Fernandes 2018-05-31 17:51 ` joel 2018-06-02 1:17 ` Mathieu Desnoyers 2018-06-02 1:17 ` Mathieu Desnoyers 2018-06-02 1:17 ` mathieu.desnoyers 2018-05-30 0:04 ` [PATCH v8 6/8] tracing: Centralize preemptirq tracepoints and unify their usage Joel Fernandes 2018-05-30 0:04 ` Joel Fernandes 2018-05-30 0:04 ` joelaf 2018-05-31 1:56 ` Namhyung Kim 2018-05-31 1:56 ` Namhyung Kim 2018-05-31 1:56 ` namhyung 2018-05-31 6:26 ` Joel Fernandes 2018-05-31 6:26 ` Joel Fernandes 2018-05-31 6:26 ` joel 2018-05-30 0:04 ` [PATCH v8 7/8] lib: Add module to simulate atomic sections for testing preemptoff tracers Joel Fernandes 2018-05-30 0:04 ` Joel Fernandes 2018-05-30 0:04 ` joelaf 2018-06-05 23:01 ` Joel Fernandes 2018-06-05 23:01 ` Joel Fernandes 2018-06-05 23:01 ` joel 2018-06-05 23:53 ` Joel Fernandes 2018-06-05 23:53 ` Joel Fernandes 2018-06-05 23:53 ` joel 2018-06-06 7:48 ` Andy Shevchenko 2018-06-06 7:48 ` Andy Shevchenko 2018-06-06 7:48 ` andriy.shevchenko 2018-05-30 0:05 ` [PATCH v8 8/8] kselftests: Add tests for the preemptoff and irqsoff tracers Joel Fernandes 2018-05-30 0:05 ` Joel Fernandes 2018-05-30 0:05 ` joelaf 2018-05-31 6:45 ` kbuild test robot 2018-05-31 6:45 ` kbuild test robot 2018-05-31 6:45 ` lkp 2018-05-31 6:45 ` [PATCH] kselftests: fix ptr_ret.cocci warnings kbuild test robot 2018-05-31 6:45 ` kbuild test robot 2018-05-31 6:45 ` fengguang.wu 2018-05-31 7:14 ` Joel Fernandes 2018-05-31 7:14 ` Joel Fernandes 2018-05-31 7:14 ` joel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180530000500.257225-1-joel@joelfernandes.org \ --to=joelaf@google.com \ --cc=boqun.feng@gmail.com \ --cc=byungchul.park@lge.com \ --cc=erickreyes@google.com \ --cc=joel@joelfernandes.org \ --cc=julia@ni.com \ --cc=kernel-team@android.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=mathieu.desnoyers@efficios.com \ --cc=mhiramat@kernel.org \ --cc=mingo@redhat.com \ --cc=namhyung@kernel.org \ --cc=paulmck@linux.vnet.ibm.com \ --cc=peterz@infradead.org \ --cc=rostedt@goodmis.org \ --cc=shuah@kernel.org \ --cc=tglx@linutronix.de \ --cc=tkjos@google.com \ --cc=tom.zanussi@linux.intel.com \ --subject='Re: [PATCH v8 0/8] Centralize and unify usage of preempt/irq tracepoints' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.