From: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp> To: Alexei Starovoitov <ast@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, John Fastabend <john.fastabend@gmail.com> Cc: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>, "David S . Miller" <davem@davemloft.net>, Shuah Khan <shuah@kernel.org>, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH bpf v3 5/5] selftests/bpf: test_sockmap, print additional test options Date: Wed, 30 May 2018 14:56:11 +0900 [thread overview] Message-ID: <20180530055611.10216-6-bhole_prashant_q7@lab.ntt.co.jp> (raw) In-Reply-To: <20180530055611.10216-1-bhole_prashant_q7@lab.ntt.co.jp> Print values of test options like apply, cork, start, end so that individual failed tests can be identified for manual run Acked-by: John Fastabend <john.fastabend@gmail.com> Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp> --- tools/testing/selftests/bpf/test_sockmap.c | 28 +++++++++++++++------- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/tools/testing/selftests/bpf/test_sockmap.c b/tools/testing/selftests/bpf/test_sockmap.c index 664f268dc02a..637c6585ff80 100644 --- a/tools/testing/selftests/bpf/test_sockmap.c +++ b/tools/testing/selftests/bpf/test_sockmap.c @@ -869,6 +869,8 @@ static char *test_to_str(int test) #define OPTSTRING 60 static void test_options(char *options) { + char tstr[OPTSTRING]; + memset(options, 0, OPTSTRING); if (txmsg_pass) @@ -881,14 +883,22 @@ static void test_options(char *options) strncat(options, "redir_noisy,", OPTSTRING); if (txmsg_drop) strncat(options, "drop,", OPTSTRING); - if (txmsg_apply) - strncat(options, "apply,", OPTSTRING); - if (txmsg_cork) - strncat(options, "cork,", OPTSTRING); - if (txmsg_start) - strncat(options, "start,", OPTSTRING); - if (txmsg_end) - strncat(options, "end,", OPTSTRING); + if (txmsg_apply) { + snprintf(tstr, OPTSTRING, "apply %d,", txmsg_apply); + strncat(options, tstr, OPTSTRING); + } + if (txmsg_cork) { + snprintf(tstr, OPTSTRING, "cork %d,", txmsg_cork); + strncat(options, tstr, OPTSTRING); + } + if (txmsg_start) { + snprintf(tstr, OPTSTRING, "start %d,", txmsg_start); + strncat(options, tstr, OPTSTRING); + } + if (txmsg_end) { + snprintf(tstr, OPTSTRING, "end %d,", txmsg_end); + strncat(options, tstr, OPTSTRING); + } if (txmsg_ingress) strncat(options, "ingress,", OPTSTRING); if (txmsg_skb) @@ -897,7 +907,7 @@ static void test_options(char *options) static int __test_exec(int cgrp, int test, struct sockmap_options *opt) { - char *options = calloc(60, sizeof(char)); + char *options = calloc(OPTSTRING, sizeof(char)); int err; if (test == SENDPAGE) -- 2.17.0
WARNING: multiple messages have this Message-ID
From: bhole_prashant_q7 at lab.ntt.co.jp (Prashant Bhole) Subject: [PATCH bpf v3 5/5] selftests/bpf: test_sockmap, print additional test options Date: Wed, 30 May 2018 14:56:11 +0900 [thread overview] Message-ID: <20180530055611.10216-6-bhole_prashant_q7@lab.ntt.co.jp> (raw) In-Reply-To: <20180530055611.10216-1-bhole_prashant_q7@lab.ntt.co.jp> Print values of test options like apply, cork, start, end so that individual failed tests can be identified for manual run Acked-by: John Fastabend <john.fastabend at gmail.com> Signed-off-by: Prashant Bhole <bhole_prashant_q7 at lab.ntt.co.jp> --- tools/testing/selftests/bpf/test_sockmap.c | 28 +++++++++++++++------- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/tools/testing/selftests/bpf/test_sockmap.c b/tools/testing/selftests/bpf/test_sockmap.c index 664f268dc02a..637c6585ff80 100644 --- a/tools/testing/selftests/bpf/test_sockmap.c +++ b/tools/testing/selftests/bpf/test_sockmap.c @@ -869,6 +869,8 @@ static char *test_to_str(int test) #define OPTSTRING 60 static void test_options(char *options) { + char tstr[OPTSTRING]; + memset(options, 0, OPTSTRING); if (txmsg_pass) @@ -881,14 +883,22 @@ static void test_options(char *options) strncat(options, "redir_noisy,", OPTSTRING); if (txmsg_drop) strncat(options, "drop,", OPTSTRING); - if (txmsg_apply) - strncat(options, "apply,", OPTSTRING); - if (txmsg_cork) - strncat(options, "cork,", OPTSTRING); - if (txmsg_start) - strncat(options, "start,", OPTSTRING); - if (txmsg_end) - strncat(options, "end,", OPTSTRING); + if (txmsg_apply) { + snprintf(tstr, OPTSTRING, "apply %d,", txmsg_apply); + strncat(options, tstr, OPTSTRING); + } + if (txmsg_cork) { + snprintf(tstr, OPTSTRING, "cork %d,", txmsg_cork); + strncat(options, tstr, OPTSTRING); + } + if (txmsg_start) { + snprintf(tstr, OPTSTRING, "start %d,", txmsg_start); + strncat(options, tstr, OPTSTRING); + } + if (txmsg_end) { + snprintf(tstr, OPTSTRING, "end %d,", txmsg_end); + strncat(options, tstr, OPTSTRING); + } if (txmsg_ingress) strncat(options, "ingress,", OPTSTRING); if (txmsg_skb) @@ -897,7 +907,7 @@ static void test_options(char *options) static int __test_exec(int cgrp, int test, struct sockmap_options *opt) { - char *options = calloc(60, sizeof(char)); + char *options = calloc(OPTSTRING, sizeof(char)); int err; if (test == SENDPAGE) -- 2.17.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID
From: bhole_prashant_q7@lab.ntt.co.jp (Prashant Bhole) Subject: [PATCH bpf v3 5/5] selftests/bpf: test_sockmap, print additional test options Date: Wed, 30 May 2018 14:56:11 +0900 [thread overview] Message-ID: <20180530055611.10216-6-bhole_prashant_q7@lab.ntt.co.jp> (raw) Message-ID: <20180530055611.6YLq0_KCwWhCAcevcZEUXIez1tZsjojNpp_nTl3nHxA@z> (raw) In-Reply-To: <20180530055611.10216-1-bhole_prashant_q7@lab.ntt.co.jp> Print values of test options like apply, cork, start, end so that individual failed tests can be identified for manual run Acked-by: John Fastabend <john.fastabend at gmail.com> Signed-off-by: Prashant Bhole <bhole_prashant_q7 at lab.ntt.co.jp> --- tools/testing/selftests/bpf/test_sockmap.c | 28 +++++++++++++++------- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/tools/testing/selftests/bpf/test_sockmap.c b/tools/testing/selftests/bpf/test_sockmap.c index 664f268dc02a..637c6585ff80 100644 --- a/tools/testing/selftests/bpf/test_sockmap.c +++ b/tools/testing/selftests/bpf/test_sockmap.c @@ -869,6 +869,8 @@ static char *test_to_str(int test) #define OPTSTRING 60 static void test_options(char *options) { + char tstr[OPTSTRING]; + memset(options, 0, OPTSTRING); if (txmsg_pass) @@ -881,14 +883,22 @@ static void test_options(char *options) strncat(options, "redir_noisy,", OPTSTRING); if (txmsg_drop) strncat(options, "drop,", OPTSTRING); - if (txmsg_apply) - strncat(options, "apply,", OPTSTRING); - if (txmsg_cork) - strncat(options, "cork,", OPTSTRING); - if (txmsg_start) - strncat(options, "start,", OPTSTRING); - if (txmsg_end) - strncat(options, "end,", OPTSTRING); + if (txmsg_apply) { + snprintf(tstr, OPTSTRING, "apply %d,", txmsg_apply); + strncat(options, tstr, OPTSTRING); + } + if (txmsg_cork) { + snprintf(tstr, OPTSTRING, "cork %d,", txmsg_cork); + strncat(options, tstr, OPTSTRING); + } + if (txmsg_start) { + snprintf(tstr, OPTSTRING, "start %d,", txmsg_start); + strncat(options, tstr, OPTSTRING); + } + if (txmsg_end) { + snprintf(tstr, OPTSTRING, "end %d,", txmsg_end); + strncat(options, tstr, OPTSTRING); + } if (txmsg_ingress) strncat(options, "ingress,", OPTSTRING); if (txmsg_skb) @@ -897,7 +907,7 @@ static void test_options(char *options) static int __test_exec(int cgrp, int test, struct sockmap_options *opt) { - char *options = calloc(60, sizeof(char)); + char *options = calloc(OPTSTRING, sizeof(char)); int err; if (test == SENDPAGE) -- 2.17.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-05-30 5:57 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-30 5:56 [PATCH bpf v3 0/5] fix test_sockmap Prashant Bhole 2018-05-30 5:56 ` Prashant Bhole 2018-05-30 5:56 ` bhole_prashant_q7 2018-05-30 5:56 ` [PATCH bpf v3 1/5] selftests/bpf: test_sockmap, check test failure Prashant Bhole 2018-05-30 5:56 ` Prashant Bhole 2018-05-30 5:56 ` bhole_prashant_q7 2018-05-30 13:26 ` John Fastabend 2018-05-30 13:26 ` John Fastabend 2018-05-30 13:26 ` john.fastabend 2018-05-30 5:56 ` [PATCH bpf v3 2/5] selftests/bpf: test_sockmap, join cgroup in selftest mode Prashant Bhole 2018-05-30 5:56 ` Prashant Bhole 2018-05-30 5:56 ` bhole_prashant_q7 2018-05-30 5:56 ` [PATCH bpf v3 3/5] selftests/bpf: test_sockmap, fix test timeout Prashant Bhole 2018-05-30 5:56 ` Prashant Bhole 2018-05-30 5:56 ` bhole_prashant_q7 2018-05-30 13:31 ` John Fastabend 2018-05-30 13:31 ` John Fastabend 2018-05-30 13:31 ` john.fastabend 2018-05-30 19:29 ` Alexei Starovoitov 2018-05-30 19:29 ` Alexei Starovoitov 2018-05-30 19:29 ` alexei.starovoitov 2018-05-30 19:59 ` John Fastabend 2018-05-30 19:59 ` John Fastabend 2018-05-30 19:59 ` john.fastabend 2018-05-31 4:13 ` Prashant Bhole 2018-05-31 4:13 ` Prashant Bhole 2018-05-31 4:13 ` bhole_prashant_q7 2018-06-01 14:03 ` John Fastabend 2018-06-01 14:03 ` John Fastabend 2018-06-01 14:03 ` john.fastabend 2018-05-30 5:56 ` [PATCH bpf v3 4/5] selftests/bpf: test_sockmap, fix data verification Prashant Bhole 2018-05-30 5:56 ` Prashant Bhole 2018-05-30 5:56 ` bhole_prashant_q7 2018-05-30 5:56 ` Prashant Bhole [this message] 2018-05-30 5:56 ` [PATCH bpf v3 5/5] selftests/bpf: test_sockmap, print additional test options Prashant Bhole 2018-05-30 5:56 ` bhole_prashant_q7 2018-05-30 13:32 ` [PATCH bpf v3 0/5] fix test_sockmap John Fastabend 2018-05-30 13:32 ` John Fastabend 2018-05-30 13:32 ` john.fastabend
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180530055611.10216-6-bhole_prashant_q7@lab.ntt.co.jp \ --to=bhole_prashant_q7@lab.ntt.co.jp \ --cc=ast@kernel.org \ --cc=daniel@iogearbox.net \ --cc=davem@davemloft.net \ --cc=john.fastabend@gmail.com \ --cc=linux-kselftest@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=shuah@kernel.org \ --subject='Re: [PATCH bpf v3 5/5] selftests/bpf: test_sockmap, print additional test options' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.