From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.bemta8.messagelabs.com ([216.82.243.203]:39170 "EHLO mail1.bemta8.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965127AbeE3JdI (ORCPT ); Wed, 30 May 2018 05:33:08 -0400 From: Tokunori Ikegami To: Boris Brezillon Cc: Tokunori Ikegami , Chris Packham , Brian Norris , David Woodhouse , Boris Brezillon , Marek Vasut , Richard Weinberger , Cyrille Pitchen , linux-mtd@lists.infradead.org, stable@vger.kernel.org Subject: [PATCH v8 1/5] mtd: cfi_cmdset_0002: Change write buffer to check correct value Date: Wed, 30 May 2018 18:32:26 +0900 Message-Id: <20180530093230.3240-2-ikegami@allied-telesis.co.jp> In-Reply-To: <20180530093230.3240-1-ikegami@allied-telesis.co.jp> References: <20180530093230.3240-1-ikegami@allied-telesis.co.jp> Sender: stable-owner@vger.kernel.org List-ID: For the word write it is checked if the chip has the correct value. But it is not checked for the write buffer as only checked if ready. To make sure for the write buffer change to check the value. It is enough as this patch is only checking the last written word. Since it is described by data sheets to check the operation status. Signed-off-by: Tokunori Ikegami Reviewed-by: Joakim Tjernlund Cc: Chris Packham Cc: Brian Norris Cc: David Woodhouse Cc: Boris Brezillon Cc: Marek Vasut Cc: Richard Weinberger Cc: Cyrille Pitchen Cc: linux-mtd@lists.infradead.org Cc: stable@vger.kernel.org --- Changes since v7: - None. Changes since v6: - Change Cc: Joakim Tjernlund tag as Reviewed-by: tag. - Add Cc: stable tag. Changes since v5: - None since the v4 change is just combined as same series by v6. Changes since v3: - Removed to check if chip ready. Changes since v2: - Just updated the patch to add v3 version into subject and desribe a changelog. Changes since v1: - Just changed to add Brian as Cc and the patch is sent to Boris-san as To Changes since v0: - Changed Split the part to change write buffer from the v1 patch drivers/mtd/chips/cfi_cmdset_0002.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c index e397b80e40cc..1d6be8c63d39 100644 --- a/drivers/mtd/chips/cfi_cmdset_0002.c +++ b/drivers/mtd/chips/cfi_cmdset_0002.c @@ -1879,7 +1879,7 @@ static int __xipram do_write_buffer(struct map_info *map, struct flchip *chip, if (time_after(jiffies, timeo) && !chip_ready(map, adr)) break; - if (chip_ready(map, adr)) { + if (chip_good(map, adr, datum)) { xip_enable(map, chip, adr); goto op_done; } -- 2.16.1