From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753796AbeEaEU0 (ORCPT ); Thu, 31 May 2018 00:20:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:47494 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750943AbeEaEUY (ORCPT ); Thu, 31 May 2018 00:20:24 -0400 Date: Wed, 30 May 2018 23:20:20 -0500 From: Bjorn Helgaas To: honghui.zhang@mediatek.com Cc: lorenzo.pieralisi@arm.com, marc.zyngier@arm.com, bhelgaas@google.com, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, yingjoe.chen@mediatek.com, eddie.huang@mediatek.com, ryder.lee@mediatek.com, youlin.pei@mediatek.com, hongkun.cao@mediatek.com, sean.wang@mediatek.com, xinping.qian@mediatek.com, yt.shen@mediatek.com, yong.wu@mediatek.com Subject: Re: [PATCH] PCI: mediatek: Add system pm support for MT2712 Message-ID: <20180531042020.GQ39853@bhelgaas-glaptop.roam.corp.google.com> References: <1527647736-19986-1-git-send-email-honghui.zhang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1527647736-19986-1-git-send-email-honghui.zhang@mediatek.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 30, 2018 at 10:35:36AM +0800, honghui.zhang@mediatek.com wrote: > From: Honghui Zhang > > The MTCMOS of PCIe Host for MT2712 will be off when system suspend, and all > the internel control register will be reset after system resume. The PCIe > link should be re-established and the related control register values should > be re-set after system resume. > > Signed-off-by: Honghui Zhang > CC: Ryder Lee > --- > drivers/pci/host/pcie-mediatek.c | 82 ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 82 insertions(+) > > diff --git a/drivers/pci/host/pcie-mediatek.c b/drivers/pci/host/pcie-mediatek.c > index dabf1086..60f98d92 100644 > --- a/drivers/pci/host/pcie-mediatek.c > +++ b/drivers/pci/host/pcie-mediatek.c > @@ -132,12 +132,14 @@ struct mtk_pcie_port; > /** > * struct mtk_pcie_soc - differentiate between host generations > * @need_fix_class_id: whether this host's class ID needed to be fixed or not > + * @pm_support: whether the host's MTCMOS will be off when suspend > * @ops: pointer to configuration access functions > * @startup: pointer to controller setting functions > * @setup_irq: pointer to initialize IRQ functions > */ > struct mtk_pcie_soc { > bool need_fix_class_id; > + bool pm_support; > struct pci_ops *ops; > int (*startup)(struct mtk_pcie_port *port); > int (*setup_irq)(struct mtk_pcie_port *port, struct device_node *node); > @@ -1179,12 +1181,91 @@ static int mtk_pcie_probe(struct platform_device *pdev) > return err; > } > > +static int __maybe_unused mtk_pcie_suspend_noirq(struct device *dev) > +{ > + struct platform_device *pdev; > + struct mtk_pcie *pcie; > + struct mtk_pcie_port *port; > + const struct mtk_pcie_soc *soc; > + > + pdev = to_platform_device(dev); > + pcie = platform_get_drvdata(pdev); > + soc = pcie->soc; > + if (!soc->pm_support) > + return 0; > + > + list_for_each_entry(port, &pcie->ports, list) { > + clk_disable_unprepare(port->ahb_ck); > + clk_disable_unprepare(port->sys_ck); > + phy_power_off(port->phy); > + } > + > + return 0; > +} > + > +static int __maybe_unused mtk_pcie_resume_noirq(struct device *dev) I don't really like the __maybe_unused annotations. Looking at the other users of SET_NOIRQ_SYSTEM_SLEEP_PM_OPS, I think a small majority of them wrap the function definitions in #ifdef CONFIG_PM_SLEEP instead of using __maybe_unused. That's also a bit ugly, but has the advantage of truly omitting the definitions when they're not needed. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Wed, 30 May 2018 23:20:20 -0500 From: Bjorn Helgaas To: honghui.zhang@mediatek.com Subject: Re: [PATCH] PCI: mediatek: Add system pm support for MT2712 Message-ID: <20180531042020.GQ39853@bhelgaas-glaptop.roam.corp.google.com> References: <1527647736-19986-1-git-send-email-honghui.zhang@mediatek.com> MIME-Version: 1.0 In-Reply-To: <1527647736-19986-1-git-send-email-honghui.zhang@mediatek.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: youlin.pei@mediatek.com, devicetree@vger.kernel.org, hongkun.cao@mediatek.com, lorenzo.pieralisi@arm.com, marc.zyngier@arm.com, linux-pci@vger.kernel.org, sean.wang@mediatek.com, yong.wu@mediatek.com, linux-kernel@vger.kernel.org, yt.shen@mediatek.com, matthias.bgg@gmail.com, ryder.lee@mediatek.com, linux-mediatek@lists.infradead.org, xinping.qian@mediatek.com, bhelgaas@google.com, yingjoe.chen@mediatek.com, eddie.huang@mediatek.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: On Wed, May 30, 2018 at 10:35:36AM +0800, honghui.zhang@mediatek.com wrote: > From: Honghui Zhang > > The MTCMOS of PCIe Host for MT2712 will be off when system suspend, and all > the internel control register will be reset after system resume. The PCIe > link should be re-established and the related control register values should > be re-set after system resume. > > Signed-off-by: Honghui Zhang > CC: Ryder Lee > --- > drivers/pci/host/pcie-mediatek.c | 82 ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 82 insertions(+) > > diff --git a/drivers/pci/host/pcie-mediatek.c b/drivers/pci/host/pcie-mediatek.c > index dabf1086..60f98d92 100644 > --- a/drivers/pci/host/pcie-mediatek.c > +++ b/drivers/pci/host/pcie-mediatek.c > @@ -132,12 +132,14 @@ struct mtk_pcie_port; > /** > * struct mtk_pcie_soc - differentiate between host generations > * @need_fix_class_id: whether this host's class ID needed to be fixed or not > + * @pm_support: whether the host's MTCMOS will be off when suspend > * @ops: pointer to configuration access functions > * @startup: pointer to controller setting functions > * @setup_irq: pointer to initialize IRQ functions > */ > struct mtk_pcie_soc { > bool need_fix_class_id; > + bool pm_support; > struct pci_ops *ops; > int (*startup)(struct mtk_pcie_port *port); > int (*setup_irq)(struct mtk_pcie_port *port, struct device_node *node); > @@ -1179,12 +1181,91 @@ static int mtk_pcie_probe(struct platform_device *pdev) > return err; > } > > +static int __maybe_unused mtk_pcie_suspend_noirq(struct device *dev) > +{ > + struct platform_device *pdev; > + struct mtk_pcie *pcie; > + struct mtk_pcie_port *port; > + const struct mtk_pcie_soc *soc; > + > + pdev = to_platform_device(dev); > + pcie = platform_get_drvdata(pdev); > + soc = pcie->soc; > + if (!soc->pm_support) > + return 0; > + > + list_for_each_entry(port, &pcie->ports, list) { > + clk_disable_unprepare(port->ahb_ck); > + clk_disable_unprepare(port->sys_ck); > + phy_power_off(port->phy); > + } > + > + return 0; > +} > + > +static int __maybe_unused mtk_pcie_resume_noirq(struct device *dev) I don't really like the __maybe_unused annotations. Looking at the other users of SET_NOIRQ_SYSTEM_SLEEP_PM_OPS, I think a small majority of them wrap the function definitions in #ifdef CONFIG_PM_SLEEP instead of using __maybe_unused. That's also a bit ugly, but has the advantage of truly omitting the definitions when they're not needed. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: helgaas@kernel.org (Bjorn Helgaas) Date: Wed, 30 May 2018 23:20:20 -0500 Subject: [PATCH] PCI: mediatek: Add system pm support for MT2712 In-Reply-To: <1527647736-19986-1-git-send-email-honghui.zhang@mediatek.com> References: <1527647736-19986-1-git-send-email-honghui.zhang@mediatek.com> Message-ID: <20180531042020.GQ39853@bhelgaas-glaptop.roam.corp.google.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, May 30, 2018 at 10:35:36AM +0800, honghui.zhang at mediatek.com wrote: > From: Honghui Zhang > > The MTCMOS of PCIe Host for MT2712 will be off when system suspend, and all > the internel control register will be reset after system resume. The PCIe > link should be re-established and the related control register values should > be re-set after system resume. > > Signed-off-by: Honghui Zhang > CC: Ryder Lee > --- > drivers/pci/host/pcie-mediatek.c | 82 ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 82 insertions(+) > > diff --git a/drivers/pci/host/pcie-mediatek.c b/drivers/pci/host/pcie-mediatek.c > index dabf1086..60f98d92 100644 > --- a/drivers/pci/host/pcie-mediatek.c > +++ b/drivers/pci/host/pcie-mediatek.c > @@ -132,12 +132,14 @@ struct mtk_pcie_port; > /** > * struct mtk_pcie_soc - differentiate between host generations > * @need_fix_class_id: whether this host's class ID needed to be fixed or not > + * @pm_support: whether the host's MTCMOS will be off when suspend > * @ops: pointer to configuration access functions > * @startup: pointer to controller setting functions > * @setup_irq: pointer to initialize IRQ functions > */ > struct mtk_pcie_soc { > bool need_fix_class_id; > + bool pm_support; > struct pci_ops *ops; > int (*startup)(struct mtk_pcie_port *port); > int (*setup_irq)(struct mtk_pcie_port *port, struct device_node *node); > @@ -1179,12 +1181,91 @@ static int mtk_pcie_probe(struct platform_device *pdev) > return err; > } > > +static int __maybe_unused mtk_pcie_suspend_noirq(struct device *dev) > +{ > + struct platform_device *pdev; > + struct mtk_pcie *pcie; > + struct mtk_pcie_port *port; > + const struct mtk_pcie_soc *soc; > + > + pdev = to_platform_device(dev); > + pcie = platform_get_drvdata(pdev); > + soc = pcie->soc; > + if (!soc->pm_support) > + return 0; > + > + list_for_each_entry(port, &pcie->ports, list) { > + clk_disable_unprepare(port->ahb_ck); > + clk_disable_unprepare(port->sys_ck); > + phy_power_off(port->phy); > + } > + > + return 0; > +} > + > +static int __maybe_unused mtk_pcie_resume_noirq(struct device *dev) I don't really like the __maybe_unused annotations. Looking at the other users of SET_NOIRQ_SYSTEM_SLEEP_PM_OPS, I think a small majority of them wrap the function definitions in #ifdef CONFIG_PM_SLEEP instead of using __maybe_unused. That's also a bit ugly, but has the advantage of truly omitting the definitions when they're not needed.