From: kbuild test robot <lkp@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, kbuild-all@01.org
Subject: Re: [PATCH 4/5] drm/i915: After reset on sanitization, reset the engine backends
Date: Thu, 31 May 2018 22:34:20 +0800 [thread overview]
Message-ID: <201805312017.HOGKW8DF%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180529132922.6831-4-chris@chris-wilson.co.uk>
[-- Attachment #1: Type: text/plain, Size: 4658 bytes --]
Hi Chris,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20180530]
[cannot apply to v4.17-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-Remove-stale-asserts-from-i915_gem_find_active_request/20180531-202540
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-x006-201821 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
In file included from include/linux/kernel.h:10:0,
from include/linux/list.h:9,
from include/linux/agp_backend.h:33,
from include/drm/drmP.h:35,
from drivers/gpu//drm/i915/i915_gem.c:28:
drivers/gpu//drm/i915/i915_gem.c: In function 'i915_gem_sanitize':
drivers/gpu//drm/i915/i915_gem.c:5035:15: error: 'struct intel_engine_cs' has no member named 'reset'; did you mean 'reset_hw'?
if (engine->reset.reset)
^
include/linux/compiler.h:58:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> drivers/gpu//drm/i915/i915_gem.c:5035:3: note: in expansion of macro 'if'
if (engine->reset.reset)
^~
drivers/gpu//drm/i915/i915_gem.c:5035:15: error: 'struct intel_engine_cs' has no member named 'reset'; did you mean 'reset_hw'?
if (engine->reset.reset)
^
include/linux/compiler.h:58:42: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> drivers/gpu//drm/i915/i915_gem.c:5035:3: note: in expansion of macro 'if'
if (engine->reset.reset)
^~
drivers/gpu//drm/i915/i915_gem.c:5035:15: error: 'struct intel_engine_cs' has no member named 'reset'; did you mean 'reset_hw'?
if (engine->reset.reset)
^
include/linux/compiler.h:69:16: note: in definition of macro '__trace_if'
______r = !!(cond); \
^~~~
>> drivers/gpu//drm/i915/i915_gem.c:5035:3: note: in expansion of macro 'if'
if (engine->reset.reset)
^~
drivers/gpu//drm/i915/i915_gem.c:5036:12: error: 'struct intel_engine_cs' has no member named 'reset'; did you mean 'reset_hw'?
engine->reset.reset(engine, NULL);
^~~~~
reset_hw
vim +/if +5035 drivers/gpu//drm/i915/i915_gem.c
5000
5001 void i915_gem_sanitize(struct drm_i915_private *i915)
5002 {
5003 struct intel_engine_cs *engine;
5004 enum intel_engine_id id;
5005
5006 GEM_TRACE("\n");
5007
5008 mutex_lock(&i915->drm.struct_mutex);
5009
5010 intel_runtime_pm_get(i915);
5011 intel_uncore_forcewake_get(i915, FORCEWAKE_ALL);
5012
5013 /*
5014 * As we have just resumed the machine and woken the device up from
5015 * deep PCI sleep (presumably D3_cold), assume the HW has been reset
5016 * back to defaults, recovering from whatever wedged state we left it
5017 * in and so worth trying to use the device once more.
5018 */
5019 if (i915_terminally_wedged(&i915->gpu_error))
5020 i915_gem_unset_wedged(i915);
5021
5022 /*
5023 * If we inherit context state from the BIOS or earlier occupants
5024 * of the GPU, the GPU may be in an inconsistent state when we
5025 * try to take over. The only way to remove the earlier state
5026 * is by resetting. However, resetting on earlier gen is tricky as
5027 * it may impact the display and we are uncertain about the stability
5028 * of the reset, so this could be applied to even earlier gen.
5029 */
5030 if (INTEL_GEN(i915) >= 5 && intel_has_gpu_reset(i915))
5031 WARN_ON(intel_gpu_reset(i915, ALL_ENGINES));
5032
5033 /* Reset the submission backend after resume as well as the GPU reset */
5034 for_each_engine(engine, i915, id) {
> 5035 if (engine->reset.reset)
5036 engine->reset.reset(engine, NULL);
5037 }
5038
5039 intel_uncore_forcewake_put(i915, FORCEWAKE_ALL);
5040 intel_runtime_pm_put(i915);
5041
5042 i915_gem_contexts_lost(i915);
5043 mutex_unlock(&i915->drm.struct_mutex);
5044 }
5045
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 24670 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-05-31 14:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 13:29 [PATCH 1/5] drm/i915: Remove stale asserts from i915_gem_find_active_request() Chris Wilson
2018-05-29 13:29 ` [PATCH 2/5] drm/i915: Switch to kernel context before idling at runtime Chris Wilson
2018-05-29 13:29 ` [PATCH 3/5] drm/i915: "Race-to-idle" after switching to the kernel context Chris Wilson
2018-05-29 13:29 ` [PATCH 4/5] drm/i915: After reset on sanitization, reset the engine backends Chris Wilson
2018-05-31 13:11 ` kbuild test robot
2018-05-31 14:34 ` kbuild test robot [this message]
2018-05-29 13:29 ` [PATCH 5/5] drm/i915: Only sanitize GEM from late suspend Chris Wilson
2018-05-30 16:56 ` Tvrtko Ursulin
2018-05-30 17:07 ` Chris Wilson
2018-05-29 13:47 ` ✗ Fi.CI.SPARSE: warning for series starting with [1/5] drm/i915: Remove stale asserts from i915_gem_find_active_request() Patchwork
2018-05-29 14:02 ` ✓ Fi.CI.BAT: success " Patchwork
2018-05-29 17:53 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-05-29 17:57 ` Chris Wilson
2018-05-30 10:43 ` [PATCH 1/5] " Tvrtko Ursulin
2018-05-30 10:55 ` Chris Wilson
2018-05-30 11:01 ` Tvrtko Ursulin
2018-05-30 11:14 ` Chris Wilson
2018-05-30 16:06 ` ✗ Fi.CI.BAT: failure for series starting with [1/5] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201805312017.HOGKW8DF%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kbuild-all@01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.