From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 1D9C51CF1D5 for ; Fri, 1 Jun 2018 09:18:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 1AFC889C5E for ; Fri, 1 Jun 2018 09:18:30 +0000 (UTC) Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id v85ztKE14Yei for ; Fri, 1 Jun 2018 09:18:29 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by hemlock.osuosl.org (Postfix) with ESMTPS id BA87D89C2D for ; Fri, 1 Jun 2018 09:18:29 +0000 (UTC) Date: Fri, 1 Jun 2018 11:18:07 +0200 From: Greg KH Subject: Re: [PATCH v2] staging: mt7621-gpio: update #interrupt-cells for the gpio node Message-ID: <20180601091807.GA9257@kroah.com> References: <87po1eujcg.fsf@notabene.neil.brown.name> <1527655848-18472-1-git-send-email-sergio.paracuellos@gmail.com> <87vab4tmwd.fsf@notabene.neil.brown.name> <20180531122049.GA15307@foobar> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180531122049.GA15307@foobar> List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Sergio Paracuellos Cc: NeilBrown , driverdev-devel@linuxdriverproject.org On Thu, May 31, 2018 at 02:20:49PM +0200, Sergio Paracuellos wrote: > On Thu, May 31, 2018 at 03:27:46PM +1000, NeilBrown wrote: > > On Wed, May 30 2018, Sergio Paracuellos wrote: > > > > > Most gpio chips have two cells for interrupts and this should be also. > > > Set this property in the device tree accordly fixing this up. In order > > > to make this working properly the xlate function for the irq_domain must > > > be updated to use the 'irq_domain_xlate_twocell' one in the driver. > > > One more minimal change is needed two refer gpio's interrupt-parent from > > > other nodes which is to add new 'gpio' label in the device tree. > > > > > > Signed-off-by: Sergio Paracuellos > > > > Reviewed-by: NeilBrown > > > > Thanks, > > NeilBrown > > Thank you very much for all of these series review, Neil. I'm really confused about what patches in this series I should, and should not apply. Can you resend it in one series, with Neil's reviewed-by added so I know what to apply? thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel