From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: NeilBrown <neil@brown.name>, driverdev-devel@linuxdriverproject.org
Subject: Re: [PATCH v2] staging: mt7621-gpio: update #interrupt-cells for the gpio node
Date: Fri, 1 Jun 2018 11:36:15 +0200 [thread overview]
Message-ID: <20180601093615.GA1373@foobar> (raw)
In-Reply-To: <20180601091807.GA9257@kroah.com>
On Fri, Jun 01, 2018 at 11:18:07AM +0200, Greg KH wrote:
> On Thu, May 31, 2018 at 02:20:49PM +0200, Sergio Paracuellos wrote:
> > On Thu, May 31, 2018 at 03:27:46PM +1000, NeilBrown wrote:
> > > On Wed, May 30 2018, Sergio Paracuellos wrote:
> > >
> > > > Most gpio chips have two cells for interrupts and this should be also.
> > > > Set this property in the device tree accordly fixing this up. In order
> > > > to make this working properly the xlate function for the irq_domain must
> > > > be updated to use the 'irq_domain_xlate_twocell' one in the driver.
> > > > One more minimal change is needed two refer gpio's interrupt-parent from
> > > > other nodes which is to add new 'gpio' label in the device tree.
> > > >
> > > > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> > >
> > > Reviewed-by: NeilBrown <neil@brown.name>
> > >
> > > Thanks,
> > > NeilBrown
> >
> > Thank you very much for all of these series review, Neil.
>
> I'm really confused about what patches in this series I should, and
> should not apply. Can you resend it in one series, with Neil's
> reviewed-by added so I know what to apply?
For sure, Greg. I have just sent those.
>
> thanks,
>
> greg k-h
Best regards,
Sergio Paracuellos
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-06-01 9:36 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 16:54 [PATCH 0/7] staging: mt7621-gpio: cleanups to move this driver out of staging Sergio Paracuellos
2018-05-25 16:54 ` [PATCH 1/7] staging: mt7621-gpio: rename MTK_MAX_BANK into MTK_BANK_CNT Sergio Paracuellos
2018-05-25 16:54 ` [PATCH 2/7] staging: mt7621-gpio: use module_platform_driver() instead subsys initcall Sergio Paracuellos
2018-05-25 16:54 ` [PATCH 3/7] staging: mt7621-gpio: fix masks for gpio pin Sergio Paracuellos
2018-05-25 16:54 ` [PATCH 4/7] staging: mt7621-gpio: avoid locking in mediatek_gpio_get_direction Sergio Paracuellos
2018-05-25 16:54 ` [PATCH 5/7] staging: mt7621-gpio: change lock place in irq mask and unmask functions Sergio Paracuellos
2018-05-25 16:54 ` [PATCH 6/7] staging: mt7621-dts: add missing properties to gpio node Sergio Paracuellos
2018-05-25 16:54 ` [PATCH 7/7] staging: mt7621-gpio: dt-bindings: complete documentation for the gpio Sergio Paracuellos
2018-05-27 23:09 ` [PATCH 0/7] staging: mt7621-gpio: cleanups to move this driver out of staging NeilBrown
2018-05-28 4:55 ` Sergio Paracuellos
2018-05-29 4:58 ` [PATCH 0/6] staging: mt7621-gpio: last cleanups Sergio Paracuellos
2018-05-29 4:58 ` [PATCH 1/6] staging: mt7621-dts: fix property #interrupt-cells for the gpio node Sergio Paracuellos
2018-05-29 23:34 ` NeilBrown
2018-05-30 4:50 ` [PATCH v2] staging: mt7621-gpio: update " Sergio Paracuellos
2018-05-31 5:27 ` NeilBrown
2018-05-31 12:20 ` Sergio Paracuellos
2018-06-01 9:18 ` Greg KH
2018-06-01 9:30 ` [RESEND PATCH 1/6] " Sergio Paracuellos
2018-06-01 9:30 ` [RESEND PATCH 2/6] staging: mt7621-gpio: dt-bindings: update documentation for #interrupt-cells property Sergio Paracuellos
2018-06-01 9:30 ` [RESEND PATCH 3/6] staging: mt7621-gpio: change 'to_mediatek_gpio' to make just a one line return Sergio Paracuellos
2018-06-01 9:30 ` [RESEND PATCH 4/6] staging: mt7621-gpio: use GPIOF_DIR_OUT and GPIOF_DIR_IN macros instead of custom values Sergio Paracuellos
2018-06-01 9:30 ` [RESEND PATCH 5/6] staging: mt7621-gpio: change gc_map to don't use pointers Sergio Paracuellos
2018-06-01 9:30 ` [RESEND PATCH 6/6] staging: mt7621-gpio: reorder includes alphabetically Sergio Paracuellos
2018-06-01 9:36 ` Sergio Paracuellos [this message]
2018-05-30 4:54 ` [PATCH 1/6] staging: mt7621-dts: fix property #interrupt-cells for the gpio node Sergio Paracuellos
2018-05-29 4:58 ` [PATCH 2/6] staging: mt7621-gpio: dt-bindings: update documentation for #interrupt-cells property Sergio Paracuellos
2018-05-29 4:58 ` [PATCH 3/6] staging: mt7621-gpio: change 'to_mediatek_gpio' to make just a one line return Sergio Paracuellos
2018-05-29 4:58 ` [PATCH 4/6] staging: mt7621-gpio: use GPIOF_DIR_OUT and GPIOF_DIR_IN macros instead of custom values Sergio Paracuellos
2018-05-29 4:58 ` [PATCH 5/6] staging: mt7621-gpio: change gc_map to don't use pointers Sergio Paracuellos
2018-05-29 4:58 ` [PATCH 6/6] staging: mt7621-gpio: reorder includes alphabetically Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180601093615.GA1373@foobar \
--to=sergio.paracuellos@gmail.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=neil@brown.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.