All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH 1/1] tst_test.sh: TCONF on basename error when setting TST_ID
Date: Fri, 1 Jun 2018 11:48:03 +0200	[thread overview]
Message-ID: <20180601094803.mvjyf7pwpc4ioe7x@dell5510> (raw)
In-Reply-To: <CAEemH2cGQt4SG4ec+-=ppSF6sywzZhhsK2aZ4fzMT8oObgC93Q@mail.gmail.com>

Hi,

> On Wed, May 2, 2018 at 10:45 PM, Petr Vorel <pvorel@suse.cz> wrote:

> > ...
> > >  if [ -z "$TST_ID" ]; then
> > > -     filename=$(basename $0)
> > > +     filename=$(basename $0) || \
> > > +             tst_brk TBROK "Failed to set TST_ID from \$0 ('$0'), fix
> > it with setting TST_ID before sourcing tst_test.sh"
> >                 ^
> > Here is going to be TCONF.


> Looks good to me.

Pushed.
Li, thanks for your review.


Kind regards,
Petr

      reply	other threads:[~2018-06-01  9:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-02 13:45 [LTP] [RFC PATCH 1/1] tst_test.sh: TCONF on basename error when setting TST_ID Petr Vorel
2018-05-02 14:45 ` Petr Vorel
2018-05-03  7:54   ` Li Wang
2018-06-01  9:48     ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180601094803.mvjyf7pwpc4ioe7x@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.