From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Date: Fri, 1 Jun 2018 13:05:23 +0200 Subject: [U-Boot] [PATCH] sunxi: use CONFIG_DEFAULT_FDT_FILE everywhere In-Reply-To: <20180601005916.16277-1-mkelly@xevo.com> References: <20180601005916.16277-1-mkelly@xevo.com> Message-ID: <20180601110523.vsrbsa4tvwnlwcic@flea> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, May 31, 2018 at 05:59:16PM -0700, Martin Kelly wrote: > Currently, sunxi-common.h ignores CONFIG_DEFAULT_FDT_FILE and assumes > the kernel fdtfile and the u-boot devicetree names are the same. > Although this is typically the case, sometimes you might want to > customize one of these differently, so it's useful to allow them to be > different. > > Fix this to use only CONFIG_DEFAULT_FDT_FILE as other boards do, and set > CONFIG_DEFAULT_FDT_FILE in board files to be the same as the current > fdtfile= setting. > > Signed-off-by: Martin Kelly I'd really prefer not to do that. There's going to be a long trail of defconfig that will be sent at pretty much the same time that are not going to have it and that will go unnotice for some time. And there's obviously the useless churn in all the defconfig that are not in the case where it makes sense to override DEFAULT_FDT_FILE. Why not create a Kconfig boolean that allows to select whether or not you want DEFAULT_FDT_FILE to be DEFAULT_DEVICE_TREE + .dtb or a custom value. Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: